Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220826075839.292615-1-raychi@google.com> <Yw4GH4U5ULV3VFSY@kroah.com>
In-Reply-To: <Yw4GH4U5ULV3VFSY@kroah.com>
From:   Ray Chi <raychi@google.com>
Date:   Fri, 2 Sep 2022 17:28:24 +0800
Message-ID: <CAPBYUsA1oARNuGus5uzxZ7Co+gJrm2V_axCPsyZHhp85cndaAg@mail.gmail.com>
Subject: Re: [PATCH] usb: core: stop USB enumeration if too many retries
To:     Greg KH <gregkh@linuxfoundation.org>
Cc:     mathias.nyman@linux.intel.com,
        Alan Stern <stern@rowland.harvard.edu>,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
        Albert Wang <albertccwang@google.com>,
        Badhri Jagan Sridharan <badhri@google.com>,
        Puma Hsu <pumahsu@google.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Aug 30, 2022 at 8:44 PM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Fri, Aug 26, 2022 at 03:58:39PM +0800, Ray Chi wrote:
> > If a broken accessory connected to a USB host, usbcore might
> > keep doing enumeration retries and it will take a long time to
> > cause system unstable.
> >
> > This patch provides a quirk to specific USB ports of the hub to
> > stop USB enumeration if needed.
>
> Where does it ever allow the port to handle new devices in the future if
> the device is removed and then a new one is added back?  Or is the port
> just now dead for forever?
>

I modified the patch according to Alan's suggestion, so the port will
be working again
after clearing the quirk with the v2 patch.

> thanks,
>
> greg k-h

Thanks,
Ray