Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <092ed898-dee9-e27f-1f18-3a17b259563e@collabora.com>
Date:   Fri, 2 Sep 2022 13:12:52 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.12.0
Subject: Re: [PATCH 0/3] Enable initial support for StarFive VisionFive V1 SBC
Content-Language: en-US
To:     Conor.Dooley@microchip.com, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, paul.walmsley@sifive.com,
        palmer@dabbelt.com, aou@eecs.berkeley.edu,
        michael.zhu@starfivetech.com, drew@beagleboard.org, kernel@esmil.dk
Cc:     devicetree@vger.kernel.org, linux-riscv@lists.infradead.org,
        linux-kernel@vger.kernel.org, kernel@collabora.com
References: <20220901224253.2353071-1-cristian.ciocaltea@collabora.com>
 <04151f8b-5722-b5a0-a4ab-4958f55b8dec@microchip.com>
From:   Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
In-Reply-To: <04151f8b-5722-b5a0-a4ab-4958f55b8dec@microchip.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 9/2/22 09:27, Conor.Dooley@microchip.com wrote:
> On 01/09/2022 23:42, Cristian Ciocaltea wrote:
>> [You don't often get email from cristian.ciocaltea@collabora.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>>
>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>>
>> The StarFive VisionFive V1 SBC [1] is similar with the already supported
>> BeagleV Starlight Beta board, both being based on the StarFive JH7100 SoC.
>>
>> In addition to documenting the necessary compatibles, this patch series
>> moves most of the content from jh7100-beaglev-starlight.dts to a new file
>> jh7100-common.dtsi, to be shared between the two boards.
>>
>> No other changes are required in order to successfully boot the board.
> 
> Gave it a go this morning, dts stuff itself looks good to me. No new
> warnings, although that's to be expected, & boots fine.
> 
> I know that most jn7100 stuff is not really wanted upstream, but I'd
> say that the minimal vision5 dts is an exception to that, so with the
> one comment on patch 1 resolved:
> 
> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

Thanks for the quick review, I have submitted v2:

https://lore.kernel.org/all/20220902100806.2378543-1-cristian.ciocaltea@collabora.com/

Regards,
Cristian

> Thanks,
> Conor.
> 
>>
>> [1] https://github.com/starfive-tech/VisionFive
>>
>> Cristian Ciocaltea (3):
>>     dt-bindings: riscv: starfive: Add StarFive VisionFive V1 board
>>     riscv: dts: starfive: Add common DT for JH7100 based boards
>>     riscv: dts: starfive: Add StarFive VisionFive V1 device tree
>>
>>    .../devicetree/bindings/riscv/starfive.yaml   |   3 +
>>    arch/riscv/boot/dts/starfive/Makefile         |   2 +-
>>    .../dts/starfive/jh7100-beaglev-starlight.dts | 153 +----------------
>>    .../boot/dts/starfive/jh7100-common.dtsi      | 161 ++++++++++++++++++
>>    .../jh7100-starfive-visionfive-v1.dts         |  20 +++
>>    5 files changed, 186 insertions(+), 153 deletions(-)
>>    create mode 100644 arch/riscv/boot/dts/starfive/jh7100-common.dtsi
>>    create mode 100644 arch/riscv/boot/dts/starfive/jh7100-starfive-visionfive-v1.dts
>>
>> --
>> 2.37.2
>>
>>
>> _______________________________________________
>> linux-riscv mailing list
>> linux-riscv@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-riscv
>