Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <7591cea9e718f6abfee14f08e97937b1c2722dd6.camel@perches.com>
Subject: Re: [PATCH v2] checkpatch: Handle FILE pointer type
From:   Joe Perches <joe@perches.com>
To:     =?ISO-8859-1?Q?Micka=EBl_Sala=FCn?= <mic@digikod.net>,
        Andy Whitcroft <apw@canonical.com>,
        Andrew Morton <akpm@linux-foundation.org>
Cc:     Dwaipayan Ray <dwaipayanray1@gmail.com>,
        Lukas Bulwahn <lukas.bulwahn@gmail.com>,
        Shuah Khan <shuah@kernel.org>, linux-kernel@vger.kernel.org,
        linux-kselftest@vger.kernel.org
Date:   Fri, 02 Sep 2022 05:00:18 -0700
In-Reply-To: <20220902111923.1488671-1-mic@digikod.net>
References: <20220902111923.1488671-1-mic@digikod.net>
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 8BIT
User-Agent: Evolution 3.44.4 (3.44.4-1.fc36) 
MIME-Version: 1.0
Precedence: bulk

On Fri, 2022-09-02 at 13:19 +0200, Micka?l Sala?n wrote:
> When using a "FILE *" type, checkpatch considers this an error:
>   ERROR: need consistent spacing around '*' (ctx:WxV)
>   #32: FILE: f.c:8:
>   +static void a(FILE *const b)
[]
> Signed-off-by: Micka?l Sala?n <mic@digikod.net>

Acked-by: Joe Perches <joe@perches.com>

> Link: https://lore.kernel.org/r/20220902111923.1488671-1-mic@digikod.net
> ---
> Changes since v1:
> https://lore.kernel.org/r/20220901145948.1456353-1-mic@digikod.net
> * Remove the FIXTURE_{DATA,VARIANT}() comments.
> * Improve commit description.
> ---
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -576,10 +576,14 @@ our $typeKernelTypedefs = qr{(?x:
>  	(?:__)?(?:u|s|be|le)(?:8|16|32|64)|
>  	atomic_t
>  )};
> +our $typeStdioTypedefs = qr{(?x:
> +	FILE
> +)};
>  our $typeTypedefs = qr{(?x:
>  	$typeC99Typedefs\b|
>  	$typeOtherOSTypedefs\b|
> -	$typeKernelTypedefs\b
> +	$typeKernelTypedefs\b|
> +	$typeStdioTypedefs\b
>  )};
>  
>  our $zero_initializer = qr{(?:(?:0[xX])?0+$Int_type?|NULL|false)\b};
> 
> base-commit: b90cb1053190353cc30f0fef0ef1f378ccc063c5