Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH v3 09/19] hwmon: (mr75203) add VM active channel support
Message-ID: <83567278-45dd-faf9-f19f-9167026a8e42@amazon.com>
Date:   Fri, 2 Sep 2022 15:04:55 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.1
To:     Andy Shevchenko <andriy.shevchenko@intel.com>
CC:     <jdelvare@suse.com>, <linux@roeck-us.net>, <robh+dt@kernel.org>,
        <p.zabel@pengutronix.de>, <rtanwar@maxlinear.com>,
        <linux-hwmon@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <talel@amazon.com>,
        <hhhawa@amazon.com>, <jonnyc@amazon.com>, <hanochu@amazon.com>,
        <ronenk@amazon.com>, <itamark@amazon.com>, <shellykz@amazon.com>,
        <shorer@amazon.com>, <amitlavi@amazon.com>, <almogbs@amazon.com>,
        <dkl@amazon.com>, "Farber, Eliav" <farbere@amazon.com>
References: <20220830192212.28570-1-farbere@amazon.com>
 <20220830192212.28570-10-farbere@amazon.com>
 <Yw9KcvaFzCcPw7qw@smile.fi.intel.com>
Content-Language: en-US
From:   "Farber, Eliav" <farbere@amazon.com>
In-Reply-To: <Yw9KcvaFzCcPw7qw@smile.fi.intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 8/31/2022 2:48 PM, Andy Shevchenko wrote:
> On Tue, Aug 30, 2022 at 07:22:02PM +0000, Eliav Farber wrote:
>> Add active channel support per voltage monitor.
>> The number of active channels is read from the device-tree.
>> When absent in device-tree, all channels are assumed to be used.
>>
>> This shall be useful to expose sysfs only for inputs that are connected
>> to a voltage source.
>>
>> Setting number of active channels to 0, means that entire VM sensor is
>> not used.
>
> ...
>
>> +struct voltage_device {
>> +     u32 vm_map;     /* Map channel number to VM index */
>> +     u32 ch_map;     /* Map channel number to channel index */
>> +};
>> +
>> +struct voltage_channels {
>> +     u32 total;      /* Total number of channels in all VMs */
>> +     u8 max;         /* Maximum number of channels among all VMs */
>> +};
>
> Why not convert them to kernel doc?
>
Fixed in v4.


>> +     ret = device_property_read_u8_array(dev, 
>> "moortec,vm-active-channels",
>> +                                         vm_active_ch, vm_num);
>> +     if (ret) {
>> +             /*
>> +              * Incase vm-active-channels property is not defined,
>> +              * we assume each VM sensor has all of its channels
>> +              * active.
>> +              */
>> +             for (i = 0; i < vm_num; i++)
>> +                     vm_active_ch[i] = ch_num;
>
> NIH memset().

Fixed in v4.


>> +             pvt->vm_channels.max = ch_num;
>> +             pvt->vm_channels.total = ch_num * vm_num;
>> +     } else {
>> +             for (i = 0; i < vm_num; i++) {
>> +                     if (vm_active_ch[i] > ch_num) {
>> +                             dev_err(dev, "invalid active channels: 
>> %u\n",
>> +                                     vm_active_ch[i]);
>> +                             return -EINVAL;
>> +                     }
>> +
>> +                     pvt->vm_channels.total += vm_active_ch[i];
>> +
>> +                     if (vm_active_ch[i] > pvt->vm_channels.max)
>> +                             pvt->vm_channels.max = vm_active_ch[i];
>> +             }
>> +     }
>
> ...
>
>> +     k = 0;
>> +     for (i = 0; i < vm_num; i++)
>> +             for (j = 0; j < vm_active_ch[i]; j++) {
>> +                     pvt->vd[k].vm_map = vm_idx[i];
>> +                     pvt->vd[k].ch_map = j;
>
>> +                     k++;
>
> How is it different from moving this outside the inner loop as
>
>        k += vm_active_ch[i];
>
> ?

k is used inside the inner loop, so increasing it outside the inner loop
will result in a different incorrect setting of vm_map and ch_map.

>> +             }
>
> Missed outer {}.

Fixed in v4.


--
Regards, Eliav