Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   <Kumaravel.Thiagarajan@microchip.com>
To:     <ilpo.jarvinen@linux.intel.com>
CC:     <andy.shevchenko@gmail.com>, <gregkh@linuxfoundation.org>,
        <jirislaby@kernel.org>, <u.kleine-koenig@pengutronix.de>,
        <johan@kernel.org>, <wander@redhat.com>,
        <etremblay@distech-controls.com>, <macro@orcam.me.uk>,
        <geert+renesas@glider.be>, <jk@ozlabs.org>,
        <phil.edworthy@renesas.com>, <lukas@wunner.de>,
        <linux-kernel@vger.kernel.org>, <linux-serial@vger.kernel.org>,
        <UNGLinuxDriver@microchip.com>
Subject: RE: [PATCH v1 tty-next 1/2] 8250: microchip: pci1xxxx: Add driver for
 the quad-uart function in the multi-function endpoint of pci1xxxx device.
Thread-Topic: [PATCH v1 tty-next 1/2] 8250: microchip: pci1xxxx: Add driver
 for the quad-uart function in the multi-function endpoint of pci1xxxx device.
Thread-Index: AQHYvKpRU4W9kTjyqEqLC8EMyu3nVa3Ki2PAgAAMcgCAAWi3gA==
Date:   Fri, 2 Sep 2022 11:57:24 +0000
Message-ID: <BN8PR11MB3668FA6A2247710ED7DEF16EE97A9@BN8PR11MB3668.namprd11.prod.outlook.com>
References: <20220830180054.1998296-1-kumaravel.thiagarajan@microchip.com>
 <20220830180054.1998296-2-kumaravel.thiagarajan@microchip.com>
 <CAHp75VfraADCTmZATWTSsYtC5uk5bc=WDVVm0jtUVO90xdFd9g@mail.gmail.com>
 <BN8PR11MB3668BAC07D493EE02AEAEB14E97B9@BN8PR11MB3668.namprd11.prod.outlook.com>
 <63f48d1-f716-5040-c8d1-486087bd1c5e@linux.intel.com>
In-Reply-To: <63f48d1-f716-5040-c8d1-486087bd1c5e@linux.intel.com>
Accept-Language: en-IN, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?pwmB11ZCVJgD7J5hFEepFeXzsHcs6zJTnY9EVcAc7I5f+kMakl2Jyi9B/D?=
 =?iso-8859-1?Q?rRKK8Y1L89zaS1o1XFz5lcWLljxXdgSLRV16RSE8pUu21kOag6WauQk0cF?=
 =?iso-8859-1?Q?OtNuYYQmbVISIXrE0Z5FTUTfv9B6w8HbR45LFDsbQL3nMJG+pRnSM9ecNq?=
 =?iso-8859-1?Q?VRG448IpW4dJ7FUNrcKTwHJZA+LNUcOlYGJcrdYAa8WtrMQTCOQ5fXpVrs?=
 =?iso-8859-1?Q?pOwD/P0wmBE0s6BDKIJn8O9vVLI9444fZL+Wkf+Z+6YCzCxYiGEZJJcg4C?=
 =?iso-8859-1?Q?m/gyFS+60dU4xIiwC1V7c3UJyE6EGjx7U+Q8Q6LEeEmqQC6JvT0Z0ODoHe?=
 =?iso-8859-1?Q?EoOWZ6e09kDFeYZZx9R+bUXYhGq/hrHoOMz9aeRmTVAMuIiMSp6NVwVaRA?=
 =?iso-8859-1?Q?BYWgEnf5UuOeq6/3bH7HJyNh6szRtItuiHE2JuppQaZzf4OBUlY1xBY/Zc?=
 =?iso-8859-1?Q?/4CKMPQYIWmj7oPbi2ynbcYOHxsKfEI3SjebfL8MPFJd4KQm835Q+vAYE+?=
 =?iso-8859-1?Q?MBDW89V1Kp92wxdtTrsPJx53BLQ0IDLIle2NspXzYVvQlMHs8yqHLI+kka?=
 =?iso-8859-1?Q?loJiwgt5bz4eItt6IS4+aeUyzgslj4E7jb9uuzmmHAGWLa36ueaNrMpLcB?=
 =?iso-8859-1?Q?5CjUX1KtHIITZmwadGM1k8K0/QnZcsTXxkSzra6wbBLatfewfnZqxaIYO1?=
 =?iso-8859-1?Q?Azd5F3b9E0bQ58MBJ9RpUHBI1mO1/YIy1y3+NoZ+6v+IrRJ+yqXyf39Lew?=
 =?iso-8859-1?Q?JwA1wK2uNfgE6NEHzmEQ/cH0ndIqG9PL8mnx+k9hgvkW3L4vEQH+Cn4Bdt?=
 =?iso-8859-1?Q?psocqu9KhUpBym3yrIQaQJsSxFdMtMTrA2I0s7mbLZj3/5AIbDj9eBHZxh?=
 =?iso-8859-1?Q?GYvQdn3xcDsYs+r9hgVQgHZw2APJElDt4ClBI5yLraKw66he1/IvqjJG/i?=
 =?iso-8859-1?Q?yFAD3nnirFmDYDATP84jmuBEVzSWCw3CaihLdCiVk8YJmXDP44KQVNAUs1?=
 =?iso-8859-1?Q?HqUC+BmuajiKf94Pbo1vpouddt4PsLAxB2J4+5tziWZJDDTuFx0dhQSkV7?=
 =?iso-8859-1?Q?Md2sR+C97id5r5bHJ08qFNJp6lqt8D6R8luxT++jwj1CWEVuaHT7sIUE7f?=
 =?iso-8859-1?Q?wGD7J5wwgT0uoyBjuIysgBwaT1TloUcf8tAMRRSX8L6vM6Lzr1/G9nIWKu?=
 =?iso-8859-1?Q?YNhZloJ+r0/mYzBAQdNcl1kdlOyX5YtiiqEv7n1XlLngmXOWyOabxzyolP?=
 =?iso-8859-1?Q?uOfy67QlW6RyNJCz4FU3/eTW4fruydoAvdVIy/fTiF6Bj5mdatnLpX+ZGz?=
 =?iso-8859-1?Q?XpNZ2Ti2YAgwEyc7tNLut4/xpNRfMEJfu9vxkjDaERMnjGiuQW09qHFgbf?=
 =?iso-8859-1?Q?EA0QmPb44XLnBL+oUiYRgZkn+g8L54gR/xdudBg/0tbfD1+nP7aLfHpOGw?=
 =?iso-8859-1?Q?O+Qsa9Z0tnXYHVPtvQCPskg/lZ29wYpcqsEOKmzVlUJ43y19rv3984iGrX?=
 =?iso-8859-1?Q?L+bXm9ckyITovlqIFtPHLYTENke+8V9S+gape+3uam5iWarBJn1eGTviNZ?=
 =?iso-8859-1?Q?G9EEeVgqk+mTwInDEen5hrqKqegv0DF0nZhrNSsKXqn7dN6araX6RDxYNK?=
 =?iso-8859-1?Q?KPoMb9RBY5PhsNY/yKBQwQIsYm1z2aORHeS0ggctcgfeeOQIedaRYOYraH?=
 =?iso-8859-1?Q?SF/70/M/MWHsRYUISSo=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN8PR11MB3668.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f331f5d4-7a8a-4941-5c39-08da8cda4d1c
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Sep 2022 11:57:25.0184
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: a2uV9/h7qaA2PKcm8AQ2ayR2J1K+SlF6oR8g4rU0CenPmZv6BTqrTSrAhOyjOv+YqlSkYMfK19VwarAWge5XWk4/w261JcA6MogG7jaewJobLpR5lRABjw4G88YOVzgv
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4711
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,
        SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: Ilpo J=E4rvinen <ilpo.jarvinen@linux.intel.com>
> Sent: Thursday, September 1, 2022 7:12 PM
> To: Kumaravel Thiagarajan - I21417 <Kumaravel.Thiagarajan@microchip.com>
> Cc: andy.shevchenko@gmail.com; Greg Kroah-Hartman
> <gregkh@linuxfoundation.org>; Jiri Slaby <jirislaby@kernel.org>; u.kleine=
-
> koenig@pengutronix.de; johan@kernel.org; wander@redhat.com;
> etremblay@distech-controls.com; macro@orcam.me.uk;
> geert+renesas@glider.be; jk@ozlabs.org; phil.edworthy@renesas.com;
> Lukas Wunner <lukas@wunner.de>; LKML <linux-kernel@vger.kernel.org>;
> linux-serial <linux-serial@vger.kernel.org>; UNGLinuxDriver
> <UNGLinuxDriver@microchip.com>
> Subject: RE: [PATCH v1 tty-next 1/2] 8250: microchip: pci1xxxx: Add drive=
r for
> the quad-uart function in the multi-function endpoint of pci1xxxx device.
>=20
>=20
> On Thu, 1 Sep 2022, Kumaravel.Thiagarajan@microchip.com wrote:
>=20
> > > > +       const unsigned int standard_baud_list[] =3D {50, 75, 110, 1=
34, 150,
> 300,
> > > > +                                               600, 1200, 1800, 20=
00, 2400, 3600,
> > > > +                                               4800, 7200, 9600, 1=
9200, 38400, 57600,
> > > > +                                               115200, 125000, 136=
400, 150000, 166700,
> > > > +                                               187500, 214300, 250=
000, 300000, 375000,
> > > > +                                               500000, 750000,
> > > > + 1000000, 1500000};
> > >
> > > Why?!
> >
> > The standard baud rates are handled within serial8250_do_set_termios
> > which is invoked from within mchp_pci1xxxx_set_termios in first place.
> > Hence if it matches with any of the standard baudrates, it can return
> > immediately.
>=20
> Care to explain why the baudrates in your table don't match those in
> tty_baudrate.c? ...It makes no sense to me that you call these "standard
> baud rates".
The baudrates in my table are from our legacy UART IP and these baudrates c=
an be
generated by the hardware by updating UART_DLL & UART_DLM alone as done by =
the
serial8250_do_set_termios.
I noticed that some of the baud rates in tty_baudrate.c arenot listed in th=
is table
but will still be handled by the mchp_pci1xxxx_set_termios.
I can rename standard_baud_list to simply baud_list. Please let me know.

Thank You.

Regards,
Kumaravel