Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a447f894-e343-c4c9-46c6-f33e6da8cff9@intel.com>
Date:   Fri, 2 Sep 2022 13:51:25 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.2.0
Subject: Re: [PATCH v3 2/2] ASoC: SOF: Remove strsplit_u32() and
 tokenize_input()
To:     Andy Shevchenko <andy.shevchenko@gmail.com>
CC:     ALSA Development Mailing List <alsa-devel@alsa-project.org>,
        Mark Brown <broonie@kernel.org>, Takashi Iwai <tiwai@suse.com>,
        Jaroslav Kysela <perex@perex.cz>,
        <amadeuszx.slawinski@linux.intel.com>,
        Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
        Hans de Goede <hdegoede@redhat.com>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Kai Vehmanen <kai.vehmanen@linux.intel.com>,
        =?UTF-8?Q?P=c3=a9ter_Ujfalusi?= <peter.ujfalusi@linux.intel.com>,
        Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
        Bard Liao <yung-chuan.liao@linux.intel.com>,
        Andy Shevchenko <andy@kernel.org>,
        "Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
        Matthew Wilcox <willy@infradead.org>
References: <20220901175022.334824-1-cezary.rojewski@intel.com>
 <20220901175022.334824-3-cezary.rojewski@intel.com>
 <CAHp75VdVqRyA=J0-HsHtgiAZhd8XxqxmMddTyV2u29TxvV9=Cw@mail.gmail.com>
Content-Language: en-US
From:   Cezary Rojewski <cezary.rojewski@intel.com>
In-Reply-To: <CAHp75VdVqRyA=J0-HsHtgiAZhd8XxqxmMddTyV2u29TxvV9=Cw@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cXlWN3Z5OGZSZ3NibDBMQXFscW04NEVRaTR4TW9zUFZLUHJVTVRITkxkT3hv?=
 =?utf-8?B?elU1YUZOVnJnbXhSRDFvbmJUZWZGM2JneVBLTzJlWmlKNjRVY05CREFJYUpn?=
 =?utf-8?B?ZEM1VHFUeWUxZUtJamplQUV3dEVHMkkxVnZsL2F1aW8zbWpsa3BJMVhLbDJJ?=
 =?utf-8?B?MmVaZWMzZ2tMZU1wQVNaOWt2K3V5RVEvaENwV01Sc0Q3ZTlrVlNGUmNNMDVx?=
 =?utf-8?B?KzF1NWlnZXlrODlWTFlXUGtGdGZiL2Zld3RNK09vdmFpUXFrdndOUVZqOFVC?=
 =?utf-8?B?eG11VlE1VlpZOGRvemtiMm9UaHNhWlFYUk8wRUdiRlhlNEJsQVJqS2F0SWxr?=
 =?utf-8?B?ckZjNTc3MDdWbklFZkI0V2QwcDJNMlo4NEcyWG1vZHc4T3ZsQWxaSzJ4Nno2?=
 =?utf-8?B?RkdyVVNneTErMWxRTkMwL3ppa3luRkZYTkN0ZEQvY2ZaaFFCbC85VHJCTEJM?=
 =?utf-8?B?bEJ6VVY1QWpjOE5DWFhiZk5aL1UxSzJ1aWljR3NyNnRjZzJPajB3c1pFZmhH?=
 =?utf-8?B?RkgvaTU3MGN6MWkrMTlUMXpWOTl3WDBUZytNanIrenFsK3JHQnVRQ2l5SHVq?=
 =?utf-8?B?QStqWkhwSU11bndFVlZyT2ZXem1ucjlHOUw1N2lGeHc1ZWc1ZjhhWWkxNy82?=
 =?utf-8?B?SmVCTHZqbGdMUzJBMW4va1NEZkVMSmZmM2wwaDFyOHdGT1NwdEtFSGN3bjZI?=
 =?utf-8?B?L0QwU1drZFc4TFNFQmM4RnJaVmlTb01qeUlyZTluSjYyTWdoc1MwQlNyV0Y1?=
 =?utf-8?B?UGs2OFZTNlFYUmtiSkVER0JTcytST0UxQmRGeHE4YTNHNGR6VGMzU3VxOWc2?=
 =?utf-8?B?dmhGMUh0NmFUajlKUktDUzFTR0FiQzRWemc5WjZxUFk0OFJNcFB4YTFIL3o0?=
 =?utf-8?B?RDVFTWhnK2h1TU5WMnVmN3FsaHRTRFFjS2wvS01paDFjWDNZbUlQcGJRbm1N?=
 =?utf-8?B?K0U2cENMZjZCTE9ObEV5RGR5YlVuK0RIdjFZaWpRck5zZ3pmZXZxSlNLT09X?=
 =?utf-8?B?SWtRVVJUZTJUMTJyZlVKYVRCbUliREtrcXNXZDEwT2FZYlhzRGR1QmdmMEdw?=
 =?utf-8?B?Ylp3T0loQnZyM2EvLzFRN3ErQTlJOEwrNkJWeHdSeS9iTXZZVmlWMWhoSFRS?=
 =?utf-8?B?WVc3eGd5ZEJoc1dqeG91RWNremFCOFZjYzRzL0pDaWFNZzlsclBTVEIxN2xT?=
 =?utf-8?B?UStTaEliRkFUaWhxUnVaS3orU1FaRzA3RnA0RFdWeUxGSDNMMEp5VFZYbW53?=
 =?utf-8?B?NmF0emh6L2E3V2Y0TWdKS1dCSEdSSGNXNHdjZHp5enJCdDE1ZW9YdlRjNndz?=
 =?utf-8?B?cUNxN3p1ODNUVEc1L2kwZjlhUEdLQ1RTYUw2RnJrdDBVVU1ncXEwMHZoSVRK?=
 =?utf-8?B?RGJaNUNSUlJaWGM0T3psNHhqY3pwR3VnYzZTcEdNYWxhSXNjQ0ZjTllZck91?=
 =?utf-8?B?SkxMTHF3Q1ludFY3WngxSTVzUHFuS0VkUXg4aEs2THppOU1jUEk2THRVK1da?=
 =?utf-8?B?c1k2bEIvS0JNekVmZGZJRk90Yml2K3pjT3VCSHEyaHVVb3JROVJnbndvOXhV?=
 =?utf-8?B?OW1YQjlUd0ZTbE9VcE5kRTdsWEk3ZHhOK1NhaWthdnMrc2NwOFRBcnBUVTBE?=
 =?utf-8?B?eXJCem01ZUdodGdRRGdjaWdmUENJU1c2NzdFVngzZkxSbGJ6WFVDQjlmanMr?=
 =?utf-8?B?L1oyVE9Ba3MvckdWdVcxaDRvWXhRMUhkaDlhOGZEVlZ0SDBueXJhVHROY2k2?=
 =?utf-8?B?dnVVV3JzYnRyaVhrNm5CN01VN3Ruay9jUzZQdllwRTFaMExmYlR1V2JiV3dj?=
 =?utf-8?B?NTlHN2k1OEhDL2U4SlhoNFl4bGdsNFNmeCtLc0thNDUrQmJVNWUweGxqNHVy?=
 =?utf-8?B?OE9pZXIxWWYySVlOaGZhTjBCNnNVTnd5dmtGby9nbG5HS0RoM0NMRHk5Zm9o?=
 =?utf-8?B?d2VIb1phNWJ4MWxNNUk1b25zRVpwTmRLdVlkZlVERHFGQkdTQ1AxS1FBRFRW?=
 =?utf-8?B?U3BvdExpa2owN01ObW1Xb3k0K3prTmhFR2NUdnZWdVlyVnVCZVExNFBSKzFx?=
 =?utf-8?B?ZmpsSmk3SENtWHZNbDBOVkYyamxjNjdGRldKWG8vREFZdWhDeFZsa0dVNWVz?=
 =?utf-8?B?L0o0ait2SzNMOENTenpUNzR2LzduUDU1VU82bVdpSUljdm9KcGxaMy95K3gz?=
 =?utf-8?B?dGc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: fbad2007-87e4-4d7b-eb08-08da8cd97b0c
X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB6375.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Sep 2022 11:51:32.8940
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6shtlk2OTB8Wm/nuuwF3DzFj3wH5YeQleD5XSx9zUORexEq0IPMcJo76fsJ9vvFtozohniSjPctUyUV7cDZFVLAVhYRZQ+weF5vFHryEX60=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3717
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2022-09-01 9:38 PM, Andy Shevchenko wrote:
> On Thu, Sep 1, 2022 at 8:40 PM Cezary Rojewski
> <cezary.rojewski@intel.com> wrote:
>>
>> Make use of global user input tokenization helper instead of the
>> internal one as both serve same purpose. With that, both strsplit_u32()
> 
> the same
> 
>> and tokenize_input() become unused so remove them.

...

>>   #include <linux/debugfs.h>
>>   #include <linux/module.h>
>>   #include <linux/pm_runtime.h>
>> +#include <linux/string_helpers.h>
> 
> I believe either blank line needs to be here (to split the sound / SOF
> group of headers) or this should be put after 'so*'-ones

Newline it is then.

>>   #include <sound/soc.h>
>>   #include <sound/sof/header.h>
>>   #include "sof-client.h"

...

>>          struct sof_probes_priv *priv = cdev->data;
>>          struct device *dev = &cdev->auxdev.dev;
>>          struct sof_probe_point_desc *desc;
>> -       size_t num_tkns, bytes;
>> -       u32 *tkns;
>> +       size_t bytes;
>> +       u32 num_tkns, *tkns;
> 
> I would expect a longer line first.

Ack.


> With the above addressed
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
>