Received: by 2002:a05:6358:45e:b0:b5:b6eb:e1f9 with SMTP id 30csp1962420rwe; Fri, 2 Sep 2022 06:39:58 -0700 (PDT) X-Google-Smtp-Source: AA6agR7V7aYymQ30+OSMEy151RLZ74XqieiRc4HA+ZQFIPSFxIk3m27/Qiqbeuuf7ZFixcoxu/rJ X-Received: by 2002:a17:902:ef45:b0:170:8b19:4e0f with SMTP id e5-20020a170902ef4500b001708b194e0fmr36047694plx.120.1662125998581; Fri, 02 Sep 2022 06:39:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662125998; cv=none; d=google.com; s=arc-20160816; b=0sABj5T9GmCZpqL/rQ/t0ar7AeT8z7Dwwpz0fJ4YeFV6rABkNUDGvWsPJh3uciswfc A5HNiod5yc/SUd3LbvGoGl1T8Z1rczhN5/wzUfyKU84TDmsFMers+uoxitEUFyRc+js2 Eb8mo/xinfVl2QTZNqbUxBrQrEyw/zZuj139IzGsp6dsdWugKt4c3ZeCxxBVGJfUL/ke WpEf4QgwOs9Boyu2qiusy+MEuGHOiwEiQJMYguUygp8YwewZ/L5SPlK5Xj/0Vm1eXcxf k39+rKd7OH+y4MC0qXYIC+3AQz7I1+SWt25yL68JImLxtlp1tfW9EfavaGgl4jwvPOam hHkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=re8W2pn5W7to9cEY53TaQ0+S8pmBEsJyTYADtdfus+0=; b=uOMx3c7ozWTRX6f8N3NXd3j0nrNXw6wUHOSHS5Nv5t2pn/nyEndbNgJXujIqUSPD6t Xf1E6UHvnMnRZcxNYdx+OAihKAGI97W1H17Q4PmDqWHalccWtmph+jCsS/gDU3NlMdbv Ckxp9UMt7MjWo11GD5eg0/B3BLQG07kntfh+Dwizcnqj0bnXhH3WoC05XyA/Ns6HP5G+ yJqJU+1/9R9L0M3PIRxH5svNPW3SVye5h+hWu5fRxVlREIBvy/lIJ1QnwG9LZ6ZnyatW MYScHkEKc2/R3VnwxchNWCgCOKjgRNUVBKCUf9kBsgejvxwZOdf9URh6eUAQxw6XoXhq 8dzg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=QuDpzGb8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h130-20020a636c88000000b004301e6b2ec3si1840857pgc.607.2022.09.02.06.39.41; Fri, 02 Sep 2022 06:39:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=QuDpzGb8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236792AbiIBMcr (ORCPT + 99 others); Fri, 2 Sep 2022 08:32:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37014 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236439AbiIBMbl (ORCPT ); Fri, 2 Sep 2022 08:31:41 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C516EE1AB9; Fri, 2 Sep 2022 05:27:09 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 37B7662178; Fri, 2 Sep 2022 12:27:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 44C78C433C1; Fri, 2 Sep 2022 12:27:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1662121628; bh=kbqhYeilcXusCl2mgIc1i1PvjLcthAyrfbJIfvIOEj0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=QuDpzGb8XWWjG0GNaKGC1fjwzIV8V/h/uqv9ifn/e1uCiMT0d5pjnvRQO8TxjI9KF GVR73UIT1qF34ScWmVtyqEgDU03DXrduB6/1m8BvlgY/bFO5GpFGd4G69/vzRvPAIV m0HJ3MTCXMGu6r2LhQVDfsNCzPLkAftJgkltYdd0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Trond Myklebust , Sasha Levin Subject: [PATCH 5.4 14/77] SUNRPC: RPC level errors should set task->tk_rpc_status Date: Fri, 2 Sep 2022 14:18:23 +0200 Message-Id: <20220902121404.110025520@linuxfoundation.org> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20220902121403.569927325@linuxfoundation.org> References: <20220902121403.569927325@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Trond Myklebust [ Upstream commit ed06fce0b034b2e25bd93430f5c4cbb28036cc1a ] Fix up a case in call_encode() where we're failing to set task->tk_rpc_status when an RPC level error occurred. Fixes: 9c5948c24869 ("SUNRPC: task should be exit if encode return EKEYEXPIRED more times") Signed-off-by: Trond Myklebust Signed-off-by: Sasha Levin --- net/sunrpc/clnt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sunrpc/clnt.c b/net/sunrpc/clnt.c index 08e1ccc01e983..1893203cc94fc 100644 --- a/net/sunrpc/clnt.c +++ b/net/sunrpc/clnt.c @@ -1896,7 +1896,7 @@ call_encode(struct rpc_task *task) break; case -EKEYEXPIRED: if (!task->tk_cred_retry) { - rpc_exit(task, task->tk_status); + rpc_call_rpcerror(task, task->tk_status); } else { task->tk_action = call_refresh; task->tk_cred_retry--; -- 2.35.1