Received: by 2002:a05:6358:45e:b0:b5:b6eb:e1f9 with SMTP id 30csp1966347rwe; Fri, 2 Sep 2022 06:43:28 -0700 (PDT) X-Google-Smtp-Source: AA6agR5aRSWv61Tc+17hIGoWuqNWm5ZswK2ttyI6aqluBnRX/slKBVMc25mINw4t4PyYBGt30uc0 X-Received: by 2002:a17:902:db12:b0:16e:e5fc:56db with SMTP id m18-20020a170902db1200b0016ee5fc56dbmr36789611plx.46.1662126208591; Fri, 02 Sep 2022 06:43:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662126208; cv=none; d=google.com; s=arc-20160816; b=xSdQqT1z6suTwEQOmot83OCiz/LjN28+q4R+wJiYei9vDMDLezREtO/L42sDLTB27w VgWpPxRFmk5l/g6Ok8iA+2z3rzgB/S1heS1pkAzTxXquf9eb06n+OTQGZXergevx5jj7 cKpGTuCF0SDJ4PG1Aq7ryosNWcmJESzol5WUqUYP8rMPWMoqll0RMFWuNi0qdAJ2RhyE YTaci0be38EOp6ScnvRrwtRn7Ky0veMwA8UFHZ56svEZ90ueEQQLJrqTJE/buvsBR4HB EQi5UFESJW02+8YP7OQ9wBFYJQ18AAqN3L5xaW+VK71IeWqQnJeWN8PYpHzp+my5IWCu pQvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=ByG/Cbfs/xtIr6uzPK/iM+Y1AGaZWI8VxHbbJ4wK7t8=; b=h6yTwIlSkR+FnEiE5fMq7U4Ro/16tWbPwzPbXpsWAS64vJZjtHtDHiaOKY4knlbyoq qSScHcxwDOKApzBVYNX8QNv3m+msuYDA9u2izoxp5qbtEJWqOwj0fWzZoOvOdz+IuZTZ gyR21/PEeyr4jUwoOhavKEHKtgFaAP0Af80NQFqC3N7XOsDtQpAyfmPE/luE3brcMaD4 eFTsdrs631arZ1hf9HCIzt5R7yHyR4dQ5eg1eJHK34hHSuqkp69RESo/VPQ6x9iodAJO +lQshcG5aF9gk/ANBVZkl3HwkEUQrfH8NNuxvjsZfb2Tg3ZqV8ZLXsOoRBp4wqZGWclI dEfQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=AJlSrDYK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d10-20020a056a00198a00b0052ece684368si2249858pfl.240.2022.09.02.06.43.17; Fri, 02 Sep 2022 06:43:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=AJlSrDYK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237126AbiIBMiD (ORCPT + 99 others); Fri, 2 Sep 2022 08:38:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35504 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237048AbiIBMhW (ORCPT ); Fri, 2 Sep 2022 08:37:22 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3585D196; Fri, 2 Sep 2022 05:29:44 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 932E0B82A9A; Fri, 2 Sep 2022 12:23:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DB62AC433C1; Fri, 2 Sep 2022 12:23:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1662121387; bh=6gPjV9rlOUbTsXIzcLSSToBwAPpGY0Nzgw13d+QBlOI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=AJlSrDYKFXmKPk7bfDG1VCJkMBOeE5CjzX9uSEB7tY4OV5a2ZaHsGaarVSDfMQCDJ Ia1vVnes1RrdR1540AhjmePEahOhL+Bzn3leb3qrHS7ldvaSY/qIGAn+BbS9Ptqomv PvfSgX2YFvKqWIdihoNkFM44pFNUNf3jNybGTwck= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, syzbot+77b432d57c4791183ed4@syzkaller.appspotmail.com, Dongliang Mu , Hans Verkuil , Mauro Carvalho Chehab Subject: [PATCH 4.14 33/42] media: pvrusb2: fix memory leak in pvr_probe Date: Fri, 2 Sep 2022 14:18:57 +0200 Message-Id: <20220902121359.933312834@linuxfoundation.org> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20220902121358.773776406@linuxfoundation.org> References: <20220902121358.773776406@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dongliang Mu commit 945a9a8e448b65bec055d37eba58f711b39f66f0 upstream. The error handling code in pvr2_hdw_create forgets to unregister the v4l2 device. When pvr2_hdw_create returns back to pvr2_context_create, it calls pvr2_context_destroy to destroy context, but mp->hdw is NULL, which leads to that pvr2_hdw_destroy directly returns. Fix this by adding v4l2_device_unregister to decrease the refcount of usb interface. Reported-by: syzbot+77b432d57c4791183ed4@syzkaller.appspotmail.com Signed-off-by: Dongliang Mu Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Greg Kroah-Hartman --- drivers/media/usb/pvrusb2/pvrusb2-hdw.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/media/usb/pvrusb2/pvrusb2-hdw.c +++ b/drivers/media/usb/pvrusb2/pvrusb2-hdw.c @@ -2604,6 +2604,7 @@ struct pvr2_hdw *pvr2_hdw_create(struct del_timer_sync(&hdw->encoder_run_timer); del_timer_sync(&hdw->encoder_wait_timer); flush_work(&hdw->workpoll); + v4l2_device_unregister(&hdw->v4l2_dev); usb_free_urb(hdw->ctl_read_urb); usb_free_urb(hdw->ctl_write_urb); kfree(hdw->ctl_read_buffer);