Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <2410bc5e-4278-ed69-c57a-868ec01ada21@intel.com>
Date:   Fri, 2 Sep 2022 14:47:47 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.2.0
Subject: Re: [PATCH v4 1/2] lib/string_helpers: Introduce
 parse_int_array_user()
Content-Language: en-US
To:     =?UTF-8?Q?Amadeusz_S=c5=82awi=c5=84ski?= 
        <amadeuszx.slawinski@linux.intel.com>,
        <alsa-devel@alsa-project.org>, <broonie@kernel.org>
CC:     <tiwai@suse.com>, <perex@perex.cz>,
        <pierre-louis.bossart@linux.intel.com>, <hdegoede@redhat.com>,
        <lgirdwood@gmail.com>, <kai.vehmanen@linux.intel.com>,
        <peter.ujfalusi@linux.intel.com>,
        <ranjani.sridharan@linux.intel.com>,
        <yung-chuan.liao@linux.intel.com>, <willy@infradead.org>,
        <linux-kernel@vger.kernel.org>, <andy@kernel.org>,
        <intel-poland@eclists.intel.com>, <andy.shevchenko@gmail.com>
References: <20220902122928.632602-1-cezary.rojewski@intel.com>
 <20220902122928.632602-2-cezary.rojewski@intel.com>
 <e48ffb56-f220-adf5-87ca-1826397f2e7f@linux.intel.com>
From:   Cezary Rojewski <cezary.rojewski@intel.com>
In-Reply-To: <e48ffb56-f220-adf5-87ca-1826397f2e7f@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NnY1Wmo2dmszL2d5UTZHc0xrTHovV0NYcDc4c1ppQytCdE1KYWdISEpMaVZO?=
 =?utf-8?B?Y2dJMWRPTlc3Q2hKWlZTZU92MG1kVG93aG93TG9oaEw2T2QyUm00WFdyYkZU?=
 =?utf-8?B?RmVkbzJGNTU0UDVpQ0pHeExJc2diNCtVSWN4WHdQZWV1bTJDdUY4bmlEMUQv?=
 =?utf-8?B?Z1BEMFg4ZEppdS9NaHZacWNOMHhWK2VPdWpNRUw2dklCUWkzcHFkQTZKQytF?=
 =?utf-8?B?UGYxOVFEZnMraU9abkJBSjJBRWlMT3RKeVZCYk01N1JBZFQ3RTU2Qm5hRXkw?=
 =?utf-8?B?a3ZxU0puRnJxNDROam5ubWhURXFodGR5V0xnbFl3Y2ZFRklmcDJrWHJ4Mjhz?=
 =?utf-8?B?K2JUOHg1dXkvcXIwN0hqSkRXNjFmVTRrRytYd3h6cmxhdklNRTF3QUlMa1J3?=
 =?utf-8?B?Y0ZSQy93MmlnYVppZ094NWtHTXRYLzNKdmlTMHgrZTIxZWNwTnJYOXhiZFp4?=
 =?utf-8?B?SVZJeCswVmNSL01pbURIQkRJNWJqbndMODA1R29wZFJjVW1QRGR2bWVHTGhj?=
 =?utf-8?B?dklWRDNnY3B5cXFreFZXUG1uOGkvaEtBa21XeVlSNWRGN09WODNrMkFSZzlo?=
 =?utf-8?B?VUZJRXN3Y0QyMFVXNHMzMWVqVWRyVUZiakZlTDFxQ0YzRjExbFZxcTJmN1Vy?=
 =?utf-8?B?VmluQWN2aWZCQ3VhU1lyOGk4clZWZnJtSThUTzdKVVJCRUFYUlEzdlh3anps?=
 =?utf-8?B?RTFoR0szWnF5anNQRzJadHFLYXlmRUQzVGZHcWt5anQvT2dDVXhldUlveGtO?=
 =?utf-8?B?aFJib042U0s0K3o3TEpqa1RTTmUvVFptMVIrSTlGSFBXYUtHMitMR3FxS3NE?=
 =?utf-8?B?UWZaYW1HaVhrbEtZT3B3cUl5ck42a0hCN2pDMFNEc2FXYjBJQnNRREZEWGk4?=
 =?utf-8?B?K3ZEdHNsbjVCUm5ZbFVKMUR5SW1nRGVlbXZybFpGWkZsYjhkMm04R1cvSWFI?=
 =?utf-8?B?WmhaZm5qN1Y3OHpCVUZMZ0ZzTEU5RG5pa0o0UTBOcXh4QURXeU1xSEVDaFZN?=
 =?utf-8?B?Q3krVkN2dG9ObnlrTFFJdU1FT3lzMnpjYVJ1Sk1jcGR3TDNobWNKRm8rRVdq?=
 =?utf-8?B?YldwaThxZXFDeVVMYVNVQjVBbDh3YW9keWlYWHNOMlQ3bjJFM3NXNlY0UEwz?=
 =?utf-8?B?S0JCRGI1bUV1ZTNXcERpYXBjaDZXR3F2UHZUS2hnQndLM29WVDhBRnE4UGpD?=
 =?utf-8?B?dzRWZlgwUmZRQ1pPWmNjZnNvdG15K0NMaFNEUlpjajFUSEpuUEYzZEt0aXlT?=
 =?utf-8?B?NlZyLyt6R0lCbWY3NkhvL242ZnRGem0vY2ZQRlRWdzhRTEJVMS9aTEQ5SEtP?=
 =?utf-8?B?Q3lxeU4zaXhWYUFFbG1pNWpzL0pKU1ZDcmV1OFdsYmVxd2tYbTNoMGdoYzV0?=
 =?utf-8?B?emZ1UVFkOWQ2RzRQNXVQSDg2ZE1mZUxHdW1KaFg0a2RaV3NseW0walFtd01q?=
 =?utf-8?B?MElFbGJVdS90UzBRclJTc1hidUFmYWY5dWVTVnJVSFI1RVpUcUI0ZisrMC9E?=
 =?utf-8?B?R3l6aGdhWHoxeTNTc3BhMExHdnlBZUdBc0hQMmRXLy9HOHlkKy9kNVVINU1x?=
 =?utf-8?B?bnZabnBRS2EwbU5zNVVvdWh2bUY4cWk2a2I2Tm9BUlRCRWh6MjVPY1A1SG9H?=
 =?utf-8?B?QmhLRUpxV0VOQlM1RmdPcWNTdFJOeHIwa2h4WklpSGRTc1p6RmdQQ1JkNFZs?=
 =?utf-8?B?N3I4ZVVBVG5RMVdSTnRmWHRpMXd2YTAyYmQ2OFJnalNLVTNNQloxTC9tT21U?=
 =?utf-8?B?TEF5b0V6YW5xWlFsUGF5VStYc1ZVN0lwZkczaXoyc1l6UWl0SVI5aWorUXg3?=
 =?utf-8?B?blpDS1JTbVpFeTBFbHRLR0krYjUzc0xWc1ZCcTYxMDNydmo4SnJTVUh2TzZh?=
 =?utf-8?B?dVBIK2FZdzhmZmtpTDFkSm5Ra0RQRjJzaWZBUmg4SFQwNWtoMThVQVBjRTJ5?=
 =?utf-8?B?MUlEUjEyYVVRNGpoY0o1anlEMmwrU1BHVkxnTkJhTXd1aDZjNjgvU0NiMWVB?=
 =?utf-8?B?V3RGNU9yMXc3STd0ZjF3elV1VlRmU0NRUmVpYk1RUmU5WUx5U3RFcHZqVmhR?=
 =?utf-8?B?RzhjOEd6RG4raG1uZ3d6bFIvblV5T09jUTAwMnlPZ3Njd0Z1WWRKdTdMcWtl?=
 =?utf-8?B?S0xZcWFRU0czVHZWNEVHSmcvb2xrK0NlSjlna0lVSWtBbTFTNkNjRVRuU2dv?=
 =?utf-8?B?NkE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: f1820fd4-8577-4781-98c5-08da8ce15c3e
X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB6375.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Sep 2022 12:47:57.0576
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: A92N4LQINyvdBV1lKnwUtZO88AsJAfHLmLahtcU/sLvJA93gBi3idKC1jOzkl10vdcXioIeouMng7uPCAjN0CcLC8BV2eDGNzzaD7dQmF/U=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB4751
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2022-09-02 2:23 PM, Amadeusz Sławiński wrote:
> On 9/2/2022 2:29 PM, Cezary Rojewski wrote:

...

>> +/**
>> + * parse_int_array_user - Split string into a sequence of integers
>> + * @from:    The user space buffer to read from
>> + * @ppos:    The current position in the buffer
> 
> There is no such parameter?
> 
>> + * @count:    The maximum number of bytes to read
>> + * @tkns:    Returned pointer to sequence of integers
> 
> s/tkns/array/ ?
> 
>> + *
>> + * On success @tkns is allocated and initialized with a sequence of
> 
> ditto
> 
>> + * integers extracted from the @from plus an additional element that
>> + * begins the sequence and specifies the integers count.
>> + *
>> + * Caller takes responsibility for freeing @tkns when it is no longer
> 
> ditto
> 
>> + * needed.
>> + */
>> +int parse_int_array_user(const char __user *from, size_t count, int 
>> **array)

Ack. Will send an update shortly.


Regards,
Czarek