Received: by 2002:a05:6358:45e:b0:b5:b6eb:e1f9 with SMTP id 30csp1968967rwe; Fri, 2 Sep 2022 06:45:58 -0700 (PDT) X-Google-Smtp-Source: AA6agR6CZocuxZVe0Dk/u7Lo7d2PZCnriHcWYcJDil6vS+ObloXIF9n9UvTjxVY57+eDkZUqUYY0 X-Received: by 2002:a17:902:b692:b0:16f:87a0:ddbb with SMTP id c18-20020a170902b69200b0016f87a0ddbbmr34433491pls.35.1662126357689; Fri, 02 Sep 2022 06:45:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662126357; cv=none; d=google.com; s=arc-20160816; b=Een03X3lxZSDuN1Dazmm/W8Jk2PXoFGO5lhNo5Ph3Jygpx7i0OTTIZiK7qLpD7p0lF jv3hrWPPN7v69ULkUHFV8HCHd++PXSa/GU3+r2ngy7HW/VEjiQeyPX+MWhQAx8qhQbRd 06OfTtBVzUPcvkUCZuSCBxq3fg1+swFmIEsdyXCZAzfeqpAJMIxyOFXG3K6pP81ihI0C QttigJUgrUmMXHoU0uNPFKxNV7hnLIqKwwGTA8yK73QAQL/tjN1ofL+HSLArUwV6Phl4 TFQzVPbrFznZTT+u7D/aUcn7P1j2K89Obnok/CXPAUwhPkjMwYIzNzSpWMordD+VCVWh e5sA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=kl3ixUjiKDOb6wd2FROWi2224WQZRaG+jHauDWTt2nE=; b=CfVDL7X/Yv/k09jpdylQhy3uK5V578vy3ksLq6gJo0sGonuG3qqdIzPZsKWs60+0o7 DairOXaA6/adnlCS+Q3D0yDzfaktPxwYpLO+eAG45kQ8humn6iDVVead5+nxz7eA7Twi ItMJT2mSLOmMh1CqPIxqzolFlBEe7DGAsldBGV7TOzWYFjteiywVIvMYYmO/y8X++qm0 oeX4Gzei+CGij/TDbRKBsI9q6KZcD7yk0qy64AT/sJjgtVgB0oa+m1odfIcU3zdZum9v Jb6W3zd24ZH4kS30m1qv0e/vSZRmQqEuziT9DKUoPdSSwZOajMikwM0ea5bK/8xZvyMi lgkw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Jt+B9cbv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n11-20020a6563cb000000b0042b29871d82si2016601pgv.220.2022.09.02.06.45.43; Fri, 02 Sep 2022 06:45:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Jt+B9cbv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238625AbiIBNHQ (ORCPT + 99 others); Fri, 2 Sep 2022 09:07:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40752 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238524AbiIBNGy (ORCPT ); Fri, 2 Sep 2022 09:06:54 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C6242112EFC; Fri, 2 Sep 2022 05:44:19 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id AB85EB82ACE; Fri, 2 Sep 2022 12:35:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C1283C433D7; Fri, 2 Sep 2022 12:35:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1662122148; bh=RcY9bMWiZPvaxJI29PxskHOtvopzEBhAGDCs6Qwxy1U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Jt+B9cbvXWPp+wa0aNHGL7t7SGx4Kci4IshcN+y+Lh9BYSgCRcoVKII0eETrs10/D bynLkoLCIwMLYAnhkTjXwEc/G+MWfoEwPaLZ52tSRy+UPaTFCDKcZ5hQij1zXjeDeP p/DD8GyV/2F1rNy8ztbRnx6ubjgszwbygfUeUTxE= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Ben Greear , Stefan Roese , Bjorn Helgaas , =?UTF-8?q?Pali=20Roh=C3=A1r?= , "Rafael J. Wysocki" , Bharat Kumar Gogada , Michal Simek , Yao Hongbo , Naveen Naidu , Sasha Levin Subject: [PATCH 5.19 08/72] Revert "PCI/portdrv: Dont disable AER reporting in get_port_device_capability()" Date: Fri, 2 Sep 2022 14:18:44 +0200 Message-Id: <20220902121405.064846233@linuxfoundation.org> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20220902121404.772492078@linuxfoundation.org> References: <20220902121404.772492078@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Greg Kroah-Hartman This reverts commit 65e393fddc5379b2c41ca7e73cd4bb9572c4d90e which is commit 8795e182b02dc87e343c79e73af6b8b7f9c5e635 upstream. It is reported to cause problems, so drop it from the stable trees for now until it gets sorted out. Link: https://lore.kernel.org/r/47b775c5-57fa-5edf-b59e-8a9041ffbee7@candelatech.com Reported-by: Ben Greear Cc: Stefan Roese Cc: Bjorn Helgaas Cc: Pali Rohár Cc: Rafael J. Wysocki Cc: Bharat Kumar Gogada Cc: Michal Simek Cc: Yao Hongbo Cc: Naveen Naidu Cc: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- drivers/pci/pcie/portdrv_core.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) --- a/drivers/pci/pcie/portdrv_core.c +++ b/drivers/pci/pcie/portdrv_core.c @@ -222,8 +222,15 @@ static int get_port_device_capability(st #ifdef CONFIG_PCIEAER if (dev->aer_cap && pci_aer_available() && - (pcie_ports_native || host->native_aer)) + (pcie_ports_native || host->native_aer)) { services |= PCIE_PORT_SERVICE_AER; + + /* + * Disable AER on this port in case it's been enabled by the + * BIOS (the AER service driver will enable it when necessary). + */ + pci_disable_pcie_error_reporting(dev); + } #endif /* Root Ports and Root Complex Event Collectors may generate PMEs */