Received: by 2002:a05:6358:45e:b0:b5:b6eb:e1f9 with SMTP id 30csp1976381rwe; Fri, 2 Sep 2022 06:53:07 -0700 (PDT) X-Google-Smtp-Source: AA6agR6WO8DGcOwpxv2gUv/7CBq7sSWfmQmyG791M9xlbbRml7/tufNXXAhTQCDpQBI/Lh9Hnduy X-Received: by 2002:a17:902:694a:b0:16e:e270:1f84 with SMTP id k10-20020a170902694a00b0016ee2701f84mr35191255plt.89.1662126786909; Fri, 02 Sep 2022 06:53:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662126786; cv=none; d=google.com; s=arc-20160816; b=WTr4cqkJsNnFWc4wfY7d/95VQSa15l0SI3YT5/eBFuboROsRl7IpyPpRSnikvFk9gC znmRiWWdp1n4LGgORtQQP58wG5O7yv82LC+HTLV/KKMWZcdXh0nAYXis1rjIzZvbOlKV Xy38hmRaRUaUbeq2TehGfG6zqr1OkUsWzOwywc7hiWW5+MSGa8eBzkzVenXbBlPpgYxR vGdAMOD+6YK5TDqR/MT4R/LMiwls8ISe3Z1eL3sdIprUMgk4T0il0eM8gc4/4kvkRqOu Gq0f6O055BgdeMVmve8rqP3kl356k5omimIyk3J2bWr9qqW3QT0nsTCXPpuAeufAOl+U wSHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=gxq/3ku+TBSFzI2dOpfDMTht+xi19WdioUQPxTtCvxg=; b=ScnvGwoYmLI6YLG6/WYGmKcMRbe5cF+Oo42CyCaVObB+vpnODtIkTKdHaY4wd7vUjX 2iEz3rj/xkVA17WrruQNlww1gNnaGKcQWrq+i8e6QiT86EgUb0c8BzEPn66WBTMdnPQf C/t/HCw+xDwbidRPC1PdEvSw+BNgXrq7GPCwHybjsQ7H42FZmO1z4eKmeHIde6FCk0wX WfY45TS+cGFL/MylxyCGQdfoByz0BD5oNrK4Xm0BzCCxZ4oKzuDw2aoCUpG6PTaxDwym yA6B06Bw80ighGHhq53r1T9pCB072OyJ1J2tc7uLLbhHuiLLwxZawzb4XIM9u/LChGwG e6IA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="V7a+TT/x"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 18-20020a631252000000b00412a9231955si2008396pgs.233.2022.09.02.06.52.56; Fri, 02 Sep 2022 06:53:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="V7a+TT/x"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238148AbiIBMzK (ORCPT + 99 others); Fri, 2 Sep 2022 08:55:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33396 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237811AbiIBMxb (ORCPT ); Fri, 2 Sep 2022 08:53:31 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D999FE3979; Fri, 2 Sep 2022 05:38:06 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id DDF566217E; Fri, 2 Sep 2022 12:37:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D5FA4C433C1; Fri, 2 Sep 2022 12:37:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1662122258; bh=4Mef6oIVxypHg+mAHZHx0JWOr5/CBtzWkSoMACY3YZE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=V7a+TT/xmchhADjHRmBzZTAFc8ALdcJ5XYw15Lf9Db6Z1Q+d1hE90zki3xunMHQgb XV3TIALyEkQmbtxao9DhfFXCEge3bjCn8A/DOBsf1IpMOznW8HJHoiFBo7mo94BjZF vkjtgNZRAQW9Df0W4yyR9TMKNRaDbq02mSNxWHaE= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Akihiko Odaki , Mario Limonciello , Basavaraj Natikar , Jiri Kosina Subject: [PATCH 5.19 22/72] HID: AMD_SFH: Add a DMI quirk entry for Chromebooks Date: Fri, 2 Sep 2022 14:18:58 +0200 Message-Id: <20220902121405.511661631@linuxfoundation.org> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20220902121404.772492078@linuxfoundation.org> References: <20220902121404.772492078@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Akihiko Odaki commit adada3f4930ac084740ea340bd8e94028eba4f22 upstream. Google Chromebooks use Chrome OS Embedded Controller Sensor Hub instead of Sensor Hub Fusion and leaves MP2 uninitialized, which disables all functionalities, even including the registers necessary for feature detections. The behavior was observed with Lenovo ThinkPad C13 Yoga. Signed-off-by: Akihiko Odaki Suggested-by: Mario Limonciello Acked-by: Basavaraj Natikar Signed-off-by: Jiri Kosina Signed-off-by: Greg Kroah-Hartman --- drivers/hid/amd-sfh-hid/amd_sfh_pcie.c | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) --- a/drivers/hid/amd-sfh-hid/amd_sfh_pcie.c +++ b/drivers/hid/amd-sfh-hid/amd_sfh_pcie.c @@ -285,11 +285,29 @@ static int amd_sfh_irq_init(struct amd_m return 0; } +static const struct dmi_system_id dmi_nodevs[] = { + { + /* + * Google Chromebooks use Chrome OS Embedded Controller Sensor + * Hub instead of Sensor Hub Fusion and leaves MP2 + * uninitialized, which disables all functionalities, even + * including the registers necessary for feature detections. + */ + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "Google"), + }, + }, + { } +}; + static int amd_mp2_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id) { struct amd_mp2_dev *privdata; int rc; + if (dmi_first_match(dmi_nodevs)) + return -ENODEV; + privdata = devm_kzalloc(&pdev->dev, sizeof(*privdata), GFP_KERNEL); if (!privdata) return -ENOMEM;