Received: by 2002:a05:6358:45e:b0:b5:b6eb:e1f9 with SMTP id 30csp2023596rwe; Fri, 2 Sep 2022 07:29:34 -0700 (PDT) X-Google-Smtp-Source: AA6agR5BHg8BQroZJsXUo0ZmnBaSC2Uxnvmq9nvi11Ps35RUyR5koE6kpw4FOY0SCkTbdd5OWUyf X-Received: by 2002:a17:907:16ac:b0:741:8f9e:aa39 with SMTP id hc44-20020a17090716ac00b007418f9eaa39mr17336584ejc.429.1662128974189; Fri, 02 Sep 2022 07:29:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662128974; cv=none; d=google.com; s=arc-20160816; b=0WBhcw3q62CAQoryAkB06PMG+IFqZ8oaS/mA/npE82r6a2yiaVXMtttFEs1ErkaSO4 hEwy2MNU1EhxeSkXRZyWyoD+XGwow1aJNf2SwBJfBTx/ZM/T9Zj8ew5wmBFtlmUOrORA auO+UC+1u5wXgRylaeuoV/yh7tw1WhU5fBZgOV9VELYWxTQr4M2PsVfzg6ndyZ+zajH5 rfVACL2OhG4o3Bawmtj1tTc4o57WM6DInIP81f1gROJjWJofnSQXIffhE2voQZD8sbTL hLcaOo3Ov++qPJLZ6AAIbyWswmWTP1sGpC5m1DOtpyZ29a8aamnnfzshsMS9iogFnHvU XJ9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=6yB5dzJYuDM2bQNtmRERDpBlMIMtnD36720qXpMeNnk=; b=taUtBWJlRspwyvkHGOIri1WmBUo/g2glmJjiW6oMgfHaGiLg64ZWGRM0/rLj5NZxLH vOXbs6lwiIBPt84mOo2EGUTdTfH6gDmiBecvfO53e9hUFP99GY9CHTAvw2rhahKN7PGg FbwF3Dxr+aQm30FrF7DcHO0y8ckwvVkTLyT5AtesJYFMS8vWTWZOOSi5f7aU2k9KyOR+ IfFbrrjvGddnz/Bv5+NAFAZLgS113Uc8dScn9TkZ4gX8kNSyNkxSxyEF+FrNNiENgPhf PUEBIKrCBPxuNnk5hMANam9gI3v+4dBYRW6aUpxGiApiW7xBZpxBoOJg4Ed4EyvtgEvP Bqog== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="z2uCC8q/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z18-20020a05640240d200b004485081f004si2333074edb.598.2022.09.02.07.29.07; Fri, 02 Sep 2022 07:29:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="z2uCC8q/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237628AbiIBMtw (ORCPT + 99 others); Fri, 2 Sep 2022 08:49:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56340 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237714AbiIBMsi (ORCPT ); Fri, 2 Sep 2022 08:48:38 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DABC8A00ED; Fri, 2 Sep 2022 05:35:18 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 77766B829E8; Fri, 2 Sep 2022 12:33:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B4C0CC433D6; Fri, 2 Sep 2022 12:33:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1662122018; bh=xIwGVScQaB9wNQuwUy6UEhNULReYG68Iz9QNMVFlI5Q=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=z2uCC8q/bxvUvOTg6f5Ct2wqrBztC+rj4gXMs3Mm+NlBoZRMZhmjDhotDyzBdUPIu 4DD+eLYRivPmuRgdrmcubPbtGcyJ4VgwG636+zJ1LdhsaSzJZG3Pzy10/aVEaFqzyw IVdt1Qh32uMQdGA1EXe3JNmbYKsZIJKXRp65EdRY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, syzbot+77b432d57c4791183ed4@syzkaller.appspotmail.com, Dongliang Mu , Hans Verkuil , Mauro Carvalho Chehab Subject: [PATCH 5.15 29/73] media: pvrusb2: fix memory leak in pvr_probe Date: Fri, 2 Sep 2022 14:18:53 +0200 Message-Id: <20220902121405.402086771@linuxfoundation.org> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20220902121404.435662285@linuxfoundation.org> References: <20220902121404.435662285@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dongliang Mu commit 945a9a8e448b65bec055d37eba58f711b39f66f0 upstream. The error handling code in pvr2_hdw_create forgets to unregister the v4l2 device. When pvr2_hdw_create returns back to pvr2_context_create, it calls pvr2_context_destroy to destroy context, but mp->hdw is NULL, which leads to that pvr2_hdw_destroy directly returns. Fix this by adding v4l2_device_unregister to decrease the refcount of usb interface. Reported-by: syzbot+77b432d57c4791183ed4@syzkaller.appspotmail.com Signed-off-by: Dongliang Mu Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Greg Kroah-Hartman --- drivers/media/usb/pvrusb2/pvrusb2-hdw.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/media/usb/pvrusb2/pvrusb2-hdw.c +++ b/drivers/media/usb/pvrusb2/pvrusb2-hdw.c @@ -2610,6 +2610,7 @@ struct pvr2_hdw *pvr2_hdw_create(struct del_timer_sync(&hdw->encoder_run_timer); del_timer_sync(&hdw->encoder_wait_timer); flush_work(&hdw->workpoll); + v4l2_device_unregister(&hdw->v4l2_dev); usb_free_urb(hdw->ctl_read_urb); usb_free_urb(hdw->ctl_write_urb); kfree(hdw->ctl_read_buffer);