Received: by 2002:a05:6358:45e:b0:b5:b6eb:e1f9 with SMTP id 30csp2025159rwe; Fri, 2 Sep 2022 07:30:52 -0700 (PDT) X-Google-Smtp-Source: AA6agR4WWxrn+ZSFq/+SQv3TD8FO3L+5k0RZDBXJ9CfI5reLKnv4q+gPBN5EIpUwLjAX/+dN1s/z X-Received: by 2002:a63:5a61:0:b0:41b:b021:f916 with SMTP id k33-20020a635a61000000b0041bb021f916mr30234432pgm.387.1662129051784; Fri, 02 Sep 2022 07:30:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662129051; cv=none; d=google.com; s=arc-20160816; b=XJOoSQ3Ql8fPHDstG3yQ0+BSV0+eYbtF1OY+4KICX9THD57gM3j+JszMQe8fS0OnJC z611MTx+b+GnoybKdH3bE6zKUkZflO0iXiz2DY9OxdfnkiTxHwJnbXXKS6JXNZ9Fsfag vo9yWKm+NORLEFGvQddqnaeW+wnRiMfoQxUzZbqZhfB18XtPNlyl2yLKlUCMf/flf8ab f9juumlCSykTcGzjWgQNiIZtAUrWjwxoniprnXY5vC/Vo0YUIn7rNkO8BGSRQyHJxuGs cYRt4mkeLsQJ0vBc1JStGZrQWLqdxiRd0ALOH+dQ/AKB2suFPQoSRnMNUa39HJ0nhjnj 5jcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=J498ecBvzK9xCIYED3rY0VilK248viYHzBg6IWxHgro=; b=YcktkZmfR8sF5eEn8Rxbo6yF59Wd6Gke19z09wp5VwjKiLE882RaKqI2ihqZ5no8qQ uVLEZR+yifDSZUB2GGRD85ByDKiAYE6wwaIbqMzgBn+8641CeK00FLHyt2uWERWq/lWa 40hTCatAxNthw5NevEBjKRJiVYaPSCFr3CdGo+dnFoiSbf6JNzCFV9HIlloQg0mU+cmk lh6AEBXo4Gv9GXghefjgTyfW4KVCFwN/LAQJqvNvZUutZhzr+spb/zC2jQa9bj9GFmKG G6CMrWzFXCaZNvyfrwshE51Owz4o3DOnxtHfdpt0Kd+V/675vIXI2YcoS0HLlKQ5LK7h Hrig== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=kJWIcffR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s16-20020a056a00179000b0053aee83e1f2si2513684pfg.13.2022.09.02.07.30.30; Fri, 02 Sep 2022 07:30:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=kJWIcffR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238025AbiIBMxf (ORCPT + 99 others); Fri, 2 Sep 2022 08:53:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45212 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237876AbiIBMwx (ORCPT ); Fri, 2 Sep 2022 08:52:53 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2DB0DF8FD2; Fri, 2 Sep 2022 05:37:41 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 3BBE0B81CCF; Fri, 2 Sep 2022 12:36:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9041EC433D6; Fri, 2 Sep 2022 12:36:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1662122195; bh=sYkZkvrgtkFRSF4QEy0oqraFW7XT7ofLBS5VurAovuo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kJWIcffR2O6ONcFUXBtfeyybCG2c5waWRcc/L0paNUB/HvvdOufgBNpxEVqqg/cQX GZpqTPWLKznLVdhNHy2Zyj9bhtaDNgmqjdgyQAt4+VhNObeo14Lo9p12KKCYhG/N0m Zwc3Ghl3bgh9CYE8nmSiPDpP8gNMUuYAiXJdmrJk= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jimmy Kizito , Jun Lei , Tom Chung , Meenakshikumar Somasundaram , Daniel Wheeler , Alex Deucher , Sasha Levin Subject: [PATCH 5.19 42/72] drm/amd/display: Fix TDR eDP and USB4 display light up issue Date: Fri, 2 Sep 2022 14:19:18 +0200 Message-Id: <20220902121406.146940764@linuxfoundation.org> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20220902121404.772492078@linuxfoundation.org> References: <20220902121404.772492078@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Meenakshikumar Somasundaram [ Upstream commit 30456ffa65469d1d2e5e1da05017e6728d24c11c ] [Why] After TDR recovery, eDP and USB4 display does not light up. Because dmub outbox notifications are not enabled after dmub reload and link encoder assignments for the streams are not cleared before dc state reset. [How] - Dmub outbox notification is enabled after tdr recovery by issuing inbox command to dmub. - Link encoders for the streams are unassigned before dc state reset. Reviewed-by: Jimmy Kizito Reviewed-by: Jun Lei Acked-by: Tom Chung Signed-off-by: Meenakshikumar Somasundaram Tested-by: Daniel Wheeler Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/gpu/drm/amd/display/dc/core/dc.c | 1 + drivers/gpu/drm/amd/display/dc/dc_link.h | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c index f144494011882..7d69341acca02 100644 --- a/drivers/gpu/drm/amd/display/dc/core/dc.c +++ b/drivers/gpu/drm/amd/display/dc/core/dc.c @@ -3783,6 +3783,7 @@ void dc_enable_dmub_outbox(struct dc *dc) struct dc_context *dc_ctx = dc->ctx; dmub_enable_outbox_notification(dc_ctx->dmub_srv); + DC_LOG_DC("%s: dmub outbox notifications enabled\n", __func__); } /** diff --git a/drivers/gpu/drm/amd/display/dc/dc_link.h b/drivers/gpu/drm/amd/display/dc/dc_link.h index a3c37ee3f849c..f96f53c1bc258 100644 --- a/drivers/gpu/drm/amd/display/dc/dc_link.h +++ b/drivers/gpu/drm/amd/display/dc/dc_link.h @@ -337,6 +337,7 @@ enum dc_detect_reason { DETECT_REASON_HPDRX, DETECT_REASON_FALLBACK, DETECT_REASON_RETRAIN, + DETECT_REASON_TDR, }; bool dc_link_detect(struct dc_link *dc_link, enum dc_detect_reason reason); -- 2.35.1