Received: by 2002:a05:6358:45e:b0:b5:b6eb:e1f9 with SMTP id 30csp2051584rwe; Fri, 2 Sep 2022 07:52:01 -0700 (PDT) X-Google-Smtp-Source: AA6agR4H+1Oqx/mGFTUldUgipmHSYiyQOrLR3xRK6qCqj4ZQ+fPRs0ZACatBGDFtsJZZUIHvYLaz X-Received: by 2002:a17:902:ced2:b0:16e:e19b:c5c9 with SMTP id d18-20020a170902ced200b0016ee19bc5c9mr37199520plg.136.1662130321489; Fri, 02 Sep 2022 07:52:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662130321; cv=none; d=google.com; s=arc-20160816; b=d5v4wvKxhD7WyLYuF2nto/03OHpEvd1pVlLboQPymsL0QcFjyP5L0iwz34rA12SRWx FLsYDopnbHMa6n622xeH5vQfPvy9QVQRlfciagg+EqrWFboxiwNvqS32ul9OlQ0IH1x0 x3cBB7T6rq5BAhXTf5fiBc9VLqEDm6haiJmBK3oqp5mqQQqHmGK8gfqnsCvZHqBm0vju Wz5tXZBr8LeKw/sGXBjt4ociIpsf9S6HHL4JKRseO/72MYbr1R+vj9w5XBN0myp61qlS GnEhGPY/uLhOcB4GsE4BELxZuZO+yFqCJe7lShGXKyQhK2AT+kmXHWqoV5UpzQ+mZab0 e0jg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:date:message-id :from:subject:content-transfer-encoding:mime-version:dkim-signature; bh=7gFH2sTwaSYsP2FApVB6GaBnYell6BosVU6sdhYTMPc=; b=yBAdqqh9dr9jyVztOd+XaCObvaarUQgc0ti9XAlRgz6lqFOrDFOIUl0T6sQW9xvpk7 Y4bcD3YeyxHCEuZgSLZIc8pyr4rAXnXRyCnLFkfit6qXiRrAx3n+RN8YRVQQ1isUfXGs YrwrL91Bmuh3yIFOasHwHdIr633jRsOsldfqPVHkqtZKQ9s74ircJqlBaK4MbA8XBK+s 9iL/l8MPVx4z2s/obkKkEsmTbZwMgQ+pAi3b7+Hwmg1gBxjVyecLfplF6qf+u/eMmaDO Mw64gVG2GokCPU3Uf8bpjNFQYM9yr29l+lIAOaZSKiNheVhS3uq1HS3cOh6Ebuh+AuOp JpRQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=QwevnPlV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u21-20020a056a00125500b00536f8a6acadsi2295534pfi.2.2022.09.02.07.51.49; Fri, 02 Sep 2022 07:52:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=QwevnPlV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235677AbiIBOkv (ORCPT + 99 others); Fri, 2 Sep 2022 10:40:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52148 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236881AbiIBOkG (ORCPT ); Fri, 2 Sep 2022 10:40:06 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7401C12484B; Fri, 2 Sep 2022 07:00:59 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 64F8CB82C03; Fri, 2 Sep 2022 14:00:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id 1AE3CC433D7; Fri, 2 Sep 2022 14:00:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662127216; bh=6FkOE0V4Xl0gp19KmvjJh3tYe8TXuJxNaJXe5cYKWtY=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=QwevnPlVKT8sKyLUXOmFC3g8jLH3mwyfHt2ULozsHipTdWaNetXQIgZLubI6v789S by009iQSOMS11/xX/tVlKUyTnYoqRxIITAu7X9eTVFk/nuftkOx96+aeIsQhor1MHz l6yhZ1vEnPAOGFFVfk//OweyVjp+oU8gPOszu9XLwvdUHQUzMy++UmTGTgtbxPZDlU JsGMsul8wM8KStocJnEwWeya+1aAN4brXciTrlpRiktODdhG0Mv7GvJAVhmdYASBT5 24H1WRL/J0eieDR18h5zDUYU0li3u9TMEKadsYyzB0s7RaD4XNDx+qmlWrwbyjWVhR ihxU86cWFOJmg== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id EFF0DC4166F; Fri, 2 Sep 2022 14:00:15 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH v1] selftests/xsk: Avoid use-after-free on ctx From: patchwork-bot+netdevbpf@kernel.org Message-Id: <166212721597.8214.1758586217041951809.git-patchwork-notify@kernel.org> Date: Fri, 02 Sep 2022 14:00:15 +0000 References: <20220901202645.1463552-1-irogers@google.com> In-Reply-To: <20220901202645.1463552-1-irogers@google.com> To: Ian Rogers Cc: bjorn@kernel.org, magnus.karlsson@intel.com, maciej.fijalkowski@intel.com, jonathan.lemon@gmail.com, ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, martin.lau@linux.dev, song@kernel.org, yhs@fb.com, john.fastabend@gmail.com, kpsingh@kernel.org, sdf@google.com, haoluo@google.com, jolsa@kernel.org, mykolal@fb.com, shuah@kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello: This patch was applied to bpf/bpf-next.git (master) by Daniel Borkmann : On Thu, 1 Sep 2022 13:26:45 -0700 you wrote: > The put lowers the reference count to 0 and frees ctx, reading it > afterwards is invalid. Move the put after the uses and determine the > last use by the reference count being 1. > > Fixes: 39e940d4abfa ("selftests/xsk: Destroy BPF resources only when ctx refcount drops to 0") > Signed-off-by: Ian Rogers > > [...] Here is the summary with links: - [v1] selftests/xsk: Avoid use-after-free on ctx https://git.kernel.org/bpf/bpf-next/c/af515a5587b8 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html