Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Kani, Toshi" <toshi.kani@hpe.com>
To:     Jia He <justin.he@arm.com>, Len Brown <lenb@kernel.org>,
        James Morse <james.morse@arm.com>,
        Tony Luck <tony.luck@intel.com>,
        Borislav Petkov <bp@alien8.de>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Robert Richter <rric@kernel.org>,
        Robert Moore <robert.moore@intel.com>,
        Qiuxu Zhuo <qiuxu.zhuo@intel.com>,
        Yazen Ghannam <yazen.ghannam@amd.com>,
        Jan Luebbe <jlu@pengutronix.de>,
        Khuong Dinh <khuong@os.amperecomputing.com>
CC:     Ard Biesheuvel <ardb@kernel.org>,
        "linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
        "devel@acpica.org" <devel@acpica.org>,
        "Rafael J . Wysocki" <rafael@kernel.org>,
        Shuai Xue <xueshuai@linux.alibaba.com>,
        Jarkko Sakkinen <jarkko@kernel.org>,
        "linux-efi@vger.kernel.org" <linux-efi@vger.kernel.org>,
        "nd@arm.com" <nd@arm.com>
Subject: RE: [PATCH v4 3/8] EDAC:ghes: Move ghes_edac.force_load to ghes
 module parameter
Thread-Topic: [PATCH v4 3/8] EDAC:ghes: Move ghes_edac.force_load to ghes
 module parameter
Thread-Index: AQHYvQ0ZnDLuwTvH6U+YXmEA+QE6sq3MO6Sg
Date:   Fri, 2 Sep 2022 14:54:25 +0000
Message-ID: <DM4PR84MB18539F451E3C89DA2853539B827A9@DM4PR84MB1853.NAMPRD84.PROD.OUTLOOK.COM>
References: <20220831074027.13849-1-justin.he@arm.com>
 <20220831074027.13849-4-justin.he@arm.com>
In-Reply-To: <20220831074027.13849-4-justin.he@arm.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?g1Ogi2jbOQsJV8ZmkVIGbA2I6MEqNCqgrTGs5L/xDMsJoa0L5rkvaZZSrd0l?=
 =?us-ascii?Q?5aUERWQNSrmUD0rNXgPDYDZ9y2iLRrrquyOTqxpc0XepRimVXuGbGzI5vkIT?=
 =?us-ascii?Q?hg8aCRLjRul0i0pYgKaLfMps3t2Qop/azxAf83dOGx8c1ZLFpmxr7qvXMkTU?=
 =?us-ascii?Q?uLlXefGEfzsdsV69UZLjGsCN5qnkh0A0zm2kxeJ1FIyggZw7TLcKCsGR1i8k?=
 =?us-ascii?Q?CN/aLA/hHaQ0qYJ7JaxyYB/bF7iDan+JjO9ObSlSSujXjLjiszEjqYHQIOQL?=
 =?us-ascii?Q?+5gA8mhxgoavelufl3Yj/qPqCD0neKxlgnxiBnPO+cehHNoQHGdn/hx6jbF+?=
 =?us-ascii?Q?CBxA2iWx8tRHTqZxK/OM20+KFzircWP7T4GYwyBzjGFldWaWWMLxBlxsSb8S?=
 =?us-ascii?Q?ValLFUcwyH8Bdo198vH0l2RkawHtKlI3kvp1+U/q1cnsFGSmUM75hvQeW3lG?=
 =?us-ascii?Q?apGu4w+403IBgC/ciqPnRC4oqvLghVzz+b/IO6pcAsVJ+46XSwgpU5mrKPEC?=
 =?us-ascii?Q?qp8Is9a1HxSk3cla0CpJ7eOG/kCZcNUba1YWzW0kmAoNkSWdlpIf/auSuoKK?=
 =?us-ascii?Q?kBDPfG51xhygeOoKLuTucFBXzpGRYIDCKuTAMTNNFnTcQaAhdlH74XDibz0Z?=
 =?us-ascii?Q?fvjOYm8zkOv/UF+FNA7QR+IsSA+TyVEITvB+dHrH7CwctMHdFKhbQ5OItV+t?=
 =?us-ascii?Q?Lsb/XatuTOXwu/Wr5Xf/A2bgB3Ct68XVqc9ZnCcJrnhbVXc+pP2UK9HjBOnq?=
 =?us-ascii?Q?JXNU59RRSWz7YzzDU8AiyCQ+Z9TJwB+mxTigbN3TuxOF2bBiRbXM23GumWmJ?=
 =?us-ascii?Q?HET7KQJ2a9vg0PzRbQ9rqqiJCZBfhDH0/023pwnBrtj0x35SPQVrIzK8cSro?=
 =?us-ascii?Q?UEUf4UjO+VUmcvI5klNMIWrnCiHX78cEZ8hniXh00125CPNNvYdRAPXdH7rT?=
 =?us-ascii?Q?J7j1fif3a8RXp0hnAswXHyUbOxjaHJFAqA58Sa+XZ15g6cReyJazHrVtpu2/?=
 =?us-ascii?Q?ik35ZigSKILbVSrA9uvYo3TpX1FhzhZo5NXp4vo9lXrIpc9awJQkpNUI+ISD?=
 =?us-ascii?Q?2tXd5zr6u2S05Tl0cfHt+Oj+v4rM5cBMiTrwY8OVEuo1Q/1Ks3p2ibmDhpjU?=
 =?us-ascii?Q?ifdg4h8UtL7md61X5bsCAVsGhJLm7W+C82HOgOLSp63Dqf8S1fV+jgIe3Avi?=
 =?us-ascii?Q?8OgfxBTthjH4fMBws1yKy2GVdCDRftIWr9Qsg1kGyqnMGujH7Th4fZ85iDrv?=
 =?us-ascii?Q?SAsh9hDmjfCAd8BP8XoTQpPcBSLvd9WZVbdDKIqTA8fMacAVj1eSxYRtb4to?=
 =?us-ascii?Q?2OMbJlUJ1WEx0yHBhR973zCUrtZtFs/BI6uHk0rMsiOidWK+6eveIIzfj6vE?=
 =?us-ascii?Q?OG/KWS5MN/rhI9W+DE8mKEtEXqnrQIzFi82f+JCKsXgfbcBN6i6pUkuJjp+N?=
 =?us-ascii?Q?bIPqGymT1HWh5wbbvmRw5YLV48szqGQa+UJjuvXH3VerNhhFONu8iHNizske?=
 =?us-ascii?Q?XwAb+D/2zUblGR1A05UGTFXfyiKAxR7jTXx8k8KvJ5xE/bbSJBUGR+Lul5k9?=
 =?us-ascii?Q?WAT58hdE4j6uTQeF0cnx6XpAJRkyjmKrCtNeXCHx?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM4PR84MB1853.NAMPRD84.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-Network-Message-Id: 1be3fd87-4936-47fa-46f3-08da8cf30775
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Sep 2022 14:54:25.5789
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: B9xxpD3U5rOVEgZ92NHsxFHXzCuo2KPnrdYG/fOD9LIs1elYjERgudThA4K/34Z+D+CTOFon7tgKAWR4bkHJYQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR84MB1421
X-OriginatorOrg: hpe.com
X-Proofpoint-GUID: UE_LTAsqhruwRMXkHPjt3rUYSjCrI89s
X-Proofpoint-ORIG-GUID: UE_LTAsqhruwRMXkHPjt3rUYSjCrI89s
X-HPE-SCL: -1
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-09-02_02,2022-08-31_03,2022-06-22_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=787 spamscore=0
 lowpriorityscore=0 priorityscore=1501 impostorscore=0 adultscore=0
 malwarescore=0 suspectscore=0 mlxscore=0 phishscore=0 clxscore=1015
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2207270000 definitions=main-2209020072
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wednesday, August 31, 2022 1:40 AM, Jia He wrote:
> +/*
> + * "ghes.edac_force_load" forcibly loads ghes_edac and skips the platfor=
m
> + * check.
> + */
> +bool ghes_edac_force_load;
> +module_param_named(edac_force_load, ghes_edac_force_load, bool, 0);
> +EXPORT_SYMBOL(ghes_edac_force_load);

Since ghes has no ability to load ghes_edac module, I suggest changing
the option name to ghes.edac_force_enable or ghes.edac_enable.

Toshi