Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220823145649.3118479-4-robh@kernel.org> <13083804.uLZWGnKmhe@kista>
In-Reply-To: <13083804.uLZWGnKmhe@kista>
From:   Rob Herring <robh@kernel.org>
Date:   Fri, 2 Sep 2022 09:51:07 -0500
Message-ID: <CAL_JsqJTgrSZcKNr1ky5LAXRQbj3MADMpCCYVC26rcZvzwY1Xw@mail.gmail.com>
Subject: Re: [PATCH] dt-bindings: mfd: Add missing (unevaluated|additional)Properties
 on child nodes
To:     =?UTF-8?Q?Jernej_=C5=A0krabec?= <jernej.skrabec@gmail.com>
Cc:     Lee Jones <lee@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Chen-Yu Tsai <wens@csie.org>,
        Samuel Holland <samuel@sholland.org>,
        Charles Keepax <ckeepax@opensource.cirrus.com>,
        Richard Fitzgerald <rf@opensource.cirrus.com>,
        Tim Harvey <tharvey@gateworks.com>,
        Robert Jones <rjones@gateworks.com>,
        Chanwoo Choi <cw00.choi@samsung.com>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
        Heiko Stuebner <heiko@sntech.de>,
        Fabrice Gasnier <fabrice.gasnier@foss.st.com>,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        Alexandre Torgue <alexandre.torgue@foss.st.com>,
        Maxime Ripard <mripard@kernel.org>,
        - <patches@opensource.cirrus.com>,
        Steve Twiss <stwiss.opensource@diasemi.com>,
        Chris Zhong <zyw@rock-chips.com>,
        Zhang Qing <zhangqing@rock-chips.com>,
        Alistair Francis <alistair@alistair23.me>,
        Amelie Delaunay <amelie.delaunay@foss.st.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Renner Berthing <kernel@esmil.dk>,
        Krzysztof Kozlowski <krzk@kernel.org>,
        devicetree@vger.kernel.org,
        linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
        linux-sunxi@lists.linux.dev,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "open list:ARM/Rockchip SoC..." <linux-rockchip@lists.infradead.org>,
        "moderated list:ARM/STM32 ARCHITECTURE" 
        <linux-stm32@st-md-mailman.stormreply.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, Aug 25, 2022 at 3:49 PM Jernej =C5=A0krabec <jernej.skrabec@gmail.c=
om> wrote:
>
> Dne torek, 23. avgust 2022 ob 16:56:35 CEST je Rob Herring napisal(a):
> > In order to ensure only documented properties are present, node schemas
> > must have unevaluatedProperties or additionalProperties set to false
> > (typically).
> >
> > Signed-off-by: Rob Herring <robh@kernel.org>
> > ---
> >  .../mfd/allwinner,sun6i-a31-prcm.yaml         | 40 +++++++++++++++++++
> >  .../mfd/allwinner,sun8i-a23-prcm.yaml         | 10 +++++
> >  .../bindings/mfd/cirrus,lochnagar.yaml        |  5 +++
> >  .../devicetree/bindings/mfd/dlg,da9063.yaml   |  7 ++--
> >  .../bindings/mfd/gateworks-gsc.yaml           |  5 ++-
> >  .../bindings/mfd/maxim,max14577.yaml          |  1 +
> >  .../bindings/mfd/maxim,max77843.yaml          |  1 +
> >  .../bindings/mfd/rockchip,rk817.yaml          |  2 +
> >  .../bindings/mfd/silergy,sy7636a.yaml         |  1 +
> >  .../bindings/mfd/st,stm32-lptimer.yaml        |  4 ++
> >  .../bindings/mfd/st,stm32-timers.yaml         |  3 ++
> >  .../devicetree/bindings/mfd/st,stmfx.yaml     |  1 +
> >  .../bindings/mfd/stericsson,ab8500.yaml       | 22 ++++++++++
> >  .../devicetree/bindings/mfd/ti,tps65086.yaml  |  1 +
> >  .../bindings/mfd/x-powers,axp152.yaml         |  1 +
> >  15 files changed, 100 insertions(+), 4 deletions(-)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/mfd/allwinner,sun6i-a31-prcm.yaml
> > b/Documentation/devicetree/bindings/mfd/allwinner,sun6i-a31-prcm.yaml i=
ndex
> > d131759ccaf3..021d33cb3dd6 100644
> > --- a/Documentation/devicetree/bindings/mfd/allwinner,sun6i-a31-prcm.ya=
ml
> > +++ b/Documentation/devicetree/bindings/mfd/allwinner,sun6i-a31-prcm.ya=
ml
> > @@ -22,6 +22,7 @@ properties:
> >  patternProperties:
> >    "^.*_(clk|rst)$":
> >      type: object
> > +    unevaluatedProperties: false
> >
> >      properties:
> >        compatible:
> > @@ -34,6 +35,45 @@ patternProperties:
> >            - fixed-factor-clock
> >
> >      allOf:
> > +      - if:
> > +          properties:
> > +            compatible:
> > +              contains:
> > +                const: fixed-factor-clock
> > +
> > +        then:
> > +          $ref: /schemas/clock/fixed-factor-clock.yaml#
> > +
> > +      - if:
> > +          properties:
> > +            compatible:
> > +              contains:
> > +                const: allwinner,sun4i-a10-mod0-clk
> > +
> > +        then:
> > +          properties:
> > +            "#clock-cells":
> > +              const: 0
> > +
> > +            # Already checked in the main schema
> > +            compatible: true
> > +
> > +            clocks:
> > +              maxItems: 2
>
> Last time node with allwinner,sun4i-a10-mod0-clk compatible was used, it =
had 3
> clocks. See:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/a=
rch/
> arm/boot/dts/sun4i-a10.dtsi?id=3Df18698e1c66338b902de386e4ad97b8b1b9d999d=
#n406

Humm, we already have constraints in
bindings/clock/allwinner,sun4i-a10-mod0-clk.yaml. I'll just make it
'clocks: true' here instead.

Rob