Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Kani, Toshi" <toshi.kani@hpe.com>
To:     Jia He <justin.he@arm.com>, Len Brown <lenb@kernel.org>,
        James Morse <james.morse@arm.com>,
        Tony Luck <tony.luck@intel.com>,
        Borislav Petkov <bp@alien8.de>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Robert Richter <rric@kernel.org>,
        Robert Moore <robert.moore@intel.com>,
        Qiuxu Zhuo <qiuxu.zhuo@intel.com>,
        Yazen Ghannam <yazen.ghannam@amd.com>,
        Jan Luebbe <jlu@pengutronix.de>,
        Khuong Dinh <khuong@os.amperecomputing.com>
CC:     Ard Biesheuvel <ardb@kernel.org>,
        "linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
        "devel@acpica.org" <devel@acpica.org>,
        "Rafael J . Wysocki" <rafael@kernel.org>,
        Shuai Xue <xueshuai@linux.alibaba.com>,
        Jarkko Sakkinen <jarkko@kernel.org>,
        "linux-efi@vger.kernel.org" <linux-efi@vger.kernel.org>,
        "nd@arm.com" <nd@arm.com>
Subject: RE: [PATCH v4 4/8] ghes: Introduce a helper ghes_edac_preferred()
Thread-Topic: [PATCH v4 4/8] ghes: Introduce a helper ghes_edac_preferred()
Thread-Index: AQHYvQ0fYOUHlI6mjUq1nFSoDPM5TK3MQ3pg
Date:   Fri, 2 Sep 2022 15:30:58 +0000
Message-ID: <DM4PR84MB185370AC62413398C1E32003827A9@DM4PR84MB1853.NAMPRD84.PROD.OUTLOOK.COM>
References: <20220831074027.13849-1-justin.he@arm.com>
 <20220831074027.13849-5-justin.he@arm.com>
In-Reply-To: <20220831074027.13849-5-justin.he@arm.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?7UE7T9kvTTmOykixExBNwMcAzJ7EcxsJ/8O5wBYNbK4Z/T/1ofPfR77Om8w2?=
 =?us-ascii?Q?zySFfTP9Vw1sy6Hjo2TGuUYJCiCsqooVNovhnZrysN+HAKIOTXKMNB5wL8z5?=
 =?us-ascii?Q?3Ry3Nfx8bOMFoyMbLzYpFSy+kf/G/QB83IlGatgRzNhX3uZ/Crv52ykRKl4Z?=
 =?us-ascii?Q?YDBkH+O5QF9Vvom/wL16C8wlWQy+WaWX7HXUAQbtlZmS7tw4Jq5DXFpN4fsw?=
 =?us-ascii?Q?qcata3QY+VSO3ZLM8wp4Q3Z3Afkt/J1eKnlt7nLkZ7OXWir/k46pN+DsybYR?=
 =?us-ascii?Q?4VLZfS/ZFWDNZ9cULS/APUm9U+h6jKlIDycxi2k5+c9qb0GjmcMZnCt62fMa?=
 =?us-ascii?Q?RwzoxJA8qP6P9TOc2vm7zvkcsQQ8X/EEX5EIOTSXZ1CNli302CYfs1dEPVWO?=
 =?us-ascii?Q?xBQWM45yWnAJPaYZvQX4DCEnXsnumqsx8oNvIPb7HOutpbHRteA5DXB0DcT8?=
 =?us-ascii?Q?9+Xz/dw8F+is6MXpLU0ivaGyWEDx8NSuhwOUSSRR8bmSUN7Lc1SLvvg2GrUK?=
 =?us-ascii?Q?SbzTg4qwbb6l0xs88xyoldtTo9QaRjHIV6KFpEIrqD7iP/NkyVNXXD7JP1Bu?=
 =?us-ascii?Q?C/G2024nkwvT4HCPe3csRrSud7acPVoiejj/hWCnDXEa+20dcRDnqQt+vSHS?=
 =?us-ascii?Q?GnHUTvrs2Pt5THUQAHmGc8lEjDFX5wreko1bvgGHVgae+yNGmwQB/WFxjCRr?=
 =?us-ascii?Q?kX6vSNPkJYYKukQoRCB7zUlWoz1Go8jj1JxvNTcJPtVWtlArixTsKFEemDXf?=
 =?us-ascii?Q?WEelUKn8KLGaJQa734VdlTqwG0RGr4/P+OjT6jaFmh2aHm27hbzooCdQ4V8n?=
 =?us-ascii?Q?JXpia33OrhSt4Dd1+KFBG0K1XMJdBbIHnbJqMYdWBjuASMFDw6sgFU50KUFR?=
 =?us-ascii?Q?tlsr326uU39pFl82wWgMUfzPZHTUr8jfBTDbW8wBlwMgwlj/jvf2UfIdQspE?=
 =?us-ascii?Q?8g75J0iCarB5rfppTiZJQX4zliOzHf2J3mnl0PZgx1T8ckg5ytLnrbnClVhX?=
 =?us-ascii?Q?BVnmzcpjcqQmHi9BPjKUS/os/iDM0ZMLrb6dOTmGyxQtgMtcxWhO5WtPWeH3?=
 =?us-ascii?Q?FtAhPP/35iZAC8U+PM/VggBJDtJiYgOtirzMmJCKfDaOKkUP1Vqtwt0ywkuF?=
 =?us-ascii?Q?hnLh9DxbeJWKHZDCOrt/OvPzqppFn3vt4TrtQmAbTxtDRicBN3ZPWyARh0ta?=
 =?us-ascii?Q?mnz2TWXeIg1ToFWNOVrfOwczPY+yNiQen3TwN1XQPYKM5OxC4CaeyrMRzUX2?=
 =?us-ascii?Q?722FxuWQugOd7iNs8XfuSALf/ICR0DVGx/ezRhCWFZih/J0v/EIGBAbZs0Jx?=
 =?us-ascii?Q?uaGx/+2xY6cPDAzxOPEn29HZqjP/RLv51XaL4fEfKbjPzlh98EOECUOMW8dg?=
 =?us-ascii?Q?XztYm2lSYAncoSQ61VBnwOs3ABO2tw4t0lIDxpi3zAVuoRJuCZfJoQgTA38j?=
 =?us-ascii?Q?i788QCRUu29NgJjezHMLXwjchPDqYiDd5jlIP7iUfplcW2gu6rRvqlhvkvRT?=
 =?us-ascii?Q?paKyP8iC+4+pr3P/fy4qckdF0+JHFs+DABRsCjbk/ahvQgm6li1E0EQrNSRC?=
 =?us-ascii?Q?k3sFH/eNdjMOlJib5s2OLaDO+SxFfu5inlw+w/7A?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM4PR84MB1853.NAMPRD84.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-Network-Message-Id: c73bf6af-6d08-4de6-ccc0-08da8cf82260
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Sep 2022 15:30:58.2581
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: bQFqcvUATds56yZpCUbOIYM2MMFEPbO7KGN8MnJa4XCzqpHm4CuKEDMSRwzIBEN41x7cjHfb+fk1MDd0uD3LnA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR84MB1713
X-OriginatorOrg: hpe.com
X-Proofpoint-GUID: lsK3Z5uLMknGFZVrECqFt4cKbV2s1P_9
X-Proofpoint-ORIG-GUID: lsK3Z5uLMknGFZVrECqFt4cKbV2s1P_9
X-HPE-SCL: -1
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-09-02_02,2022-08-31_03,2022-06-22_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 bulkscore=0
 impostorscore=0 mlxscore=0 phishscore=0 lowpriorityscore=0 malwarescore=0
 priorityscore=1501 suspectscore=0 spamscore=0 mlxlogscore=646 adultscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2207270000
 definitions=main-2209020075
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On Wednesday, August 31, 2022 1:40 AM, Jia He wrote:
> Introduce a flag ghes_present to differentiate between the system ROM
> really not offering GHES vs. the ghes module not running. ghes-present
> is latched on ghes_probe() and never unlatched since ACPI GHES table
> is static.
>=20
> Introduce a helper ghes_edac_preferred() and it is true if the
> platform-check passes.

I'd suggest to rephase a bit, something like:
=3D=3D
Introduce a helper ghes_edac_preferred(), which returns true when
ACPI GHES table is present and the platform-check passes on the system.
ghes_present is set once in ghes_probe() since ACPI GHES table is static.
=3D=3D

Otherwise, the patch looks good to me. =20
Reviewed-by: Toshi Kani <toshi.kani@hpe.com>

Toshi