Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 2 Sep 2022 16:12:58 +0100
From:   Matthew Wilcox <willy@infradead.org>
To:     Yury Norov <yury.norov@gmail.com>
Cc:     linux-kernel@vger.kernel.org,
        Andrew Morton <akpm@linux-foundation.org>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        David Howells <dhowells@redhat.com>,
        Ingo Molnar <mingo@kernel.org>,
        Geert Uytterhoeven <geert@linux-m68k.org>,
        Jonathan Corbet <corbet@lwn.net>,
        "Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
        NeilBrown <neilb@suse.de>,
        Rasmus Villemoes <linux@rasmusvillemoes.dk>,
        Russell King <linux@armlinux.org.uk>,
        Vlastimil Babka <vbabka@suse.cz>,
        William Kucharski <william.kucharski@oracle.com>,
        linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-mm@kvack.org
Subject: Re: [PATCH 08/10] headers/deps: mm: Split <linux/gfp_types.h> out of
 <linux/gfp.h>
Message-ID: <YxIdeiL0iOsN3zv8@casper.infradead.org>
References: <20220706174253.4175492-1-yury.norov@gmail.com>
 <20220706174253.4175492-9-yury.norov@gmail.com>
 <YxEZYUCA0b8Cd1/S@casper.infradead.org>
 <YxFmAcrDkFuIsuOu@yury-laptop>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YxFmAcrDkFuIsuOu@yury-laptop>
Precedence: bulk

On Thu, Sep 01, 2022 at 07:10:09PM -0700, Yury Norov wrote:
> On Thu, Sep 01, 2022 at 09:43:13PM +0100, Matthew Wilcox wrote:
> > On Wed, Jul 06, 2022 at 10:42:51AM -0700, Yury Norov wrote:
> > > From: Ingo Molnar <mingo@kernel.org>
> > > 
> > > This is a much smaller header.
> > > 
> > > Signed-off-by: Ingo Molnar <mingo@kernel.org>
> > > Signed-off-by: Yury Norov <yury.norov@gmail.com>
> > > ---
> > >  include/linux/gfp.h       | 345 +------------------------------------
> > >  include/linux/gfp_types.h | 348 ++++++++++++++++++++++++++++++++++++++
> > >  2 files changed, 350 insertions(+), 343 deletions(-)
> > 
> > You move a lot of kernel-doc.  Where do you change the rst files?
> 
> Ingo - nowhere. So I did it in the next patch:
> 
> 7343f2b0db4961d ("headers/deps: mm: align MANITAINERS and Docs with new
> gfp.h structure")

That's not the right way to do it.  Don't merge a patch with bugs and
then fix it up in the next patch.  Just fix the patch.  This is covered
in Documentation/process/.