Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <4ca8b7c8-0b67-d3a0-73c9-a2c4974cdcac@arm.com>
Date:   Fri, 2 Sep 2022 16:47:58 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:91.0) Gecko/20100101
 Thunderbird/91.10.0
Subject: Re: [PATCH v5 00/21] x86/resctrl: Make resctrl_arch_rmid_read()
 return values in bytes
Content-Language: en-GB
To:     Reinette Chatre <reinette.chatre@intel.com>, x86@kernel.org,
        linux-kernel@vger.kernel.org
Cc:     Fenghua Yu <fenghua.yu@intel.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        H Peter Anvin <hpa@zytor.com>,
        Babu Moger <Babu.Moger@amd.com>,
        shameerali.kolothum.thodi@huawei.com,
        D Scott Phillips OS <scott@os.amperecomputing.com>,
        lcherian@marvell.com, bobo.shaobowang@huawei.com,
        tan.shaopeng@fujitsu.com, Jamie Iles <quic_jiles@quicinc.com>,
        Cristian Marussi <cristian.marussi@arm.com>,
        Xin Hao <xhao@linux.alibaba.com>, xingxin.hx@openanolis.org,
        baolin.wang@linux.alibaba.com
References: <20220622164629.20795-1-james.morse@arm.com>
 <d8f0224a-6cb4-eeb4-59cc-39d6ce4fba5a@intel.com>
From:   James Morse <james.morse@arm.com>
In-Reply-To: <d8f0224a-6cb4-eeb4-59cc-39d6ce4fba5a@intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Reinette,

On 23/08/2022 18:20, Reinette Chatre wrote:
> On 6/22/2022 9:46 AM, James Morse wrote:
>> The aim of this series is to insert a split between the parts of the monitor
>> code that the architecture must implement, and those that are part of the
>> resctrl filesystem. The eventual aim is to move all filesystem parts out
>> to live in /fs/resctrl, so that resctrl can be wired up for MPAM.
>>
>> What's MPAM? See the cover letter of a previous series. [1]
>>
>> The series adds domain online/offline callbacks to allow the filesystem to
>> manage some of its structures itself, then moves all the 'mba_sc' behaviour
>> to be part of the filesystem.
>> This means another architecture doesn't need to provide an mbps_val array.
>> As its all software, the resctrl filesystem should be able to do this without
>> any help from the architecture code.
>>
>> Finally __rmid_read() is refactored to be the API call that the architecture
>> provides to read a counter value. All the hardware specific overflow detection,
>> scaling and value correction should occur behind this helper.
>>
> 
> Thank you for your patience as I was offline for a while. 

No problem,


> This series looks good to me. I have one remaining comment that I provided
> in reply to "[07/21] x86/resctrl: Abstract and use supports_mba_mbps()" where
> it seems to me that an existing issue could easily be addressed in the new
> function. 

Yup, that made sense to me.


> I do not have tests for the software controller and only did basic sanity
> checks. It would be great if the folks using this feature could test this
> series.
> 
> Thank you very much. From my side it looks good:
> 
> Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>


Thanks!

James