Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b418161b-2613-4bb9-9269-b4995de65794@intel.com>
Date:   Fri, 2 Sep 2022 09:08:23 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.2.0
Subject: Re: [PATCH v2 2/6] x86/sgx: Do not consider unsanitized pages an
 error
Content-Language: en-US
To:     Jarkko Sakkinen <jarkko@kernel.org>
CC:     <linux-sgx@vger.kernel.org>,
        Haitao Huang <haitao.huang@linux.intel.com>,
        Vijay Dhanraj <vijay.dhanraj@intel.com>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Paul Menzel <pmenzel@molgen.mpg.de>, <stable@vger.kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" <x86@kernel.org>,
        "H. Peter Anvin" <hpa@zytor.com>,
        "open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)" 
        <linux-kernel@vger.kernel.org>
References: <20220831173829.126661-1-jarkko@kernel.org>
 <20220831173829.126661-3-jarkko@kernel.org>
 <24906e57-461f-6c94-9e78-0d8507df01bb@intel.com>
 <YxEp8Ji+ukLBoNE+@kernel.org>
 <84b8eb06-7b77-675f-5bc8-292fe27dd2f5@intel.com>
 <YxFGykqMb+TD4L4l@kernel.org> <YxIEm4uHVvUY/rv6@kernel.org>
 <YxInD1m7rEnQ/yxW@kernel.org>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <YxInD1m7rEnQ/yxW@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aXdaanVRbnFVMmdNMTJ1QXE5K0FtR25kb0F4Mm1OaFFDVm91STU5KzZ3K0s5?=
 =?utf-8?B?dXJTQXgzcWNFMDFVcEpvQmxyeVhLV2Fva28zSVh4Z0FqbzRJNit6Yy9LVDhk?=
 =?utf-8?B?WmpydVA4VjQxZ29HVEZkTWY3eURFaTV4OTAvcXdtMisvM25LbzdFWXJSZ2ha?=
 =?utf-8?B?YW4rY1A4MGpsZ2VIS1daTldWTzFlZEo5N0IvbFF4Ny9CMGxaWDF4WVN4TjIy?=
 =?utf-8?B?akc1eDRrdENIb0Nsajl6RUJUbkhmd3JFNVhPR1FJZU5PSGJwdStPNU9BSVYw?=
 =?utf-8?B?Y3hLR2c1YVhiYTFrdDZnYWFTRjNIMXVQMng5M0oycCtBV1NxVGlkMlp1eUR6?=
 =?utf-8?B?cWsxa1E5aG5pbmNLT1RYRmJMQ09iVGN5dWJpblpPSGh6alF1L28wVXJKdmdq?=
 =?utf-8?B?a2p5ZlZSM0xoOENkNTlTc1JSTnlDOC9FUGl1czZtdW9oTmxnVVZuTit3RWVl?=
 =?utf-8?B?SG9ORmN4SlpZTFd1MlFad0ZKdS96MjR6WkRQd3N2VG00V091aVY2b0V3WGlG?=
 =?utf-8?B?aGZuNEpaVmJNSDh0dkNYbGlhSzRNa3YvMjlMUVFXbWNSNHVkT1plMER2WGZm?=
 =?utf-8?B?Y2paR3dWaHMwa3crU25ZUWwvS0huOVJnQ1RhUlptNTUzMmw0T1VnRkVSUXly?=
 =?utf-8?B?TWtTQ2lSM1AwanFGTzl4K3M2TGVhNk96Umg1UTJhdjIxVkVOTVNqQ1VLZkc0?=
 =?utf-8?B?YzByOXpVZE5ERlM3UzRWM0ZsYXV1bGVGbVh4dTJ3N2k4eTc1QVZDcmFBaGRm?=
 =?utf-8?B?Q0pJcGh5ZHd2T29Bd3dZdTM5K0FmSUIrWUx4VGNjNjAwZXFocXNHTE5icGFS?=
 =?utf-8?B?UTRiRVMrUFdUUjBSWjJiZTdQL0RtTlIvdXJnMmtqUHhzQXdVTkRmbGwwVDM0?=
 =?utf-8?B?czFKNmhqbW14Wk9IcnpmTmR4ZzFVT0VudWlTOHZWNHplY0RUR245ZHJnbVpI?=
 =?utf-8?B?Skh1dVZFZnpnQkhFKytGeXRXSUNjNUhiM2thVE1WV1ZQNFN5Q0FaNmNiOVdv?=
 =?utf-8?B?bXp0TGtvbnRvcGkxYU1XQTB0Q1BlcXhtVnVTM3BEbS9uODBtYmhGUnArWktV?=
 =?utf-8?B?VTAwYVF1aTN1WFJZREZHclpnQWg1eXlDR2xMV0ZiNnhZZkhUczl3b1dNdjVl?=
 =?utf-8?B?alVBbjI2VWgxc0hmUzQ2Y3NlZjVXQjZOU3FQSklkeWhSeVZDR1FBSEZmVDBj?=
 =?utf-8?B?SmNiYVFSdGVzRTl0UDlhRk1jeGtYWkJXbiswNTkrUHJhK2U4ajVSemk3SFBl?=
 =?utf-8?B?OWVEKzVOQ3N5VmJGN0paTHJhMFRva0R3RkFoaWVMUjNKUXhCRHFNcm16Skhu?=
 =?utf-8?B?ZHVkR2dZYTQ4T2VlUWFpUXVjUktnMWpMQmhlR1hDZWhwR2hjNWlTcHZwN053?=
 =?utf-8?B?Y0h5U1hFdE5TSGFuVEYvaUVXTTYzeEkrL2dkTFdaejM3dXF4b0d3YURVVkpV?=
 =?utf-8?B?L28wZGg3d3l3bW82cmpGRVZhNTJyWXlZbGV3VGNPWi9YbjlNTG5CeHpkdUVJ?=
 =?utf-8?B?R2N4R0lmclVmOGh0amE2RXFsbVJRVTg0NnJYYXFyaGVyQkNlTTQyUE9JTGJV?=
 =?utf-8?B?dTJMN01URzk0SjJuanZOaStwemtNQ0FpekNySjNTd2VhbXdLa3hSWGpqMGp0?=
 =?utf-8?B?UEJtTWFoYTl6bEg0RFpKeUZMU0pmWnRoZEdWU2hLTmZNSFN1WDRzN0F4V1hx?=
 =?utf-8?B?czJRMysyOUNsNWRPYThxY0JMQ1hwNlZhdnpFQ1ZwdGc3MXdVUUFoczJCN2x2?=
 =?utf-8?B?bVQvaHR5YnBSZUVYNmtlWlVSR2hVa2JRL2Z3Sm1SclVaeFptYXVXWEwzQ3p1?=
 =?utf-8?B?TlYwaWlrOUF0blBWOWFpNHlYYWFRTUlPS0sya2VBMmM0MFM1VVZ5eFFmZnBs?=
 =?utf-8?B?SWxJVTFHQ1ZxUWQwdEcxeFR5eWxnQ1pNdjk5MXhDQUxnYllBcjZ6RU5SbXFW?=
 =?utf-8?B?TXZRWEg0NS8yM0YzM2MwQy8yN0MwSm9qaXZ4OXFqL2dLZkNKemh6Y0lRZm9U?=
 =?utf-8?B?dllkZlFzNlZIWTdBc2dvdGRheGRyS3B2MTRHdEtXRk54dEE3czRocHEvWTV0?=
 =?utf-8?B?YXk0RzJNSFIwOGZYM1Q4ZEdIU0ZST3JPdE0wWi9RR1VJQjJya21WMkVLSkxU?=
 =?utf-8?B?R3RLZ2VYejlMeEtlQmVTNTZqbkpDYUk1WUNUb0hJTE5wRW15MkxsWmhLdWs5?=
 =?utf-8?B?bXc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 41c999a6-0275-4985-6a53-08da8cfd5e23
X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1862.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Sep 2022 16:08:26.2371
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: z7rhXuRqbPaWA77gcX7a0acFkfLax7KrzgT1Nfh54dpF3JJQ2vyimY1BA40Q33fC+EZIY4KgwLaNixm4gaFdAbcEw3511UbJwj+sxFZYYwY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1935
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Jarkko,

On 9/2/2022 8:53 AM, Jarkko Sakkinen wrote:
> On Fri, Sep 02, 2022 at 04:26:51PM +0300, Jarkko Sakkinen wrote:
>> +	if (ret)
>> +		pr_err("%ld unsanitized pages\n", left_dirty);
> 
> Yeah, I know, should be 'left_dirty'. I just quickly drafted
> the patch for the email.
> 

No problem - you did mention that it was an informal patch.

(btw ... also watch out for the long local parameter returned
as an unsigned long and the signed vs unsigned printing
format string.) I also continue to recommend that you trim
that backtrace ... this patch is heading to x86 area where
this is required.

Reinette