Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Kani, Toshi" <toshi.kani@hpe.com>
To:     Jia He <justin.he@arm.com>, Len Brown <lenb@kernel.org>,
        James Morse <james.morse@arm.com>,
        Tony Luck <tony.luck@intel.com>,
        Borislav Petkov <bp@alien8.de>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Robert Richter <rric@kernel.org>,
        Robert Moore <robert.moore@intel.com>,
        Qiuxu Zhuo <qiuxu.zhuo@intel.com>,
        Yazen Ghannam <yazen.ghannam@amd.com>,
        Jan Luebbe <jlu@pengutronix.de>,
        Khuong Dinh <khuong@os.amperecomputing.com>
CC:     Ard Biesheuvel <ardb@kernel.org>,
        "linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
        "devel@acpica.org" <devel@acpica.org>,
        "Rafael J . Wysocki" <rafael@kernel.org>,
        Shuai Xue <xueshuai@linux.alibaba.com>,
        Jarkko Sakkinen <jarkko@kernel.org>,
        "linux-efi@vger.kernel.org" <linux-efi@vger.kernel.org>,
        "nd@arm.com" <nd@arm.com>
Subject: RE: [PATCH v4 5/8] EDAC/ghes: Make ghes_edac a proper module to
 remove the dependency on ghes
Thread-Topic: [PATCH v4 5/8] EDAC/ghes: Make ghes_edac a proper module to
 remove the dependency on ghes
Thread-Index: AQHYvQ0gLFRG5y0niUeXpc2U7DO/1a3MXSXw
Date:   Fri, 2 Sep 2022 17:13:23 +0000
Message-ID: <DM4PR84MB1853F07391E61292D4119F21827A9@DM4PR84MB1853.NAMPRD84.PROD.OUTLOOK.COM>
References: <20220831074027.13849-1-justin.he@arm.com>
 <20220831074027.13849-6-justin.he@arm.com>
In-Reply-To: <20220831074027.13849-6-justin.he@arm.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?B8SY2ttwJtBTPHqzI7eYfwK7eCHy+RHvnP+IE318QpwOZala/dqggLOLxV2S?=
 =?us-ascii?Q?w6XbftFk0aaofJof0QcK0xGOSSR1hgkY872F7bO6AXP+8DcMw8khvQjUIU0y?=
 =?us-ascii?Q?OE8fdXlFbhdWDg3tA/Jfs4HSOIwdF8sQ4Rsk0QYBHYc9/guB8p528tF0SQHY?=
 =?us-ascii?Q?2lgRf7Oqvu7JsJd9sskncHfOyclrT901kwUk9CNxul7TIT5hFthGPm8i+LeL?=
 =?us-ascii?Q?Iil3SGI6Ir0aMLk0vzVLxQTACl1XkzxaQkaKbdAsE9u4GLlN8uyWONMrzcNY?=
 =?us-ascii?Q?WP6MB1gokxbkcnL6siLAbTp1CIK1GRyJSGIMsePWF/DgGTL3H3EAUNI6yZH+?=
 =?us-ascii?Q?wi1eBBsro8FdEsGAuhsN0PusuK2ZlGnsCc7gbnaaP8q6r2jkAsWpIhGAt5Mi?=
 =?us-ascii?Q?rhbHFQ8NVxD8lEla+G/D6/4oFWfOZTPXuhxEvqE4YSL4A8QEIzUDyF6tL3EM?=
 =?us-ascii?Q?lHXvLAVkrDim1PuuD1KDjkHs28YGcKL9MrBRYQGaM5YBlzBVzGdPPwPx/Oeb?=
 =?us-ascii?Q?Z8Zjbl8qfHPgw6guKjBCE9Z2/aCBZfs5wv2cCFj/W+mWWfuzI8DMtNVI6bPb?=
 =?us-ascii?Q?3GskLKFBjqYPqCqXmDEhoIpE2pQLI21cm2Tb9iqFbxNyaN32Jc4zeTHkht07?=
 =?us-ascii?Q?qWmDXYJrO/rSIeogHSHu94+ew/jp+mQd/qYA6OwzIe+YG1oOYdfZsd0kOX/9?=
 =?us-ascii?Q?24ji8wiW4iZ9wyQNbS0s1UewL1EZi3iokbi4PAaf8DPi9FwMG1+j1X3f9iD4?=
 =?us-ascii?Q?KaXIykHTqD4b66JN/ICI5VOa/RKrjQK6BXih3LVuuyn0gLxvVgJdorrBAslY?=
 =?us-ascii?Q?qhJAS/2aZsjutrKUr90KqrQKK3LbmqedPBexu0L0GnjNF47fsPuWxMYWgKgC?=
 =?us-ascii?Q?yMKzbILvl9Z2A5Srmn8aczT0spqafH7z2TqdF410gqxylMTlOiuNgssvcTYe?=
 =?us-ascii?Q?vA5Ph+oIoOHtfC5HgfQX7CsaIZ/GfFCigJsgdk4fphc+N+agk8fd5HEJSqqD?=
 =?us-ascii?Q?6xOE4UqhY7lIZTZD/SQrBIjQ50iRLvbaB/+MqrEhQ6ZY45QVgXkkm6fxYOOo?=
 =?us-ascii?Q?trhPFF/fmoo6ExNWd/G4zeImMn/c5lrb2zNoknhDczw5ikr5KNTyNE2g6hjx?=
 =?us-ascii?Q?jF0VHA0dnwuxKi2RIz7OdtGKd2YG9LRslPr9SCGVVXdRsNMe2hCrANBEFMLN?=
 =?us-ascii?Q?GftrDm4g5oENJvIwquZqDGEKHFa/u602N2SCszdN82Un4TV/8RjJ8mDwI0jX?=
 =?us-ascii?Q?/0VVdYaQ0wilZB0iJG1jVH6LItA1ppnNxNHP3smifWJCkW2EsY4C/fHkwhN/?=
 =?us-ascii?Q?9yDDXUWk3VLgcgL0ymt26wusjtCJ9wFBptTfn+aneP+yZcx+BrB6HLYeQKIu?=
 =?us-ascii?Q?HNVGqhXT29bgUxEEyatNH8WnKlar9sEoIs2inxKQLLcv6k+A4pf8Y7J0nebB?=
 =?us-ascii?Q?97WSR2OYhUbUeyLFR4BNpeZnjrHE/KwizYLayJKIg/EVNe/vTGAkG/GI2W9m?=
 =?us-ascii?Q?GFnuuYAtLINo54wHSWi92RIin5errHpls8HnU9jaXTW/Uehd0ViXMbrOe76K?=
 =?us-ascii?Q?2i9U7QmbLtdFz/4pKUf5aKwRRddKDWXi2DqpZL3U?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM4PR84MB1853.NAMPRD84.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-Network-Message-Id: b2871d11-3818-411c-875b-08da8d0670fc
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Sep 2022 17:13:23.0952
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: fSVTM5OPEKf92sTxjblRYf9yRc7VmDJ9WWZbDBC92rZzMhkxCHkA+qtWVRf0MTKYFpuv++xzUgHFZK9Y8wjpsA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR84MB1532
X-OriginatorOrg: hpe.com
X-Proofpoint-ORIG-GUID: OpVxz5tH87eEQxRaMHCyYmmW9bjJf_CB
X-Proofpoint-GUID: OpVxz5tH87eEQxRaMHCyYmmW9bjJf_CB
X-HPE-SCL: -1
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-09-02_04,2022-08-31_03,2022-06-22_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=792 bulkscore=0
 lowpriorityscore=0 spamscore=0 mlxscore=0 suspectscore=0 impostorscore=0
 priorityscore=1501 adultscore=0 phishscore=0 malwarescore=0 clxscore=1015
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2207270000
 definitions=main-2209020080
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wednesday, August 31, 2022 1:40 AM, Jia He wrote:
> @@ -454,7 +437,7 @@ int ghes_edac_register(struct ghes *ghes, struct
> device *dev)
>  		pr_info("This system has a very crappy BIOS: It doesn't even
> list the DIMMS.\n");
>  		pr_info("Its SMBIOS info is wrong. It is doubtful that the error
> report would\n");
>  		pr_info("work on such system. Use this driver with
> caution\n");
> -	} else if (idx < 0) {
> +	} else if (ghes_edac_force_load) {

This change causes the following messages to start showing up on Arm.
Is that what you intend to do?

The messages can be avoided by not setting the force flag on Arm unconditio=
nally.
This will need some change to the flag check in ghes_edac_unregister() thou=
gh.

>  		pr_info("This EDAC driver relies on BIOS to enumerate
> memory and get error reports.\n");
>  		pr_info("Unfortunately, not all BIOSes reflect the memory
> layout correctly.\n");
>  		pr_info("So, the end result of using this driver varies from
> vendor to vendor.\n");

 Toshi