Received: by 2002:a05:6358:bb9e:b0:b9:5105:a5b4 with SMTP id df30csp119773rwb; Fri, 2 Sep 2022 11:08:09 -0700 (PDT) X-Google-Smtp-Source: AA6agR4ldAbtJaEpgccG2I/c3sRwHYeeFiV2ZZepVWo7lhN3IDd6WJMcR+jYb4PO4v7Yc9eYi6KH X-Received: by 2002:a63:c59:0:b0:42b:c924:cde4 with SMTP id 25-20020a630c59000000b0042bc924cde4mr25350417pgm.279.1662142089290; Fri, 02 Sep 2022 11:08:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662142089; cv=none; d=google.com; s=arc-20160816; b=xX7nFwhMAKTGktkchRgXEDcFycA2bkIrlog9lEP1dx8wEVBsgzM/4sD/ssHE73k3na YzPOlMTyJDTYYonRqnSAQK50KqogLx/GyYr/IMmoqmw86WWgtbhD0W5SmAB5fvSpfb15 B2g64PU0itlabmXoJ6toAtLXmXQy6vs2vRgQbWWU9a837mplyqfQgFj5cUWv9ccWuegS x7HQtJrfbk16uQSeZS6qZvb+oo8KemQsQ1ijPeDTOq591f1x9pSRRa7RU9K49+QxsDSQ xl5iOg0QjYrUTBerqLklDI2FalnFSdhQp6xaPjU4l0iiYBrkGxc3H3ciSWvOxZq5nKCp zXpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=zzRDnvZLDVtVhIAO0xIjdD4CavEB3peMxY86RJvLKWw=; b=IssaOLyNd9ISxUzdBstCJoA7N7tk2mZY3X5D9s6U9tvYcgYvj/z4HmNGtqrvcYu48r EZ3+cb0ESWO36BwKxVdaWCSiIK+c2SQoXM41bpuRv/AqWwXwQnWaj14TfWxV2C31ZccM TNH/YNUMLqVMMX7oTd/e8g9rQRCDd0Z971/HvVq8KTrXv4rVfAhOvNpio2sRepKMi7u4 uaulYhuLYa1059PAa70+WMJAS8skiMc6Qi+jkSfExcGnB1sbGJr3Tm/BWYAZ9nD9YCIO U3ZGm+dVw+9kJrnAIGJWfPtgnyKn/qjHifjLV2zluVN5Pv6AFIdZY+9Hyiuf7VFG+2R0 GnBw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=bHWKYkw6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b1-20020a63e701000000b0042982674c81si2577258pgi.190.2022.09.02.11.07.57; Fri, 02 Sep 2022 11:08:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=bHWKYkw6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236202AbiIBRtf (ORCPT + 99 others); Fri, 2 Sep 2022 13:49:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60318 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235317AbiIBRte (ORCPT ); Fri, 2 Sep 2022 13:49:34 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6AA15F2C9D; Fri, 2 Sep 2022 10:49:33 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 06DCC62223; Fri, 2 Sep 2022 17:49:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CF0C4C433C1; Fri, 2 Sep 2022 17:49:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662140972; bh=GOSNtRWEY0DYm6BP44LdjM1cTRDgHCPLtmZEbPDLPik=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bHWKYkw6yIb+UI2eNRUngsCmD7q/Td5OnsfwFtyU+5Dh+lRM+vjZaow8hx8QdQE45 bJlMdvKZ/VQBvGu4i6Xl15rMSnEaOVUu7V9eok5eWrmd2WLHjCFtCuF65otHQQVSPy zwqXBRm53/JjTRuh973hFznlavubMlT2Q/O1RhAfmFfoB3szOMHGQcbiJCXzVE0Xzy WR9l2HaG6nuHzvxu2uYkozRRmhC37p73SDjhCzxR74qzPa35jW09A8EtjgPSr0UCII LQcm1vv7IX++7P65SlslniXwFJROMYUbPpyBAjEakTbO1nTsLeGteu/G0kEoevorqE WGw2e5f0lMz3g== Date: Fri, 2 Sep 2022 23:19:28 +0530 From: Vinod Koul To: Richard Zhu Cc: a.fatoum@pengutronix.de, l.stach@pengutronix.de, bhelgaas@google.com, lorenzo.pieralisi@arm.com, marcel.ziswiler@toradex.com, kishon@ti.com, linux-phy@lists.infradead.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de, linux-imx@nxp.com Subject: Re: [PATCH v2] phy: freescale: imx8m-pcie: Fix the wrong order of phy_init() and phy_power_on() Message-ID: References: <1661928956-12727-1-git-send-email-hongxing.zhu@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1661928956-12727-1-git-send-email-hongxing.zhu@nxp.com> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 31-08-22, 14:55, Richard Zhu wrote: > Refer to phy_core driver, phy_init() must be called before phy_power_on(). > Fix the wrong order of phy_init() and phy_power_on() here. > Squash the changes into one patch to avoid the possible bi-section hole. > > Fixes: 1aa97b002258 ("phy: freescale: pcie: Initialize the imx8 pcie standalone phy driver") > Signed-off-by: Richard Zhu > Tested-by: Alexander Stein > --- > drivers/pci/controller/dwc/pci-imx6.c | 6 +++--- > drivers/phy/freescale/phy-fsl-imx8m-pcie.c | 8 ++++---- Acked-By: Vinod Koul -- ~Vinod