Received: by 2002:a05:6358:bb9e:b0:b9:5105:a5b4 with SMTP id df30csp135097rwb; Fri, 2 Sep 2022 11:24:31 -0700 (PDT) X-Google-Smtp-Source: AA6agR5d0rleVULkVIwfYW+vlZCfV/Fd+OLOFzncXyt08EhZZ2xaa5dgDTlHmFaOu1w+Vdds+pj0 X-Received: by 2002:a17:902:f551:b0:16e:d000:543b with SMTP id h17-20020a170902f55100b0016ed000543bmr35442635plf.22.1662143071720; Fri, 02 Sep 2022 11:24:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662143071; cv=none; d=google.com; s=arc-20160816; b=znCCtkMLoy4K6rUyQ6WHIhNYLmQ5zpD8xu6Gv3AfbzHkltnsu4wqYJp8Ho4ddWFxvp dyW72wq5zPi5ycB0kF0L4p2zVtym2F2+qcVR01RWdsLtNHm5dx3BYUDzGJUK8SHWYZsu ysIGQUr71lgmKiEuQ/qrLtg9xB+OYYLRg7N5aEL8ZJVCX1573b+lDnyslQ1WKQaau4u3 DszRsJCHTBSjKOreIThKwOtmFPHc3cp0botKbvg+vA44UNmMksBjSSmxeaRro7lrSB9O OzNaWfUsPvVAzpCmfCERt48LeSDDdP/o1hSLYWbW8xHcbnynZbGX9aWMhokLd9YBfeJX qMnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=estHCjdCQ2KS41PO8QRbKUT1eyi4O7M584fi5Ra5cf4=; b=zhWqcsXjPjGTrTvtt1S+jrJ3b47YR/YS1ZZwqOJwtCySbzg9PslySd2XfUuzlahLLj c+foC1kURMBnTvJ3Kwj36Jn1p7YZcFoqDLUy35aWMWJhW4taeVd/JwxS97VIsKacMGGa WKuvstvUv2A3hLnHUOU5sK7wORh2bdojC3sFdxKRH97LSVGep1rVQYdevdvGjHTv7859 mhVEyYRdopQrYV6rHwPTlB2bODpk+dMrVC2El7utXGygUo26APGS2NOP/4sm2xJ30dbi 7YR0TtOOtoAc6wYUURM0Dw8te/NLulPs5N9As7ntFGK3ddR4Hqx2MBbj8Q1UixVlhDJW uwpA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d21-20020a637355000000b0041610ee2f17si2552808pgn.261.2022.09.02.11.24.16; Fri, 02 Sep 2022 11:24:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229640AbiIBSQO (ORCPT + 99 others); Fri, 2 Sep 2022 14:16:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49538 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229630AbiIBSQL (ORCPT ); Fri, 2 Sep 2022 14:16:11 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E3243E42D1; Fri, 2 Sep 2022 11:16:09 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 9998FB82D01; Fri, 2 Sep 2022 18:16:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 67757C433C1; Fri, 2 Sep 2022 18:16:04 +0000 (UTC) Date: Fri, 2 Sep 2022 19:16:00 +0100 From: Catalin Marinas To: Robin Murphy Cc: joro@8bytes.org, will@kernel.org, jean-philippe@linaro.org, inki.dae@samsung.com, sw0312.kim@samsung.com, kyungmin.park@samsung.com, tglx@linutronix.de, maz@kernel.org, alex.williamson@redhat.com, cohuck@redhat.com, iommu@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org Subject: Re: [PATCH 2/3] iommu/dma: Move public interfaces to linux/iommu.h Message-ID: References: <9cd99738f52094e6bed44bfee03fa4f288d20695.1660668998.git.robin.murphy@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9cd99738f52094e6bed44bfee03fa4f288d20695.1660668998.git.robin.murphy@arm.com> X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 16, 2022 at 06:28:04PM +0100, Robin Murphy wrote: > The iommu-dma layer is now mostly encapsulated by iommu_dma_ops, with > only a couple more public interfaces left pertaining to MSI integration. > Since these depend on the main IOMMU API header anyway, move their > declarations there, taking the opportunity to update the half-baked > comments to proper kerneldoc along the way. > > Signed-off-by: Robin Murphy > --- > > Note that iommu_setup_dma_ops() should also become internal in a future > phase of the great IOMMU API upheaval - for now as the last bit of true > arch code glue I consider it more "necessarily exposed" than "public". > > arch/arm64/mm/dma-mapping.c | 2 +- And here: Acked-by: Catalin Marinas