Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   <Jerry.Ray@microchip.com>
To:     <andrew@lunn.ch>
CC:     <vivien.didelot@gmail.com>, <f.fainelli@gmail.com>,
        <olteanv@gmail.com>, <davem@davemloft.net>, <edumazet@google.com>,
        <kuba@kernel.org>, <pabeni@redhat.com>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 2/2] net: dsa: LAN9303: Add basic support for LAN9354
Thread-Topic: [PATCH 2/2] net: dsa: LAN9303: Add basic support for LAN9354
Thread-Index: AQHYu9FcWcp1m2N/pU+7PwCEJwtzQq3GQSmAgAZZIHA=
Date:   Fri, 2 Sep 2022 20:18:32 +0000
Message-ID: <MWHPR11MB16938C27CC03D84BA2194DC3EF7A9@MWHPR11MB1693.namprd11.prod.outlook.com>
References: <20220829180037.31078-1-jerry.ray@microchip.com>
 <20220829180037.31078-2-jerry.ray@microchip.com> <Yw0RfRXGZKl+ZwOi@lunn.ch>
In-Reply-To: <Yw0RfRXGZKl+ZwOi@lunn.ch>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?97yvWNMhWZdNI7WozGNdsP5fqFAeeF1FbzNcHfWIEvQbHiiXXnShN/qjVFSt?=
 =?us-ascii?Q?cL92BTS3Z4O07tf00RHXdrcU0BJJIBsYJN9znSqiuoAlPZvymBhwC1lBRbOD?=
 =?us-ascii?Q?QY6hTmmYKVcX04cZPb1LIN4Tg2YgSGyRWHsXFMNgUzGo0zqVrRO8k0Tel9n3?=
 =?us-ascii?Q?FH1rykgBe5IbRDeeEMG99nAZa00uw4ELalWf0EOJw21qWGc2boCzxheWIbyt?=
 =?us-ascii?Q?7TeXzWMF4mSdvoEbjwyl56Uwy7bXtIEsX3mRWesFnel7UG6M6FhcR4jQUj17?=
 =?us-ascii?Q?TSubEH29NRGf8ZjbIm5YJik9YVWscXidP9dEyBOeMkdKQ8V8DZELhOfO5/n/?=
 =?us-ascii?Q?iiAU4dskzle+wJMr6k0KwB+sGk1chx1i62LrrtvaRoeI87BZkbINwyWl2aqD?=
 =?us-ascii?Q?B2w/Vsme4g93jRJioWqea97vPZi4LVP8UE6X414CvlpDwU1anRZc7qrDCd78?=
 =?us-ascii?Q?qsaKWx8w9tBHGAlT0TzDcU8gEWwz3Y1QjaWWABFM2YfWskIE94naNyIamsCk?=
 =?us-ascii?Q?ZS/zySoVQPDLgtfu3J7qePyOmfVgizX8vwo/MmUmRahB0BiCqwrsbiGnyh3i?=
 =?us-ascii?Q?Y6zdBgHqPeDJsyQ8ra3uE01LjwMxy4+XudYgx/vRASytQALQOt5WzoAp5UAG?=
 =?us-ascii?Q?JRxNG4x/HmwMY2L4Zlc0G7JPEuVC6sYFmnmdiZuCNYgz+Yt93EflWLmAVB4Y?=
 =?us-ascii?Q?cE9VWdxkMB3xP33SpHUMKxLNAs8ScZ8750dtf7RXvtJZjBK8eHY8lujS/z+T?=
 =?us-ascii?Q?Z+13qee1BlDUfEIBehzpk8pTvN8rPb5kDZ+eMNiBqRc9Ph7OE9f4vtbpIoS6?=
 =?us-ascii?Q?nHMhNpdb79+rdgnjXRWybdZrEV6f77z7obWCeRm5lDrJiLAK98K4XVI2eStM?=
 =?us-ascii?Q?6mvyM71OaxIDAYBhckzDca4FE6sJ9wrd7YTchYdNOtUtsmf32wKEzVy1O0Lz?=
 =?us-ascii?Q?Ky4V76hpAKhKw5eimsG2nbgPNqG6MG+zZfc8tZK60+qGl9XfCdkwlNCVbK/O?=
 =?us-ascii?Q?SEE+XNsfPcMPEkIYBw+HLCBTi3028taZOX0lQp8tp4WqofeU+D1wteyK9MKM?=
 =?us-ascii?Q?p+3GBi/ARRWVsC/SDPx8vg8N8OupgOdsU2ISzI5p3r4XpOcTPObmUKtx2d0E?=
 =?us-ascii?Q?yRRw41lI8dv6ffdTjEYtREqQaVGVSO40IRuGDSg7mO/z4XjOxHx8Z/+o1K78?=
 =?us-ascii?Q?2kSy4j5TwjnhtfaQd5Utoi3O7+6m/lUBAVtpUTV8SyO4G1cmmls0zKeuC/04?=
 =?us-ascii?Q?f/NhbtKXLylMJGPWJEix+fXOeTkqGFCOlgyqWwvCwy/Svem7TFQU60xuhZQ2?=
 =?us-ascii?Q?NdfszGZR3LQsOomv06KwWCWkFwlofyccEj1KdsCgGp5lhotyKr0CXyYOd7wY?=
 =?us-ascii?Q?ki26kunwpoqI4YAA1PM6j/+z88B9b6aoNmEV6DDthdsNzgHhG3dKnPtQA8Az?=
 =?us-ascii?Q?fcl9Ff+IbREW2vaMgJZlsURI0eMH5A+8KyVlwSFHqSFPGfcnDbYNwvBJAR7z?=
 =?us-ascii?Q?2YoZqrHrWhVYewTgVKs0yXfIDz5HvvhI1sNGbNHx7XqX91C0GD04KwjaWnyK?=
 =?us-ascii?Q?0nc5bflpkNExJeZeEojR2ceWHc2KgihOvE94Uw0g?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1693.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 33d0fed5-3326-45af-1930-08da8d204ed0
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Sep 2022 20:18:32.6608
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: I8fEuOERWoi8KtQ3HBQ0BG8x7uSvY1o4ShSFeDeL1s2MRQO10xaVY27o7ddzYOy4PueFxLzYU+zTAt3raWxNwQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB1848
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,
        SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>> -     if ((reg >> 16) !=3D LAN9303_CHIP_ID) {
>> -             dev_err(chip->dev, "expecting LAN9303 chip, but found: %X\=
n",
>> +     if (((reg >> 16) !=3D LAN9303_CHIP_ID) &&
>> +         ((reg >> 16) !=3D LAN9354_CHIP_ID)) {
>> +             dev_err(chip->dev, "unexpected device found:=20
>> + LAN%4.4X\n",
>>                       reg >> 16);
>>               return -ENODEV;
>>       }
>> @@ -884,7 +889,7 @@ static int lan9303_check_device(struct lan9303 *chip=
)
>>       if (ret)
>>               dev_warn(chip->dev, "failed to disable switching %d\n",=20
>> ret);
>>
>> -     dev_info(chip->dev, "Found LAN9303 rev. %u\n", reg & 0xffff);
>> +     dev_info(chip->dev, "Found LAN%4.4X rev. %u\n", (reg >> 16), reg=20
>> + & 0xffff);
>>
>>       ret =3D lan9303_detect_phy_setup(chip);
>>       if (ret) {
>> diff --git a/drivers/net/dsa/lan9303_mdio.c=20
>> b/drivers/net/dsa/lan9303_mdio.c index bbb7032409ba..d12c55fdc811=20
>> 100644
>> --- a/drivers/net/dsa/lan9303_mdio.c
>> +++ b/drivers/net/dsa/lan9303_mdio.c
>> @@ -158,6 +158,7 @@ static void lan9303_mdio_shutdown(struct=20
>> mdio_device *mdiodev)
>>
>>  static const struct of_device_id lan9303_mdio_of_match[] =3D {
>>       { .compatible =3D "smsc,lan9303-mdio" },
>> +     { .compatible =3D "microchip,lan9354-mdio" },
>
>Please validate that what you find on the board actually is what the compa=
tible says it should be. If you don't validate it, there will be some DT bl=
obs that have the wrong value, but probe fine. But then you cannot actually=
 make use of the compatible string in the driver to do something different =
between the 9303 and the 9354 because some boards have the wrong compatible=
....
>
>     Andrew
>

At this time, the driver is meant to support both devices equally.  In the =
future, I will be adding content that only applies to the LAN9354.  That is=
 when I'm planning to add .data to the .compatible entries.

Jerry.