Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 2 Sep 2022 15:37:21 -0500
From:   Rob Herring <robh@kernel.org>
To:     Pali =?iso-8859-1?Q?Roh=E1r?= <pali@kernel.org>
Cc:     Marek =?iso-8859-1?Q?Beh=FAn?= <kabel@kernel.org>,
        devicetree@vger.kernel.org, linux-pm@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 1/3] dt-bindings: reset: syscon-reboot: Add priority
 property
Message-ID: <20220902203721.GA356619-robh@kernel.org>
References: <20220820102925.29476-1-pali@kernel.org>
 <20220822124728.GA3641041-robh@kernel.org>
 <20220822135050.o4a4bw3dqkmhtjgb@pali>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20220822135050.o4a4bw3dqkmhtjgb@pali>
Precedence: bulk

On Mon, Aug 22, 2022 at 03:50:50PM +0200, Pali Roh?r wrote:
> On Monday 22 August 2022 07:47:28 Rob Herring wrote:
> > On Sat, Aug 20, 2022 at 12:29:23PM +0200, Pali Roh?r wrote:
> > > This new optional priority property allows to specify custom priority level
> > > of reset device. Default level was always 192.
> > 
> > Why do we need/want this? What problem does it solve?
> 
> See patch 3/3.
> 
> > > Signed-off-by: Pali Roh?r <pali@kernel.org>
> > > ---
> > >  .../devicetree/bindings/power/reset/syscon-reboot.yaml        | 4 ++++
> > >  1 file changed, 4 insertions(+)
> > > 
> > > diff --git a/Documentation/devicetree/bindings/power/reset/syscon-reboot.yaml b/Documentation/devicetree/bindings/power/reset/syscon-reboot.yaml
> > > index da2509724812..d905133aab27 100644
> > > --- a/Documentation/devicetree/bindings/power/reset/syscon-reboot.yaml
> > > +++ b/Documentation/devicetree/bindings/power/reset/syscon-reboot.yaml
> > > @@ -42,6 +42,10 @@ properties:
> > >      $ref: /schemas/types.yaml#/definitions/uint32
> > >      description: The reset value written to the reboot register (32 bit access).
> > >  
> > > +  priority:
> > 
> > A bit too generic for the name.
> > 
> > > +    $ref: /schemas/types.yaml#/definitions/sint32
> > > +    description: Priority level of this syscon reset device. Default 192.
> > 
> > default: 192
> > 
> > 
> > Though I'm not really sure about the whole concept of this in DT. Where 
> > does 192 come from?
> 
> Implicitly from the current implementation and how it is used.

Implementation of what? u-boot? BSD? robOS?

> >?Presumably if we have more than 1 reset device, then 
> > 'priority' is needed in multiple places. So you need a common schema 
> > defining the property (as property types should be defined exactly 
> > once) which this schema can reference.
> > 
> > Rob
> 
> Sorry, I do not understand.

So just keep sending new versions instead?

syscon-reboot is not the only binding for a system reset device, right? 
So those others reset devices will need 'priority' too. For a given 
property, there should only be one schema definition defining the type 
for the property. Otherwise, there might be conflicts. So you need a 
common schema doing that. And here you would just have 'priority: true' 
or possibly some binding specific constraints.

Rob