Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 3 Sep 2022 09:54:22 +0800
From:   Baoquan He <bhe@redhat.com>
To:     Uladzislau Rezki <urezki@gmail.com>
Cc:     Song Liu <song@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Linux-MM <linux-mm@kvack.org>,
        open list <linux-kernel@vger.kernel.org>,
        Song Liu <songliubraving@fb.com>
Subject: Re: [PATCH] mm/vmalloc: Extend find_vmap_lowest_match_check with
 extra arguments
Message-ID: <YxKzzsyK99bwnbAy@MiWiFi-R3L-srv>
References: <20220831052734.3423079-1-song@kernel.org>
 <20220831160111.a6e7d17785ca21ce7c43981c@linux-foundation.org>
 <CAPhsuW4SGguyoFKpN8S=jFCWfLiDM-f5QwV7UPwkQ=LjQEXaNg@mail.gmail.com>
 <CA+KHdyUDGkUBtnAcvu+NB=S7chp_1N3XviTkkMoP-8LrLJQgbg@mail.gmail.com>
 <YxF69izHufARLKqA@MiWiFi-R3L-srv>
 <CA+KHdyWijMSuNaT4vQ-tqyrJC_GxL++rDj-s1WZMkDi=8m3p1A@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CA+KHdyWijMSuNaT4vQ-tqyrJC_GxL++rDj-s1WZMkDi=8m3p1A@mail.gmail.com>
Precedence: bulk

On 09/02/22 at 06:45pm, Uladzislau Rezki wrote:
> > > Even without this patch, the debug path would work correctly. The
> > > difference is just only in
> > > whether roots are hardcoded or passed over function paramter.
> >
> > Calling find_vmap_lowest_match() inside find_vmap_lowest_match_check()
> > will fail compilation because the function interface has been changed.
> >
> Ah. That makes sense, though the commit message has to reflect it.
> So it is only about compilation error if debug is ON.

Indeed, the current patch log sounds like an improvement or normal change.
In fact it's a code fix.