Received: by 2002:a05:6358:bb9e:b0:b9:5105:a5b4 with SMTP id df30csp832178rwb; Sat, 3 Sep 2022 03:48:30 -0700 (PDT) X-Google-Smtp-Source: AA6agR6S0pP5au35jBBbA3bQAbu0+yPwqVvFz7DpeS0JSNdOti9UZIa9VriLH5Tnh9Vn5F+rtxD4 X-Received: by 2002:a17:902:694a:b0:172:bd15:3ece with SMTP id k10-20020a170902694a00b00172bd153ecemr40211533plt.116.1662202109668; Sat, 03 Sep 2022 03:48:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662202109; cv=none; d=google.com; s=arc-20160816; b=vj4mgoX0mUZTtNj5Aqn3f5k7/ogtFIendsjrTrGVf5M726bWXzJ3DWxL2+U1i5Wu2O 0sA2B7UfegVoJ67jKdDoAK9tFtjhMerwx/ZQow4/DNPvvBn12DMf9Rf8cn+R/VAin3wU sR6brCqt1+7j4IQSGy6zuTopmCoHPMfzlttil27nz8IMKLWoyYgi+lXwqtPsQbkWw3bT +aTLm3Ycfmkk4gJIzFS+QPv0p+ubRevG3zDkHljmrtF+XPmNwINFnds/34UqyzvRmjx2 4GvgxsAmn68uLxbtHafcaQ+9gvgorIixNZGzuDZsDlkGb647vsN/+y+iGCgA2irjcVPf ozrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=coU89cLiYcpu8p2L/oROUJniUf0ubUmeI4US7LG7oKg=; b=nU2qr4Cj1ja3BTZifdXiNBRIaY6HKYkU+ZHChm91a0/xTGSh3wV6mF1BJEDQjShOLm HhxjMvcE/eGbf2faieJhzYzNPr2tRNOdo+Ke1+n8dsE6QsHDxWKyE0FYYBL1WexiK88R Hy5WgfPM2Mf6gALwys9DpDRgDsC8hIuCksGiuQXROrpoT3php+2wqbZ+D3i5JLtxv1jy Ygu2fx+Zic9V9hKc4/wPbEiZX3vtRAwO8o6rWAUCavRJv+Ewr1Us7EA3TSgeQDHq44/2 uSirhfaRBqt5RbEupx6bAwTj5F+JTgqnbxExOD+XMVE2GWMHGKnngyl8K9RAA6IpfSv2 tCxg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id rj6-20020a17090b3e8600b001fb3503ff97si5132817pjb.8.2022.09.03.03.48.18; Sat, 03 Sep 2022 03:48:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230229AbiICKBi (ORCPT + 99 others); Sat, 3 Sep 2022 06:01:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48630 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229506AbiICKBf (ORCPT ); Sat, 3 Sep 2022 06:01:35 -0400 Received: from hust.edu.cn (unknown [202.114.0.240]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3B0365755A; Sat, 3 Sep 2022 03:01:33 -0700 (PDT) Received: from localhost.localdomain ([172.16.0.254]) (user=dzm91@hust.edu.cn mech=LOGIN bits=0) by mx1.hust.edu.cn with ESMTP id 283A15mQ005669-283A15mT005669 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Sat, 3 Sep 2022 18:01:11 +0800 From: Dongliang Mu To: Greg Kroah-Hartman , Dongliang Mu , Hangyu Hua Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] usb: misc: uss720: fix uninitialized variable rlen Date: Sat, 3 Sep 2022 18:00:01 +0800 Message-Id: <20220903100004.2874741-1-dzm91@hust.edu.cn> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-FEAS-AUTH-USER: dzm91@hust.edu.cn X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dongliang Mu Smatch reports the following error: uninitialized symbol 'rlen' drivers/usb/misc/uss720.c:514 parport_uss720_epp_write_data() error drivers/usb/misc/uss720.c:575 parport_uss720_ecp_write_data() error drivers/usb/misc/uss720.c:593 parport_uss720_ecp_read_data() error drivers/usb/misc/uss720.c:626 parport_uss720_write_compat() error The root cause is, the failure of usb_bulk_msg leads to the uninitialized variable rlen in printk function. Fix this by initializing rlen with zero. Signed-off-by: Dongliang Mu --- drivers/usb/misc/uss720.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/usb/misc/uss720.c b/drivers/usb/misc/uss720.c index 0be8efcda15d..b00d92db5dfd 100644 --- a/drivers/usb/misc/uss720.c +++ b/drivers/usb/misc/uss720.c @@ -502,7 +502,7 @@ static size_t parport_uss720_epp_write_data(struct parport *pp, const void *buf, #else struct parport_uss720_private *priv = pp->private_data; struct usb_device *usbdev = priv->usbdev; - int rlen; + int rlen = 0; int i; if (!usbdev) @@ -563,7 +563,7 @@ static size_t parport_uss720_ecp_write_data(struct parport *pp, const void *buff { struct parport_uss720_private *priv = pp->private_data; struct usb_device *usbdev = priv->usbdev; - int rlen; + int rlen = 0; int i; if (!usbdev) @@ -581,7 +581,7 @@ static size_t parport_uss720_ecp_read_data(struct parport *pp, void *buffer, siz { struct parport_uss720_private *priv = pp->private_data; struct usb_device *usbdev = priv->usbdev; - int rlen; + int rlen = 0; int i; if (!usbdev) @@ -614,7 +614,7 @@ static size_t parport_uss720_write_compat(struct parport *pp, const void *buffer { struct parport_uss720_private *priv = pp->private_data; struct usb_device *usbdev = priv->usbdev; - int rlen; + int rlen = 0; int i; if (!usbdev) -- 2.35.1