Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Xin Ji <xji@analogixsemi.com>
To:     Andrzej Hajda <andrzej.hajda@intel.com>,
        Neil Armstrong <narmstrong@baylibre.com>,
        Robert Foss <robert.foss@linaro.org>,
        Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
        Jonas Karlman <jonas@kwiboo.se>,
        Jernej Skrabec <jernej.skrabec@gmail.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>
Cc:     bliang@analogixsemi.com, qwen@analogixsemi.com,
        mliu@analogixsemi.com, hsinyi@chromium.org,
        Xin Ji <xji@analogixsemi.com>, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
Subject: [PATCH] drm/bridge: anx7625: Set HPD irq detect window to 2ms
Date:   Sat,  3 Sep 2022 21:08:33 +0800
Message-Id: <20220903130833.541463-1-xji@analogixsemi.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ZNXgPHRGVLkpnrK67SfGQfE6jumMSL9+6iWNrNHzqGFU00Pa+2QGHjfB8uih?=
 =?us-ascii?Q?GkdjB4Ba6L/SsFxIpwn9kd9PGVu9JFky52U94L8RUfxG0cLvtz5aBFw4Gc8A?=
 =?us-ascii?Q?yuEaAFBAb8uefsQZf9AsXh8gZqLE43fwecQFWUloUEr5WAAlnAJcEUYBEjw9?=
 =?us-ascii?Q?w8GDFOrjkTFii1Vufg60OsRje1nsNwIkXjH0KWamQWaiEpj/4v6TzB2eTZYC?=
 =?us-ascii?Q?ji2HA46scrjhlCyyg9PXFQ++DW8YZvq91S2Gag60pcoAx9Yhf8bPJZOmQ/ps?=
 =?us-ascii?Q?/HeEnvGjFxoGGG9kleUHaMZvM2O/FL3VDx/9AXEl/dZz0CXymi5qmjg4ZpIs?=
 =?us-ascii?Q?nCOSfBleYrde0YAWuS7rBJA8VD3xdPbLtUtz16jDpe3RCwf2jGJNExA4mpNf?=
 =?us-ascii?Q?OkoKD68OojFoy05Jkk2R6RkxI4UsLnXxQkHQpB0zMmC5BrMmvOVl6YEYHhNv?=
 =?us-ascii?Q?Khxxj20Q8FGCoB4UZ2QFOR4/sU0oYLFililx4+TKDOquBAFu1aL3DBTEG/q8?=
 =?us-ascii?Q?ZGmoMU+H0RteBDA/5//R04q5jr2sn+teZidD13x2Ap3HmNL9cTdChl8Fi80Z?=
 =?us-ascii?Q?hchqieH6xp0qY4AaN5dPZlVVS2AkMQta1uldQ/+nN58hG2sse4GwjWnxjeBt?=
 =?us-ascii?Q?A2DSM2SJlVSXkD5wecqHRTmE+wRX/pu7X+0jBQw0AdIOUwj4R/5NC58ul/Ek?=
 =?us-ascii?Q?ORiMSifpNv00jaMZLEs++lz9cJcvKtb+AK6CWMUSlxGprv2N/idgXa4cvllR?=
 =?us-ascii?Q?TpQQJXqlIF0amRfjQbnToAl3O11mMsvTc6QCYvJ+JU5OX5da3UCd2SsrHKc3?=
 =?us-ascii?Q?B4/DR7E/oX1VtmRYBLnWWv8aDuDl4RjvNscI/n6jC4l6K1DmzVS+dxy0kbC3?=
 =?us-ascii?Q?kgHRC/igqFwiGcnIzO74x/+Lf++J7AK/pby7dyXTC1+bGYyC2EwaeFgxjZ8h?=
 =?us-ascii?Q?Lcm+pm3ZpwELv5GrOoH/hYS/7WjgA3BOIZ8L4L45TSkfqp+huBx9yoBpCHIo?=
 =?us-ascii?Q?6JZLn7PFP8U0ATiLu6RNJtOr9hwrWaTuAifRXJMjpB8cijUX7VnyRHKmOK6k?=
 =?us-ascii?Q?oyuNTp/Ku6hj/94QZIFBwKoHaBxLZ6IjJCwKIg/CvJ0SU2t/zBLhP0jy2EFH?=
 =?us-ascii?Q?8YmNx941M1LcCjJYELWfLTCzLYB/E4FSQWedSnEopJRgoY+oRZEAxQHBrMmL?=
 =?us-ascii?Q?EFZ4rLvKbrkXhHTd+gAgPVfOmasoojmuNGn+KLbTIfh5JfTlR/TsP5EYINMx?=
 =?us-ascii?Q?yqhK0PAW45HqLCrV76CVuBwvRPUGW8GNXegWdQH/EpHsRJ9DnwnAnk7pXfC8?=
 =?us-ascii?Q?5qeYxexgMmIKZb7vKwawT7AkKOcW4GqLfvbuk08YsCmBuKnUhLb9USZyeWbB?=
 =?us-ascii?Q?cOL6NZ52n3QEmkY8YqMcUKdVXJDbDnsPqsYKmw87KJroyZcWqG2VXHDIE9Bt?=
 =?us-ascii?Q?VxM5D0jMuKd1g7VitFOpvUEfF8BUYiyWsYVhSAdRyEu9fxlYjRBNtgx3UVoK?=
 =?us-ascii?Q?NSHXNrAldpG56G15adlZL4fCs552vVxpLWO6+PXetKnUcTMUsQvIFqOA9h3W?=
 =?us-ascii?Q?VOuqYs/jJSaFv5Fgq5yFfJQZxDzaH0rD+THp/DEJ?=
X-OriginatorOrg: analogixsemi.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a2345198-b7d9-4e5e-1dc8-08da8dad7bc0
X-MS-Exchange-CrossTenant-AuthSource: BY5PR04MB6739.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Sep 2022 13:09:07.3424
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: b099b0b4-f26c-4cf5-9a0f-d5be9acab205
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: oIppu2hiWXpkHtwNFRin+WsGvsTXBbZIsiIPrf6LPvYf0ze0PjxXF9X865SrsYrkAwbvSRaVmsanHjGTEy8mKQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR04MB4458
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Some panels trigger HPD irq due to noise, the HPD debounce
may be 1.8ms, exceeding the default irq detect window, ~1.4ms.
This patch set HPD irq detection window to 2ms to
tolerate the HPD noise.

Signed-off-by: Xin Ji <xji@analogixsemi.com>
---
 drivers/gpu/drm/bridge/analogix/anx7625.c | 14 ++++++++++++++
 drivers/gpu/drm/bridge/analogix/anx7625.h |  6 ++++++
 2 files changed, 20 insertions(+)

diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
index c74b5df4cade..0c323b5a1c99 100644
--- a/drivers/gpu/drm/bridge/analogix/anx7625.c
+++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
@@ -1440,6 +1440,20 @@ static void anx7625_start_dp_work(struct anx7625_data *ctx)
 
 static int anx7625_read_hpd_status_p0(struct anx7625_data *ctx)
 {
+	int ret;
+
+	/* Set irq detect window to 2ms */
+	ret = anx7625_reg_write(ctx, ctx->i2c.tx_p2_client,
+				HPD_DET_TIMER_BIT0_7, HPD_TIME & 0xFF);
+	ret |= anx7625_reg_write(ctx, ctx->i2c.tx_p2_client,
+				 HPD_DET_TIMER_BIT8_15,
+				 (HPD_TIME >> 8) & 0xFF);
+	ret |= anx7625_reg_write(ctx, ctx->i2c.tx_p2_client,
+				 HPD_DET_TIMER_BIT16_23,
+				 (HPD_TIME >> 16) & 0xFF);
+	if (ret < 0)
+		return ret;
+
 	return anx7625_reg_read(ctx, ctx->i2c.rx_p0_client, SYSTEM_STSTUS);
 }
 
diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.h b/drivers/gpu/drm/bridge/analogix/anx7625.h
index e257a84db962..14f33d6be289 100644
--- a/drivers/gpu/drm/bridge/analogix/anx7625.h
+++ b/drivers/gpu/drm/bridge/analogix/anx7625.h
@@ -132,6 +132,12 @@
 #define I2S_SLAVE_MODE 0x08
 #define AUDIO_LAYOUT   0x01
 
+#define HPD_DET_TIMER_BIT0_7   0xea
+#define HPD_DET_TIMER_BIT8_15  0xeb
+#define HPD_DET_TIMER_BIT16_23 0xec
+/* HPD debounce time 2ms for 27M clock */
+#define HPD_TIME               54000
+
 #define AUDIO_CONTROL_REGISTER 0xe6
 #define TDM_TIMING_MODE 0x08
 
-- 
2.25.1