Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220829011534.445092-1-liaoyu15@huawei.com>
In-Reply-To: <20220829011534.445092-1-liaoyu15@huawei.com>
From:   "Rafael J. Wysocki" <rafael@kernel.org>
Date:   Sat, 3 Sep 2022 20:15:56 +0200
Message-ID: <CAJZ5v0jfgHNeA=tARWtMT5v8w5QKpwvo0n_LDJPgX34yk7gDUw@mail.gmail.com>
Subject: Re: [PATCH] cpuidle: remove redundant check in cpuidle_switch_governor
To:     Yu Liao <liaoyu15@huawei.com>
Cc:     "Rafael J. Wysocki" <rafael@kernel.org>,
        Daniel Lezcano <daniel.lezcano@linaro.org>,
        Linux PM <linux-pm@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        liwei391@huawei.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Aug 29, 2022 at 3:08 AM Yu Liao <liaoyu15@huawei.com> wrote:
>
> gov has already been NULL checked at the beginning of
> cpuidle_switch_governor, so remove redundant check.
>
> And use pr_info instead printk to fix the following checkpatch warning.
>
> WARNING: Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then
> dev_info(dev, ... then pr_info(...  to printk(KERN_INFO ...
>
> Signed-off-by: Yu Liao <liaoyu15@huawei.com>
> ---
>  drivers/cpuidle/governor.c | 10 ++++------
>  1 file changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/cpuidle/governor.c b/drivers/cpuidle/governor.c
> index 29acaf48e575..9e6865edb942 100644
> --- a/drivers/cpuidle/governor.c
> +++ b/drivers/cpuidle/governor.c
> @@ -63,12 +63,10 @@ int cpuidle_switch_governor(struct cpuidle_governor *gov)
>
>         cpuidle_curr_governor = gov;
>
> -       if (gov) {
> -               list_for_each_entry(dev, &cpuidle_detected_devices, device_list)
> -                       cpuidle_enable_device(dev);
> -               cpuidle_install_idle_handler();
> -               printk(KERN_INFO "cpuidle: using governor %s\n", gov->name);
> -       }
> +       list_for_each_entry(dev, &cpuidle_detected_devices, device_list)
> +               cpuidle_enable_device(dev);
> +       cpuidle_install_idle_handler();
> +       pr_info("cpuidle: using governor %s\n", gov->name);
>
>         return 0;
>  }
> --

Applied (with some minor modifications) as 6.1 material, thanks!