Received: by 2002:a05:6358:bb9e:b0:b9:5105:a5b4 with SMTP id df30csp1433252rwb; Sat, 3 Sep 2022 16:06:18 -0700 (PDT) X-Google-Smtp-Source: AA6agR5nvS+8xHz4gEADDF3ovnRQyvZU0DsETID05cDSFPf8KdjJ/RndA0kx2Mg5knFqDE0DGKMt X-Received: by 2002:a05:6a00:896:b0:53a:993c:a45e with SMTP id q22-20020a056a00089600b0053a993ca45emr21350964pfj.83.1662246377811; Sat, 03 Sep 2022 16:06:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662246377; cv=none; d=google.com; s=arc-20160816; b=mQvm1ucdaB3pNWHtmnx0Nqyfr25p0yA3+1p0q9tdC94b78Evik5qo0DD10Z/Gy2bf8 u27g5LJxEoNQUeV27DcCM6yLBSKaV/bbq7g5pMLrXbpat1ygbxYk/C2+5GiSD0HxHR6g 7fzRNpqf0/ALW0ZewLgmakj3/D8BDLFrB7AUaUFgjxETtrsXVOf53TcdpW3V/4sBZs8/ 0doTBBQU3gq+0jqsSq4MHQXh+VTGNSeS3RKV5jR6g2nbeLb0oGtVD6+Ne8BsgPNxTGzi MjJIHNOcxDCfblw2nXzd8Zyzyw+3Dwuq5UWmj13YW+fZRYk/rZ1ruJaX5PKrjQnm023Q Dbug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=koGSFeL8YK66YnxxoLTJOiqK09bB1eXPLPZIIXte/UA=; b=XolHNt1gpjEt4iUX8SHexysR5NGjM1Ciu6iwqISdeOb49J4SoIe5MTzN5bAWl10MZY qrt+OkBchgi1I1+Rf+JWpVt9roVIGP681Lz3wMNeFucMXjVP3j6CCrlFCFfapCZFeUY5 fjpAbc6fcrtHGDRngXfMbL+s/UW1iXIcNIZiChVbnDsDmiCd+Ppe62kwUxdvsrgKlZG1 QrMzP6+ArxD6YmnUtVNp6CaDZ+/DYVC0avE+VVLIg4A2oKju77I722VrekDxW7J8qjL9 jnzwr6Mc8UDYf64tp2d1b5BadiEikOQXkPZG83fpUs52fzZI1EB6yt5Fk/yiwGqiZ+v9 eiFA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=ZXlItbIU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d25-20020a656219000000b0042c70745e9asi5942405pgv.14.2022.09.03.16.06.00; Sat, 03 Sep 2022 16:06:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=ZXlItbIU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229700AbiICWls (ORCPT + 99 others); Sat, 3 Sep 2022 18:41:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60318 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229525AbiICWlr (ORCPT ); Sat, 3 Sep 2022 18:41:47 -0400 Received: from mail-pl1-x62f.google.com (mail-pl1-x62f.google.com [IPv6:2607:f8b0:4864:20::62f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7537D474F1; Sat, 3 Sep 2022 15:41:46 -0700 (PDT) Received: by mail-pl1-x62f.google.com with SMTP id 9so2001774plj.11; Sat, 03 Sep 2022 15:41:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date; bh=koGSFeL8YK66YnxxoLTJOiqK09bB1eXPLPZIIXte/UA=; b=ZXlItbIUXZJeBZNi4fNoOofx++nkBztOPswlufi7hsJZuOvgl9SqtGtwpAdeFYlYBk Xe10dyBgBbpZJxD27CP9QLpvKwUWTyCj9VUTj9ZL47QtWZULNg54LFBwryD1qjcnHw+j 7OIHR3kbmDGdP5rf0TVsEZWWtvkyXvf/i8FOsts0U66noZp6g31LEyl0oVN4k6UDDyn6 tjeiFz62s8NnaJg2MzWofok2qg1GITaAFY+wsFSTQehv2ZiYx+Ty5kr6elofC1NNAjNW 6mkcFhQUGgmEHwlS8uKX3Ao27jjJR3bnKA3Jwv6QQw+1phsLAM3FdqrG31ZiwZdJrpdr hbcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date; bh=koGSFeL8YK66YnxxoLTJOiqK09bB1eXPLPZIIXte/UA=; b=gYEBVp3E1Ap+ssC3zieQWZiOoFyRkmj6HtKAg6PmF2y/Ryv0SNWEdym3tSKeWexAIQ 5/BuD/sGsivXbypG9tpHetgaXlO2ucxQJ3AnzxkI4ZfBzH1PArazhe7jtLDtJHDG8QlO NSBovVABsVMTUO+JTylS/Hubh2KryjjZqw+QSn+AFngBc4yylDxLH5CK5i4JWYjOMazA qfNkzV0MBRB3kj8lUMHGDFlxEz1AoP96Olojl5HbfVy5hiIn34R7qTL47+MIknIWaDrZ bGCaswyW3iekV0F440MgaEkcI0UCEeKe1rae1TPzdlvSrdd8WnE/1pFJ9a+m29AdS6ye 3rkw== X-Gm-Message-State: ACgBeo3mOYO9RP33bHvVn2aLdaxLLYtFF9PnFKEcv7wt3br2fR6b7AWc 2m+uPTSWJsnU7XAUT5AjCXdTW+gfIYyExA== X-Received: by 2002:a17:902:8307:b0:172:e611:491f with SMTP id bd7-20020a170902830700b00172e611491fmr41752428plb.111.1662244904427; Sat, 03 Sep 2022 15:41:44 -0700 (PDT) Received: from localhost.localdomain (lily-optiplex-3070.dynamic.ucsd.edu. [2607:f720:1300:3033::1:4dd]) by smtp.googlemail.com with ESMTPSA id i15-20020a17090a2a0f00b001fddb3a5481sm7502193pjd.49.2022.09.03.15.41.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 03 Sep 2022 15:41:44 -0700 (PDT) From: Li Zhong To: linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org Cc: mturquette@baylibre.com, sboyd@kernel.org, Li Zhong Subject: [PATCH v2] drivers/clk/clk: check return value of clk_pm_runtime_get() Date: Sat, 3 Sep 2022 15:41:25 -0700 Message-Id: <20220903224125.2276690-1-floridsleeves@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org clk_pm_runtime_get() could fail. Check the return status. Signed-off-by: Li Zhong --- drivers/clk/clk.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c index 7fc191c15507..09353f7bf052 100644 --- a/drivers/clk/clk.c +++ b/drivers/clk/clk.c @@ -2981,8 +2981,12 @@ static void clk_summary_show_subtree(struct seq_file *s, struct clk_core *c, int level) { struct clk_core *child; + int ret; + + ret = clk_pm_runtime_get(c); + if (ret) + return; - clk_pm_runtime_get(c); clk_summary_show_one(s, c, level); clk_pm_runtime_put(c); -- 2.25.1