Received: by 2002:a05:6358:bb9e:b0:b9:5105:a5b4 with SMTP id df30csp1448128rwb; Sat, 3 Sep 2022 16:30:09 -0700 (PDT) X-Google-Smtp-Source: AA6agR5cjTj2FmDKwC7b4GKqxHZmoPNq4j0wI1d77kcx/eWKOWSoRMQXHE6XOD0MHAlligEf1DD2 X-Received: by 2002:a17:907:7f0b:b0:731:b81a:1912 with SMTP id qf11-20020a1709077f0b00b00731b81a1912mr31500909ejc.8.1662247808757; Sat, 03 Sep 2022 16:30:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662247808; cv=none; d=google.com; s=arc-20160816; b=RPXde4vEG1p4TeS0KG6HXnI9Eq5i5k439m47fUVzzYgNwsm+5S1FM3TE5nA2iDSM7C hoEgRpJPNg9fI7rP2NCjmW49H8/N723EUSjZK53eGI+MwiUtr1TQ2cuA2uyeFdKzjTRm UQKU7tJWmkJ/dz7UKEjtkAQUe5SZPydNnmzdmgbnlr0v5CHkfXuksoY1z9OJZ4ahJmx8 /XuLZjPODphAKprhPZll0APfPIlHtYVXK/tajzWBU7rigp/bpoiqygm2TNV1dwW00p+j c+gJlL0fOGnadnIxbs78m1PSmA0/9U0Edl1RjsHS7OwSsDAkUVmZmJ6X2pewKT4/OPTY BFdg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=MTRyQeNwNmtbjly6m0NqygvjI275gpJb7kZzL+rHJ2w=; b=k41CdnDDzwH9sle6WiYDN+Jcmb9fBbvuxyRvzKn+bwutkWLyp3m1X3PhFupoh2xFnk g28iH5v06jHrotPE1thja1VF9z4SrhtCFoNnsxQKXNlh68027/1hI3QTtm3IUtr4Mouu 6LIVy1o303cShclCzWjRgZaqccqg9mzAefk4tXtj8Mh23/daF7EiSyrWd7CVDMT9Hs34 tXSMd5t/hFJU4hohXb9YL6g0uX3oJs8pRItAhtPBT5Y3Qi48MsrUS6kPPeKF0UiSbK/r 9Q/DFa2nkXGfe/qkbwp6YYiX2NChUW3692FTzD6Ou98G55W5fHmxlkrDalFlDb3GtVLS Jq1w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=EMCanUpS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id dc14-20020a170906c7ce00b0072b83c76e0esi3472672ejb.252.2022.09.03.16.29.43; Sat, 03 Sep 2022 16:30:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=EMCanUpS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231472AbiICXKw (ORCPT + 99 others); Sat, 3 Sep 2022 19:10:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34548 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229677AbiICXKv (ORCPT ); Sat, 3 Sep 2022 19:10:51 -0400 Received: from mail-pf1-x430.google.com (mail-pf1-x430.google.com [IPv6:2607:f8b0:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D14CA4BA5A; Sat, 3 Sep 2022 16:10:49 -0700 (PDT) Received: by mail-pf1-x430.google.com with SMTP id b144so555704pfb.7; Sat, 03 Sep 2022 16:10:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date; bh=MTRyQeNwNmtbjly6m0NqygvjI275gpJb7kZzL+rHJ2w=; b=EMCanUpSg48ofcHvYZZ62AUtfn3jLg9Ld74CDzZ6h3O5ErCHFO9JkPi3I4re9fj7J7 DsdhthaD2uz1iuZxz14zaFQQIUb5+pMyZrePU7gU1wvTrknnmvEG1VjZ2gidt8p95nna IYyCdMjMgoYinVgnLybtZaMbTLWOpGU1lfqYb2hlZ42/VyixOgOnk17eQhHPT5SkGn+A 2Rm9lx20CsgVdenw3Snqbvv+X/Z94FZs90FU0Lncuo+bY5J4vUrTa2Gt6NbX0XPEXO75 zktj3I11VeSP1HXRZyf8UDtf3vztuwoswpPNmVRrkk2RvpRkBRDHbxSJzcQH+a1+JhzO b29w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date; bh=MTRyQeNwNmtbjly6m0NqygvjI275gpJb7kZzL+rHJ2w=; b=2objGE4+Vdx5K7LzipMSKxKTW9w5rCQGl3lHkuGQHo1a8EUGk098l87HFBD3PzMR2v 5MPSPGAR9ZgXX8GlvrxYeZFpJGMcmmeYMMinmKA/70jXpVLMV1HNiROfWJHUwv0A3w1L 0n9Qw5eqixm/72la+atux1UnszpbkjCnSCVzjAlKeKj3d/HWC67tjuxU339MU1EKvtPk 8k7iqcysCypsp6yPh0Szw9UUq2yBg4n6fTuil+crSJd0xUSfg6BZPRzhehHwPIk56fCf wSfJF8rDcgu3uVbdY0NNMSg4SGCHrdMFSQqqD1swWotntoVvLSK44QHiUKOuDoNF7gXg BT0g== X-Gm-Message-State: ACgBeo3BdhTt9bricV7Lwk2REFhFjApEkZylhe9nf+RfRubik1yKvF8z q9ZVIyFeTfyI8xofUX2lZ84LJeFpH+S7sQ== X-Received: by 2002:a05:6a00:ac6:b0:530:3197:48b6 with SMTP id c6-20020a056a000ac600b00530319748b6mr43260583pfl.80.1662246649085; Sat, 03 Sep 2022 16:10:49 -0700 (PDT) Received: from localhost.localdomain (lily-optiplex-3070.dynamic.ucsd.edu. [2607:f720:1300:3033::1:4dd]) by smtp.googlemail.com with ESMTPSA id 26-20020a630d5a000000b00434272fe870sm934390pgn.88.2022.09.03.16.10.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 03 Sep 2022 16:10:48 -0700 (PDT) From: Li Zhong To: linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org Cc: damien.lemoal@opensource.wdc.com, Li Zhong Subject: [PATCH v2] ata: libata-core: Check errors in sata_print_link_status() Date: Sat, 3 Sep 2022 16:10:39 -0700 Message-Id: <20220903231039.2278817-1-floridsleeves@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org sata_scr_read() could return negative error code on failure. Check the return value when reading the control register. Signed-off-by: Li Zhong --- drivers/ata/libata-core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c index 826d41f341e4..ae08c7d35cb0 100644 --- a/drivers/ata/libata-core.c +++ b/drivers/ata/libata-core.c @@ -3021,7 +3021,8 @@ static void sata_print_link_status(struct ata_link *link) if (sata_scr_read(link, SCR_STATUS, &sstatus)) return; - sata_scr_read(link, SCR_CONTROL, &scontrol); + if (sata_scr_read(link, SCR_CONTROL, &scontrol)) + return; if (ata_phys_link_online(link)) { tmp = (sstatus >> 4) & 0xf; -- 2.25.1