Received: by 2002:a05:6358:bb9e:b0:b9:5105:a5b4 with SMTP id df30csp1771511rwb; Sun, 4 Sep 2022 01:42:15 -0700 (PDT) X-Google-Smtp-Source: AA6agR4ahVXjtmzxq8VAmU/DlsWwMtrLgqCschKYdLN1av4XlFwHxVRyS78xO6kDRY0DNvewmqiT X-Received: by 2002:a63:8441:0:b0:42b:65e7:59fb with SMTP id k62-20020a638441000000b0042b65e759fbmr38283014pgd.156.1662280935132; Sun, 04 Sep 2022 01:42:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662280935; cv=none; d=google.com; s=arc-20160816; b=FsrOnlqhhCBjj5TWAwwd25SgQK8czGSTeIvC38glWGeu8FDr4Q5FQdnOyEN00bn7F/ MQWwEkCyiFpILoruQ4ex3aByylCZt2OO+1YhPHjdJJokjGGcOuLVIUHvmuQoLZ08CQAY q874PONx1R7wzdOPKvl5hldLGe4bCV9VfVmNOS4B6dUNnX1YCtlfC6dIdNxzJnZ0Mauf sovrNn+X0I7xMydC6aS1C5y4qchN+/bJd5Gga98RYw/CvpHMP0blIQjlqj8NbGN+MLEO cU/2p9HYLKnsETIoVw/Q+UoSWVVM/hAL2eI+nkBRzE/qkbsjQ33IC2BV0GxuCHxzMFrR iKYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=dcrqbNP9devXULorwxK7Zi8rRzrG9RajfXXmE1uFTMs=; b=QodfkCqYp0tlaF8TV/NOYen0MWQxTeohGpCM6ijRc5fpQJZweD9ZUo7SDtPHp4DZYA HLZBwrdbXp/ygja6Y56lDnxRV4rPPPExFzBqs8OVkaCYXRzs+PNzCEToDq9AMbYeF3Nc GVRieWToeAj4HY1XF6GvWSrv2N+ljrB+cQ0lmIHG/SqzQGIzwBSII/REJZbDsCPfZm5V Z1h5q3MA4CdQMw8taG8R7fvcu7w/FCBCUrIATHHv5BiJHmhhg6GX2BoRkZKcMp+EFJOS u0+9B3bcmRVMhEB+cUx/vPdxd53+J6tSpd3vjbz154w9r+WwseeUijepf9+XTyMlq3zt l8dw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=VGOtql+H; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k189-20020a6384c6000000b0042aeddae776si7313548pgd.290.2022.09.04.01.41.56; Sun, 04 Sep 2022 01:42:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=VGOtql+H; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231771AbiIDIUK (ORCPT + 99 others); Sun, 4 Sep 2022 04:20:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52404 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229537AbiIDIUJ (ORCPT ); Sun, 4 Sep 2022 04:20:09 -0400 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 00FF42CCA8; Sun, 4 Sep 2022 01:20:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1662279608; x=1693815608; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=vUkKqMd+013HwWmzXgAGkD/lAPQSyq4o+Dw/LJBJna8=; b=VGOtql+HwvHXobTuwyhVS967CJSEIXF/Ow0QB9elXLUmMxTs9QofsKaB o6sO6vlJj2Vkx9KGEHdC84knx50tEUnJItEs3nsHZyoKmcrXtwQszfP1z tMkH+sIXsHQvIf7nI5UKXvEqCjXrGpXHPZqPW4FOF/4YyLib5LEDLq2aT IQQ8KsVvgYLgFCuusqXkU7dtW7ZGk0aC68S3pCZW+elTPnU1seTVrZoKC 01wB2jp8J+QXqAY1wk5L1DGIc9tY0Ew9GRBMpS39gSTM9EmPgf88K5TM5 Nmv+RdwUquFhX6zIlj3petyEVeCCf1RspeIRCu0K8ULV0SE7uFyuZ2pYE Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10459"; a="296225827" X-IronPort-AV: E=Sophos;i="5.93,288,1654585200"; d="scan'208";a="296225827" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Sep 2022 01:19:56 -0700 X-IronPort-AV: E=Sophos;i="5.93,288,1654585200"; d="scan'208";a="643438167" Received: from naamamex-mobl.ger.corp.intel.com (HELO [10.13.13.50]) ([10.13.13.50]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Sep 2022 01:19:54 -0700 Message-ID: <2a31d5cc-63db-9b4a-94ca-264ed5cd2adf@linux.intel.com> Date: Sun, 4 Sep 2022 11:19:45 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [Intel-wired-lan] [PATCH v3] drivers/net/ethernet/e1000e: check return value of e1e_rphy() Content-Language: en-US To: Li Zhong , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org Cc: edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, davem@davemloft.net References: <20220830071549.2137413-1-floridsleeves@gmail.com> From: "naamax.meir" In-Reply-To: <20220830071549.2137413-1-floridsleeves@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/30/2022 10:15, Li Zhong wrote: > e1e_rphy() could return error value when reading PHY register, which > needs to be checked. > > Signed-off-by: Li Zhong > --- > drivers/net/ethernet/intel/e1000e/phy.c | 20 +++++++++++++++++--- > 1 file changed, 17 insertions(+), 3 deletions(-) Tested-by: Naama Meir