Received: by 2002:a05:6358:bb9e:b0:b9:5105:a5b4 with SMTP id df30csp1835430rwb; Sun, 4 Sep 2022 03:19:30 -0700 (PDT) X-Google-Smtp-Source: AA6agR769M4pKUpZe9+lNtg9b5qKQh1bAGfvFZUpsGHsWnZSfSmIq1Lq3wuuubreeF8usY7ZT934 X-Received: by 2002:a63:2bcc:0:b0:40c:95b5:46a4 with SMTP id r195-20020a632bcc000000b0040c95b546a4mr37711378pgr.535.1662286770185; Sun, 04 Sep 2022 03:19:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662286770; cv=none; d=google.com; s=arc-20160816; b=JFgQcI5sFHc4lnSu54v6WIOSk6JC6EED73XuH+zndQtr4iyWy2cv8D1J/fLQkOJyDP Sq3K+tm/B/xUepm9UGmiTYcs7r+GpDAUpUbO56MFsyW9iB5eqRjx0cFRcWwKakDI3kB6 G3LqpFRcU1cl9xiQjDVasbUPFpgAbMg9Uams+xFw39wL3tIyB7gjfloY0tD1x7/As4vw BBppnbWTYQclBoPpSAh51AUNQiXgL9OHbRyEzR6hBdh9WF0efvUtbjWNe7oXL3XPOp1+ 8z34eIZb3rZNOhuyVdnSPwxTq0h7RQpd4IHAje802w1gJydiAzOabwBKHRr3hgAXRzGp l3pg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=XigoQqEJ/HD+5+Gb7A/oALBcUUhKhRlE3kUFZVTMYNw=; b=giW+EJLhijOT/FefbnAVGq8i7qtbDnyL/Ux0qL4F+KfOfIQtL2io8w0NaI5BUIPRUr H/gE2QRKO2498HPofzZynvoTZKOneJf2/Tf69aZgDZOwypq5RFBHbFzKKE5MsCos+58E 5ak+aOenPBHzQu8qQJqKUFkxE6peeZOqGX9f9A8+v7KXUavsIdK3SZ/Fykz3DjJO/NOO UX2giC0fs1ht7UqC2ZAaDSCeE6I/h5fm7nvfC8wfp7HXDY/rRDgeTRNa2kJa9U4jDOCo c79bCB7UcoYx3PWqbiAVLBAeVhhgXzIDnfcIR2P0jY7hrk6PcXkOO39OvkTfvQbeu7ik 69iw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r123-20020a632b81000000b0041d3e033ab4si7204365pgr.847.2022.09.04.03.19.18; Sun, 04 Sep 2022 03:19:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233655AbiIDKCb (ORCPT + 99 others); Sun, 4 Sep 2022 06:02:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49114 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232291AbiIDKCX (ORCPT ); Sun, 4 Sep 2022 06:02:23 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A102A40E07 for ; Sun, 4 Sep 2022 03:02:21 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oUmS7-0005cq-FT; Sun, 04 Sep 2022 12:02:07 +0200 Received: from [2a0a:edc0:0:1101:1d::ac] (helo=dude04.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1oUmS4-003qVn-89; Sun, 04 Sep 2022 12:02:06 +0200 Received: from ore by dude04.red.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1oUmS5-00FAJi-1j; Sun, 04 Sep 2022 12:02:05 +0200 From: Oleksij Rempel To: Jonathan Cameron , Lars-Peter Clausen , Rob Herring , Krzysztof Kozlowski Cc: Oleksij Rempel , Andy Shevchenko , kernel@pengutronix.de, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, devicetree@vger.kernel.org Subject: [PATCH v6 3/3] iio: adc: tsc2046: silent spi_device_id warning Date: Sun, 4 Sep 2022 12:02:03 +0200 Message-Id: <20220904100203.3614502-3-o.rempel@pengutronix.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220904100203.3614502-1-o.rempel@pengutronix.de> References: <20220904100203.3614502-1-o.rempel@pengutronix.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Add spi_device_id to silent following kernel runtime warning: "SPI driver tsc2046 has no spi_device_id for ti,tsc2046e-adc". Signed-off-by: Oleksij Rempel Reviewed-by: Andy Shevchenko --- changes v4: - add Reviewed-by: Andy Shevchenko changes v3: - add missing point - remove unneeded blank line - assignment id at the definition line changes v2: - attach actual driver_data - use spi_get_device_id fallback --- drivers/iio/adc/ti-tsc2046.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/drivers/iio/adc/ti-tsc2046.c b/drivers/iio/adc/ti-tsc2046.c index 8d6559303172f..1bbb51a6683c9 100644 --- a/drivers/iio/adc/ti-tsc2046.c +++ b/drivers/iio/adc/ti-tsc2046.c @@ -805,6 +805,11 @@ static int tsc2046_adc_probe(struct spi_device *spi) } dcfg = device_get_match_data(dev); + if (!dcfg) { + const struct spi_device_id *id = spi_get_device_id(spi); + + dcfg = (const struct tsc2046_adc_dcfg *)id->driver_data; + } if (!dcfg) return -EINVAL; @@ -886,11 +891,18 @@ static const struct of_device_id ads7950_of_table[] = { }; MODULE_DEVICE_TABLE(of, ads7950_of_table); +static const struct spi_device_id tsc2046_adc_spi_ids[] = { + { "tsc2046e-adc", (unsigned long)&tsc2046_adc_dcfg_tsc2046e }, + { } +}; +MODULE_DEVICE_TABLE(spi, tsc2046_adc_spi_ids); + static struct spi_driver tsc2046_adc_driver = { .driver = { .name = "tsc2046", .of_match_table = ads7950_of_table, }, + .id_table = tsc2046_adc_spi_ids, .probe = tsc2046_adc_probe, }; module_spi_driver(tsc2046_adc_driver); -- 2.30.2