Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <83184fe9-d2a1-8488-65fa-3735b3359bca@intel.com>
Date:   Sun, 4 Sep 2022 12:09:05 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.2.0
Subject: Re: [PATCH v5 2/2] ASoC: SOF: Remove strsplit_u32() and
 tokenize_input()
To:     Andy Shevchenko <andy.shevchenko@gmail.com>
CC:     <alsa-devel@alsa-project.org>, <broonie@kernel.org>,
        <tiwai@suse.com>, <perex@perex.cz>,
        <amadeuszx.slawinski@linux.intel.com>,
        <pierre-louis.bossart@linux.intel.com>, <hdegoede@redhat.com>,
        <lgirdwood@gmail.com>, <kai.vehmanen@linux.intel.com>,
        <peter.ujfalusi@linux.intel.com>,
        <ranjani.sridharan@linux.intel.com>,
        <yung-chuan.liao@linux.intel.com>, <willy@infradead.org>,
        <linux-kernel@vger.kernel.org>, <andy@kernel.org>,
        <intel-poland@eclists.intel.com>
References: <20220902133256.789165-1-cezary.rojewski@intel.com>
 <20220902133256.789165-3-cezary.rojewski@intel.com>
 <YxISRG13SGScC5Fn@smile.fi.intel.com>
Content-Language: en-US
From:   Cezary Rojewski <cezary.rojewski@intel.com>
In-Reply-To: <YxISRG13SGScC5Fn@smile.fi.intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MDBHa2J3ZStTajFIZ2o5MWpZbS9wdFNoVU1qRUY4cC83VmRkZmh4UmZvMHJP?=
 =?utf-8?B?OXlsbnNoMGZ2QW9sa2FpaXBkUTNWeGxoV2t5WGlpdElhSGpIbm9TZ3Z5MURi?=
 =?utf-8?B?cG15SzF5VjdhMmVyWkdkSjhwMXRBb0RGSnFFZ1NqZkRxdkFWdis3emJqTHEz?=
 =?utf-8?B?ZmJBRHlWaHNiNk1ZdzBzUkFZdlg0RzZSYVBYUmN6aWVKMHB6TkRaRUVZc0Jw?=
 =?utf-8?B?S2VmZWhMMUxPWFJQcHJaMU0vaWxSWWxEd1F1S0FOOEp1WGNQaDBxK1ZiTFB5?=
 =?utf-8?B?K2NRbkVsRE9QL0xSQXBScWFFbmpVZFhVV2dTVVlxd1cxNFowb1d0SFNyVWZq?=
 =?utf-8?B?VGZldVhjdllFQnJCM0FmVmU5bUoyTStlWWphcDBkZGhVNVpDMU5MbHVCUkRx?=
 =?utf-8?B?Smw2eVZtK1BvckZ6K1BOOVRDYlFHaWpoMGJKMlQrUHJ2MSttZjhJQlhhZ1dB?=
 =?utf-8?B?VWUra29XK2p5WGwzQnM0UkpxV2NzS0xxUnF2TWhuc3dkc2JmWGRkV0JUSnVs?=
 =?utf-8?B?Y05XWVpnNWpPVHVRZHZla1EvZU9Vc2NrUlZtU0M3WE4vVGtiUy9XdnVENW4y?=
 =?utf-8?B?T3E3aHZxWlV5QTdqbHo5cnJxRzNpU2hRSjQrVndFRGV3ckV2VXFnaTZYd1VM?=
 =?utf-8?B?RmFxcGkxYjRzWVY5NkFuVllIelJFZU9Yd3lxTDYvdGNpc2cxTlpscSsyMVZ1?=
 =?utf-8?B?Q0p1TW9LMUhyOXZuYkxtUVlya1BPQ0ZJMGpQSFd5bjhncG9mUGkxanhRbVlX?=
 =?utf-8?B?VHc3RmNhbm9VeHA4aXd3NDlYRDhSNXVOa1VaZ2QrUkpzenM1dzlCUTJzTG4w?=
 =?utf-8?B?TlorUmk3SzRHSjdIWWpZYTl2U3A5TXpZMDlMSVJ4My9JdnFubTNWZ2d6a09P?=
 =?utf-8?B?a3I1d1d5SERmUlVPZlpyZEUyL2lnVHMrRUNhN3ptRGU5ODg2dDFzRjlITk41?=
 =?utf-8?B?V0NtRXRjUWRBRmJLYVh0a092a000cFg0bUs4eGp5OWM5NE9KSWtSN2xrM0JP?=
 =?utf-8?B?M2pOYkY4TStIQUFJS2xaWnMzTTZJMnEvU1hMb2xLZnU5VzBLWXh5N1o4N2tC?=
 =?utf-8?B?UEJPZExkbkFTZytkaEJlMFJLa2pwTU4vNHQxaXZyaTFVQlJhZDREMFdQOWhS?=
 =?utf-8?B?eXNRMk1PRU45SzRod0ZNOERFWFJnUjNNNDhkalh6dFlpMGhkNVJudUxqVVJi?=
 =?utf-8?B?NXNwbXBpRDRyRDRjU1Y4ajdKcnpwYTJndllVclE5ZTV5K3pNNGZNbjQ2Wjhn?=
 =?utf-8?B?MlA3UjVkaGJNNi93YmdNRFA3MjhVQUV2ZXVNQkh5TnYrQ3V6M3ZYT09sNFRn?=
 =?utf-8?B?U1J1RkN2Q2hqSTB0WjBqeGdOcm5NM2pDV1lDMDVrdUZjZW1DNnUyaW9DYS9h?=
 =?utf-8?B?eUlMeVdrbVlYOFZxV21WVW4yZExjaUZ6U1NCS1ZnZ0I1N1pIeFdjOWhiNVdK?=
 =?utf-8?B?Q0FMbVgrNGR5RmRkeU10V0tEa3VWNEkxS2hYelRtRnROUkxhcEdVNHpQOWt3?=
 =?utf-8?B?MzFXaDk4TUU2SGZQcG1sYlRLek9zYVVUZU5DdHMwNXMzWm9heCtqZ2c0T0Yv?=
 =?utf-8?B?anR0b1lLNE5vYmlnNkJnTGVJc2d4RklHdG9iUHhvMFppYmxnUlA1Vy9NWmxJ?=
 =?utf-8?B?VWkzN3FidmV4QWs1YWVXQXlyOTB0SEZZeEdKVGZtRGpvR25kODZlSzg5anBN?=
 =?utf-8?B?c1pwL1ErcWJ2LzhRblBsYVdUaGFYcFlFaER2dERJS1o5UWJveXFBckU0c1hs?=
 =?utf-8?B?K01CcEFkMHk3T0swQ29hbjNKQ2NFeVNJK3Z4Y3Q2WS9sMXUxK1VVRWRpRVJ0?=
 =?utf-8?B?MHdQTGJmdktFNGU0clhLS21BU3NQclBWZ0pnVU82L1BxL09VMVZ3L21Meld5?=
 =?utf-8?B?S251VVlVbmVGenNvTmpQQk1hYjBKS2R4REwzUGt1aTduQmpkYXZxSnkzdDZ5?=
 =?utf-8?B?MkhieHlGUXpYTmxHOVVTdE1xdXN2TERlQzU3a29seTFFalJzRkVtUEwxSjFo?=
 =?utf-8?B?YTBKaVdZc2VCbVdSVDhyd0g4ZGZzQXJRcGFnajJCM0tmWFJwMmhMb1JYYVhp?=
 =?utf-8?B?RTNFN2kyNUJXcVFZeWNsRnZhSVZ3UW1OZmw2M1I5dlJqRE5nUGFTSDB0YVg1?=
 =?utf-8?B?SEtrTXFiekU4dTBFQUxHS2hrZ3pCY0xhN1Q2aktnUWh3VmJCQWF6K2o3cXlu?=
 =?utf-8?B?V0E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: c374b986-f43d-4b2d-d02a-08da8e5d85a4
X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB6375.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Sep 2022 10:09:15.4275
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Wlk1ocr9voE3UpkCyhuvXnVAfi1dnPrD6f+jgME49tpHsivxjpVVpgCkgopLIYzQFFEX97zLvKvgpAsX+qv5NdesfewP9GOsZI0oEKHb5IA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3526
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2022-09-02 4:25 PM, Andy Shevchenko wrote:
> On Fri, Sep 02, 2022 at 03:32:56PM +0200, Cezary Rojewski wrote:
>> Make use of global integer-array parsing helper instead of the internal
>> one as both serve same purpose. With that, both strsplit_u32() and
>> tokenize_input() become unused so remove them.
> 
> More minor comments...
...

>> +	ret = parse_int_array_user(from, count, (int **)&array);
>>   	if (ret < 0)
>>   		return ret;
> 
>> +	num_elems = *array;
>> +	bytes = sizeof(*array) * num_elems;
>> +	if (!num_elems || (bytes % sizeof(*desc))) {
> 
> !num_elems is a dup since previous already does this check.


>> +	ret = parse_int_array_user(from, count, (int **)&array);
>>   	if (ret < 0)
>>   		return ret;
>> +
>> +	num_elems = *array;
> 
>> +	if (!num_elems) {
>>   		ret = -EINVAL;
>>   		goto exit;
>>   	}
> 
> Ditto.

Ack for both.