Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220831054017.382749-1-liyupeng@zbhlos.com>
In-Reply-To: <20220831054017.382749-1-liyupeng@zbhlos.com>
From:   Huacai Chen <chenhuacai@kernel.org>
Date:   Sun, 4 Sep 2022 20:12:01 +0800
Message-ID: <CAAhV-H6p44E8KuQZz31jX+Yd0qgvqGRaR2vfwdTZLBxg6bKeFQ@mail.gmail.com>
Subject: Re: [PATCH 1/1] LoongArch: Fixed arch_remove_memory undefined build error.
To:     Yupeng Li <liyupeng@zbhlos.com>
Cc:     WANG Xuerui <kernel@xen0n.name>,
        Jiaxun Yang <jiaxun.yang@flygoat.com>,
        loongarch@lists.linux.dev, LKML <linux-kernel@vger.kernel.org>,
        Caicai <caizp2008@163.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Applied to loongarch-fixes, thanks.

Huacai

On Wed, Aug 31, 2022 at 1:49 PM Yupeng Li <liyupeng@zbhlos.com> wrote:
>
> The kernel build error when unslected CONFIG_MEMORY_HOTREMOVE, the
> arch_remove_memory in mm/memory_hotplug.c was undefined.
> Removed CONFIG_MEMORY_HOTREMOVE requirement refer to the definitions
> of other platform architectures.Some build error messages like:
>
>  LD      vmlinux.o
>  MODPOST vmlinux.symvers
>  MODINFO modules.builtin.modinfo
>  GEN     modules.builtin
>  LD      .tmp_vmlinux.kallsyms1
> loongarch64-linux-gnu-ld: mm/memory_hotplug.o: in function `.L242':
> memory_hotplug.c:(.ref.text+0x930): undefined reference to `arch_remove_m=
emory'
> make: *** [Makefile:1169=EF=BC=9Avmlinux] =E9=94=99=E8=AF=AF 1
>
> Signed-off-by: Yupeng Li <liyupeng@zbhlos.com>
> Signed-off-by: Caicai <caizp2008@163.com>
> ---
>  arch/loongarch/mm/init.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/arch/loongarch/mm/init.c b/arch/loongarch/mm/init.c
> index 7094a68c9b83..191ed8e47895 100644
> --- a/arch/loongarch/mm/init.c
> +++ b/arch/loongarch/mm/init.c
> @@ -142,7 +142,6 @@ int memory_add_physaddr_to_nid(u64 start)
>  EXPORT_SYMBOL_GPL(memory_add_physaddr_to_nid);
>  #endif
>
> -#ifdef CONFIG_MEMORY_HOTREMOVE
>  void arch_remove_memory(u64 start, u64 size, struct vmem_altmap *altmap)
>  {
>         unsigned long start_pfn =3D start >> PAGE_SHIFT;
> @@ -155,7 +154,6 @@ void arch_remove_memory(u64 start, u64 size, struct v=
mem_altmap *altmap)
>         __remove_pages(start_pfn, nr_pages, altmap);
>  }
>  #endif
> -#endif
>
>  /*
>   * Align swapper_pg_dir in to 64K, allows its address to be loaded
> --
> 2.34.1
>
>