Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <5112955e-3f1a-be3f-a07d-afd0923ac26a@amd.com>
Date:   Sun, 4 Sep 2022 16:13:18 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH] amd: amdgpu: fix coding style issue
Content-Language: en-US
To:     Jingyu Wang <jingyuwang_vip@163.com>, alexander.deucher@amd.com,
        Xinhui.Pan@amd.com, airlied@linux.ie, daniel@ffwll.ch,
        Felix.Kuehling@amd.com
Cc:     amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
References: <20220904092625.1007393-1-jingyuwang_vip@163.com>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
In-Reply-To: <20220904092625.1007393-1-jingyuwang_vip@163.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d1B4S01OeG5ncmlkajhPbEEycWhMa1hBWWVXZ2Q5NHZ5bnJpVzl0RXd6b3o5?=
 =?utf-8?B?MXJvZVhUek5JK2plaFc1ZElYRXVaOEdYV1FkS3NnWGVkakwzS1o5MFZmR3Bk?=
 =?utf-8?B?WnA0emRrT1NKb3BkQWM5M0lSd1QwWjlzQzE0d3lOZXVMNmZCdit6TURUNENE?=
 =?utf-8?B?UC9pZmdFZjQ0amJvN09LaWdLRWQ2OW90Y21LdS9oMjQ5eWFFZGJVa0tCZkdE?=
 =?utf-8?B?eG9BRXhkbmUwU1BxNTgwbmVIZXlXZFVDc3NmTUlyR1U4bklBNlpSRlNFRTNG?=
 =?utf-8?B?cE9heVlHa0hLbHJLMlAxUHRCV3F2eUVHVldaZzNRUlVhdnhISnJValN1bWZH?=
 =?utf-8?B?SkFxaGRHV0lrNEp2SVZnNjJIWXBxaWpZdkp1blBsWXIrT0V3ZG4ra1A2MEVi?=
 =?utf-8?B?aGxnc2tiY05keG1CTU42THVXMGl5VStJWThPeHZCT1VPdEYwYzZoKy9yT3Uw?=
 =?utf-8?B?aHEyLzdLZGVlNDNjeVlNRHZpa2xLMTh2dUhXRi9UYzk1QW9NWFBhQlhqREdN?=
 =?utf-8?B?amtLS3V5MVBZMTJZdjFGMHRUV2pKVldwWDlROG8zcWZtVEJLNWx0bm5kK2Z0?=
 =?utf-8?B?SjI4d3FaODlEYXBYY0ZJaDliK0dDeTNOUGM5d0VsR2ozWXRqa1BFYXRJRDdR?=
 =?utf-8?B?U0c5eTVjcVp1dDhNMk84dmp4SHQxRlh2L1c5a0o2bGFGcVdOeXZ6cGlqd0xQ?=
 =?utf-8?B?eFhMVCtJNUR2bFBQdkw2VU5tZFA3NDkyNG1wd0RXLzBsOGV0cWs5S1luQlpW?=
 =?utf-8?B?bmN6QVBpbnhjcUNIZWtZRktBN2V4cHJoZGsvUVAzSlAyOWw4enpodC9MSEVE?=
 =?utf-8?B?T1JrR1lrNThrQ0xlQnRQbExjYitMYUZ5aGtQWGdEcFlKaGt6UlFURlRqRklR?=
 =?utf-8?B?ZGV1c2lVMW5OZ01oaEZ2N0RwbS9RaGUrN3lVQ0FUeWVvRFNnRGpqUjJQcmZY?=
 =?utf-8?B?dmtuWDVCNHZrNm9jajNvNG5VdHlMQTBHckVsamVHbUdDV1hiMlQ5SmI3Z1Yz?=
 =?utf-8?B?QTIzdEpLbUpEZlpFck1HdUpIeCs0MTNkanVNdDhOd0ROMnF5cm1FRGtVS2dC?=
 =?utf-8?B?azF0NEwwRkNaTjFDMXFMV1FtZU1QenJVOHlsa1o0REVINTRyTEo4cEJuaWQ3?=
 =?utf-8?B?cFFJeDZzY251dmNUQ2VRQzFtakQzQm04eCtjS1RzcVpjb25CVVFLYm5RY0tz?=
 =?utf-8?B?N01YZTd5K0I3bTJLRlJMM2swWDNnQXhzUVR0TDlZSkpqYlE4UGtGUnZtdXlN?=
 =?utf-8?B?T1R4MjRiQmZUTFE4N3NZYUk2ek0rU0E1Vng3SHpFM0NGRTVTMnRRd2RsNmIy?=
 =?utf-8?B?T2ZWWGJESHJtN24wWUQ5SThOUHlhb0pCcUwvZ2k4NStSV1FweVkwUUpPTlRQ?=
 =?utf-8?B?MkdSaldEWGJpbUVQSklrQmJxcCtLV2l2bStPdWgwSjI3Qys2WWpTYTNpN0tG?=
 =?utf-8?B?TGpvNnRMREl5YjFhOVZIaEJpNGlTM2wrK21mU09TZjNGT2ZvNC9TZGRMVEw4?=
 =?utf-8?B?OFBRUDhLWFk3UmQzVEZRN2I3ZXhTeEp1aDc1RThjQnJLYWkwSllVV0VRL0Er?=
 =?utf-8?B?bjMvZWNCYkZIdktiQ1FKMzlxUmZhdXhueHhqcklJQ0xpNk5VclNuT0FMaUcw?=
 =?utf-8?B?ZjFFMmk3RGp5ZnNqQTFmVjF3dGpUSGprTW8zSU9iLzdwU3o5S3Z3anJRbHg1?=
 =?utf-8?B?SEJiZ1dtendEU2duc3BQeTljQnF1UFBKWE0reEhXdzRHdjhRZk1FdlZDMUJy?=
 =?utf-8?B?ZXlVQlR4SEJKRXZ5eHZWSURsV2ZBYTV4YkwvbS9HT29LdFFwK0NtbThraVVL?=
 =?utf-8?B?RStnYXhtckd2ZjNOSmxSSVlMNTE0MDllRSthek9ITHpBWEtZVk5RQUNZWGVM?=
 =?utf-8?B?dm4xWXpiWEl1UkFjU2VsRUo4aG9hMkhja3ZZRThpUXRsaTY3UmdZSnUvaXNw?=
 =?utf-8?B?dU1yUjRVa2JUM29ERitZZWx4dlRSaXZzSVl5b2g1cC9lYVdXSEtaQXFUR2ZD?=
 =?utf-8?B?dThvWHpOK2hLeEIreDk3eUg3eVVMMDRRbzg1aUVmZ3I5eVkya3I3UkcxbllX?=
 =?utf-8?B?dFg1RUZtcFRwQjl0UUFrL2V5UVlxblFGWFI5RlZYL2VYcXNWWFdBQVoybWQ2?=
 =?utf-8?B?RExMRnVIYnI5Q1NFS3F3VkFiYUpxYXNJMjV5UlhOUXNJK0lHTXJyVFpTRVJS?=
 =?utf-8?Q?bTjiDMGQSXUQAJb5/zo75huvqoIXLrtmuIcTCWJ9rGOx?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b348e1f0-086b-4c2f-abcf-08da8e7f9f6a
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3587.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Sep 2022 14:13:21.4780
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: m5xwyyuWbn421fyebF3LYOqwgdPysHxej9EX+T/ZyxhRL00KWR5wwkKSR85Tl4qU
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB7161
X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 04.09.22 um 11:26 schrieb Jingyu Wang:
> This is a patch to the amdgpu_sync.c file that fixes some warnings found by the checkpatch.pl tool
>
> Signed-off-by: Jingyu Wang <jingyuwang_vip@163.com>
> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c | 8 +++++---
>   1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c
> index 504af1b93bfa..dfc787b749b2 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c
> @@ -1,5 +1,6 @@
> -/*
> - * Copyright 2014 Advanced Micro Devices, Inc.
> +// SPDX-License-Identifier: GPL-2.0

This code is under and MIT license.

Christian.

> +
> +/* Copyright 2014 Advanced Micro Devices, Inc.
>    * All Rights Reserved.
>    *
>    * Permission is hereby granted, free of charge, to any person obtaining a
> @@ -315,6 +316,7 @@ struct dma_fence *amdgpu_sync_get_fence(struct amdgpu_sync *sync)
>   	struct hlist_node *tmp;
>   	struct dma_fence *f;
>   	int i;
> +
>   	hash_for_each_safe(sync->fences, i, tmp, e, node) {
>   
>   		f = e->fence;
> @@ -392,7 +394,7 @@ void amdgpu_sync_free(struct amdgpu_sync *sync)
>   {
>   	struct amdgpu_sync_entry *e;
>   	struct hlist_node *tmp;
> -	unsigned i;
> +	unsigned int i;
>   
>   	hash_for_each_safe(sync->fences, i, tmp, e, node) {
>   		hash_del(&e->node);