Received: by 2002:a05:6358:bb9e:b0:b9:5105:a5b4 with SMTP id df30csp2134040rwb; Sun, 4 Sep 2022 09:02:35 -0700 (PDT) X-Google-Smtp-Source: AA6agR4Nv86zHoUmFIJIlaPcTY4ayW1Tw/7D0YqZE69v0ZixtW/HZo0UXEU0e/IlYt3PNQhJrruF X-Received: by 2002:a65:498b:0:b0:412:8e4:2842 with SMTP id r11-20020a65498b000000b0041208e42842mr38560766pgs.71.1662307355304; Sun, 04 Sep 2022 09:02:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662307355; cv=none; d=google.com; s=arc-20160816; b=hU54c4jd5PuVw9MgFh++kwC+ScWNTEhZE8EqK9I1QAo81Qdv1PxSWvqi1luZDtskPp nMBALKhT+cJWdHHlbz6TRqqjI8DkzSdu99SYQ/zJOwwg1mh9uuu37CYx9bfkn/WG/rpg F+q75FI4tpC63hf6Kzf2c8Xbrx8odvdy4WZGlOUB3nPwS49Zz6O8iawSKQdsbqURQuMU xFmhMuyFmYRDFq89R08JKPRT9HoMsHBjB4NtqqR2KqbdQVVQzj29l7u1swKXtTnTTpc7 i4VulFrANaiPA9PMOlVeSmmUiLW7C1diOzMYmu2Fudz611kx2iOAN43jxomEtY8tnRmb +V9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=9oDjlg4CwTLYxH97Yx2Asmmymp3YsPsTNKMoXmvOVjM=; b=im8WI5lqVsCARF7+/GAUnfS9e+prB8FIYyJ3U8ZCOdeOboESNfOZyZyT0iSRrgltje cfA5k9aPToUGqtbnAX8GQ1P5iBftdEoQHpqTajVJZKaZwrd0uIip+18PlVU9zAuUqlno tjdsWNRzOiInPM20XFQ/MWzH2yBiJwx46ooBCOVq8CZlWmaLppL1icFLFlHuKWJW/sSL HA/gcL86Xa/KqBcRXGbMA9P6mvzw2a5SpSxfNuRY8zXkgzpz+80b2f2TeY1/H9QH96UN Uf7oUtTOC36mJbK7t6eI3Cq3haSxBsh8NC1KgVOjqjNxYsbh0xrp+IoL5Ms+ikIyQZrM GgCg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ZmI6XA26; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id bh2-20020a056a02020200b0042c18d35aaesi8621144pgb.63.2022.09.04.09.02.19; Sun, 04 Sep 2022 09:02:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ZmI6XA26; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234228AbiIDPYC (ORCPT + 99 others); Sun, 4 Sep 2022 11:24:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40902 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229600AbiIDPX7 (ORCPT ); Sun, 4 Sep 2022 11:23:59 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D4BB731DD8 for ; Sun, 4 Sep 2022 08:23:58 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 837E3B80D90 for ; Sun, 4 Sep 2022 15:23:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B2C03C433D6; Sun, 4 Sep 2022 15:23:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662305036; bh=IUGYHmtAUfAccRR1FbzpWQzSqcWDUTuXiOiqyYMbwm8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZmI6XA26LGv7twEb1KC8RRUcQw/fkcoY+bq2QO/eg75ajxcW7D3f7ywPUlL0/xuxs Mth5VfJmaE4tuWeXGSGR5odChRumnuzs/AbJSu7nGzMtF9gW3TT6Dy1wzhIaFa+k6E bu/QYOm7qvtjuczNmt0zJehOPw8I0DUdTN4h6+BpNIGiQ+4WWEMsCZsuoK0QK/FweU 1AIV+GzPn+9uXgzcjb1IP7lorrSN5fsJdVGJ6b3I+/f9g07C+Y1B8A0XK1+Ptd1rC8 twFPNRteXX8rWj0nnR+OJ/JDV+7XNE7l5gbV3yosG5hVAgULPsvtbu9aP0BLnt72c1 aFp+94aDauaeQ== Date: Sun, 4 Sep 2022 20:53:50 +0530 From: Vinod Koul To: Peter Geis Cc: Heiko Stuebner , Kishon Vijay Abraham I , Samuel Holland , Markus Reichl , Michael Riesch , linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4] phy: rockchip-inno-usb2: Return zero after otg sync Message-ID: References: <20220902184543.1234835-1-pgwipeout@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220902184543.1234835-1-pgwipeout@gmail.com> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02-09-22, 14:45, Peter Geis wrote: > The otg sync state patch reuses the ret variable, but fails to set it to > zero after use. This leads to a situation when the otg port is in > peripheral mode where the otg phy aborts halfway through setup. It also > fails to account for a failure to register the extcon notifier. Fix this > by using our own variable and skipping otg sync in case of failure. Applied, thanks -- ~Vinod