Received: by 2002:a05:6358:bb9e:b0:b9:5105:a5b4 with SMTP id df30csp2266414rwb; Sun, 4 Sep 2022 11:59:30 -0700 (PDT) X-Google-Smtp-Source: AA6agR6VTrgJpamwBK5K8dXbSQrxAlPBHj0b2Dkb4WdR0iEGDZGpcmjoRg+k5x32iIvpXPsNEbB3 X-Received: by 2002:a17:907:2e0b:b0:730:8aee:d674 with SMTP id ig11-20020a1709072e0b00b007308aeed674mr35090672ejc.104.1662317969913; Sun, 04 Sep 2022 11:59:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662317969; cv=none; d=google.com; s=arc-20160816; b=AAHUlHWDW6gBnIwE6tVR7h5pTjyV8AwjIKCdRxGVplQh4NA8/uvDztYSL6Db3xCNDG 1cRltBVGXuf78KIYlHvXugqp3cdQlOTtTrA8NSpwCpmUCYO3VqorkpNcy+5VUj/PFbXk mvAotpaOtgt75Ov54r2NZl056ghVqwZEE9lhFrQj94Gx/2kmAAnjPTnyDlbz0NMtxrdX OmJrrSDJoQMqCI/H7URwl5nB8cwiZhY088yfqId7fZ3GP8m3HOJarz7YmNdxVyfVXGgQ QQOUVU8PpFtguGud/2r22wVeXlD/7rt1fxZOZSGgs1u5LDLdf7sTpjV9bCvxcg9TD+0K WxCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=+mL64dNEy2QSYFgKV/kza8SqCVHTShC+TRsviPNz8Rw=; b=rJzDxJZdQeRGNIqiPwVKyWpTHQ/bEp2dLPtTTRmCvCPbQRRx4UpD82AujS44qDPZJM sd4ybvQgqARFDX2K55hMPwmtKwlKnYA128S34jMHHt3mIcMVbGavMCXY0CA1mGLBYXp3 a9okG5Ycz+Kd6GfmOdvGJETdGpTZitlpZKRLc6FYSclMmbx6it3m4UHXNNF1efafNpxf PlqQRJDVrxqlpvg0J0e862mG5HuM4lzKuamHf/7h0QdX1e7v2woBGGymWAW69jd4xrGx gEdZU+KrUTzKaaet1nS/Tz9iYSHZ+ghtmPVhGB8ynI0Xe92gOpIpAed4aJtKO9s2hWU1 rhkw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=WRn0kiuf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id gn22-20020a1709070d1600b0073d5b605cefsi7148729ejc.261.2022.09.04.11.59.04; Sun, 04 Sep 2022 11:59:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=WRn0kiuf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234561AbiIDS1X (ORCPT + 99 others); Sun, 4 Sep 2022 14:27:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35806 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231181AbiIDS1W (ORCPT ); Sun, 4 Sep 2022 14:27:22 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 96C0A303F6; Sun, 4 Sep 2022 11:27:21 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2826560FD1; Sun, 4 Sep 2022 18:27:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B2A3EC433D6; Sun, 4 Sep 2022 18:27:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1662316040; bh=NH1DZqWrJIou0gR8/SOQYjSqqNtQPHmi2KpVU7tMcVk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=WRn0kiufLkUeNTeYF9+cX0twvAtTs8Qb4t3gd+meoMl0COWVQAIibeQslpfZkDplS tL8imZI4F4oBjI0pgvfwKjAbR64sq8BAfLVJxVuwZJnlHY5oH14nJb84GL/ME7bJSp LF0A4Qd/xrN3jnuQ6+Zl2M8hJtv6TXJ41oeBYbGw= Date: Sun, 4 Sep 2022 11:27:18 -0700 From: Andrew Morton To: Oleksandr Natalenko Cc: linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, Jonathan Corbet , Alexander Viro , Huang Ying , "Jason A . Donenfeld" , Will Deacon , "Guilherme G . Piccoli" , Laurent Dufour , Stephen Kitt , Rob Herring , Joel Savitz , "Eric W . Biederman" , Kees Cook , Xiaoming Ni , Luis Chamberlain , Renaud =?ISO-8859-1?Q?M=E9trich?= , Oleg Nesterov , Grzegorz Halat , Qi Guo Subject: Re: [PATCH] core_pattern: add CPU specifier Message-Id: <20220904112718.b7feead47012600ef255dfdf@linux-foundation.org> In-Reply-To: <20220903064330.20772-1-oleksandr@redhat.com> References: <20220903064330.20772-1-oleksandr@redhat.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-8.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 3 Sep 2022 08:43:30 +0200 Oleksandr Natalenko wrote: > Statistically, in a large deployment regular segfaults may indicate a CPU issue. > > Currently, it is not possible to find out what CPU the segfault happened on. > There are at least two attempts to improve segfault logging with this regard, > but they do not help in case the logs rotate. > > Hence, lets make sure it is possible to permanently record a CPU > the task ran on using a new core_pattern specifier. > > ... > > } > @@ -535,6 +539,7 @@ void do_coredump(const kernel_siginfo_t *siginfo) > */ > .mm_flags = mm->flags, > .vma_meta = NULL, > + .cpu = raw_smp_processor_id(), > }; Why use the "raw_" function here?