Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a32e4a83-7edb-db61-635a-47b4d16fd7cf@intel.com>
Date:   Sun, 4 Sep 2022 15:26:45 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.12.0
Subject: Re: [PATCH v7 11/15] mei: gsc: setup gsc extended operational memory
Content-Language: en-US
To:     "Usyskin, Alexander" <alexander.usyskin@intel.com>,
        "Winkler, Tomas" <tomas.winkler@intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>
CC:     Jani Nikula <jani.nikula@linux.intel.com>,
        Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
        "Vivi, Rodrigo" <rodrigo.vivi@intel.com>,
        Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
        "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Lubart, Vitaly" <vitaly.lubart@intel.com>
References: <20220806122636.43068-1-tomas.winkler@intel.com>
 <20220806122636.43068-12-tomas.winkler@intel.com>
 <e2296121-1f99-5bd2-2a80-a24b029bf4f3@intel.com>
 <CY5PR11MB63661B40A4D331A6A7E59749ED7C9@CY5PR11MB6366.namprd11.prod.outlook.com>
From:   "Ceraolo Spurio, Daniele" <daniele.ceraolospurio@intel.com>
In-Reply-To: <CY5PR11MB63661B40A4D331A6A7E59749ED7C9@CY5PR11MB6366.namprd11.prod.outlook.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q3d6T083K3kxZUZGSFcrLzU2TjRGYldNUUdicWlUdTUzSmlDajJMalIvanRx?=
 =?utf-8?B?eEdQTkc1UkV5bTg0anViTTlKSGVSWUpnWG9INm5TQVNYLy9mTUFVZG0xL1hD?=
 =?utf-8?B?Rmw4SFB2WENhR0hCQng1RU16ay85K09SQzlwK3R3ODJrNVU0MzRxVS9mUVI2?=
 =?utf-8?B?QTZaNWFrYUFNZEgvZHZHVVdBYWFZWFBrRGEwTkxQWUlZQnRTWmk0UDNaaWJj?=
 =?utf-8?B?Q3hKR0VycFFRTklqeGJIbWhOOVlZdWY5cnlWeFJMWDAwUjRxVkd4RkYrYW9N?=
 =?utf-8?B?Nm92bUJuM3ZaZTk3LzQ3NnQ1VWJTTjNGcFpOR1RvR1RmTEhnNzVVU1JxZnVt?=
 =?utf-8?B?QkpDR2tkT1RwaEVKblRxNUxGNitsaVdZdlNPRml6TzEyZzFsN01SRHpkWlgw?=
 =?utf-8?B?QzhWVUFXZDR0M3Q1V2g2VzQyeGU2S3lVNEpHNytPNStTWnc4dHlnUG5tVWxL?=
 =?utf-8?B?ZVpYODNhcUZJNW9SYjF6UTBiU2dvSFFSMFVTeTZMelpNaW8wazlPT0RTaC95?=
 =?utf-8?B?cTl6SUt5NG93cmZSL3J5a2tYSU44NXNNRTZZcFg0Q1dWUWxQRFE2Ymc2ZXVu?=
 =?utf-8?B?eTVBQkw1MlQ5cXZiQkwyK2N6VThFQncreEZINDlud2JhdEpjT3UvL3luQi9n?=
 =?utf-8?B?MTdkQkJVMkY4M0QrWURMaXRwdkh5YjVIMTYvNnZCM3NjaDc5OTk0NlRyUW4v?=
 =?utf-8?B?TDd3UDBCUUN5RTNqSmROaHpzTUcwdGQxYjEwZm14ejNXZFhHa3h6bFZIU3o1?=
 =?utf-8?B?ZjduNjc1UnZ4QTIvVU9laS9LSzNlcTB1ZkxCWkFEaCtiRElzN3JwOUNBaXVp?=
 =?utf-8?B?anBwYXhFMlZXNEVFbVBUanNTVnRoTlJIZWlnRGtKY01mcngyNE5CN2xIbnRK?=
 =?utf-8?B?VGtDRkdxdFFFTURONTRnazZrTGNNdjMvQVJrZDNndGpuUHoxcEVibDRYYjJk?=
 =?utf-8?B?SGVJTEdlV1RreWVGQ0lXa3RXOFZzbkFmaTV5cVlIeDNERVZhdlpuUGtNUnB4?=
 =?utf-8?B?Si9FTkZvVlRRbm9iZjE3VEZtQkM1Nkc0dWlvT2JOcUEyVlpMeVFKd1RVVFhn?=
 =?utf-8?B?NmtzVWY1TkFPMFdIOU9keERlaTUyTk9HblBQY241aEIxMHBFeVlTWklVMjVE?=
 =?utf-8?B?ZmNINjBNMktNSnBHMjFQanBURjNyNXplalQ3WkxyaWR0bzNGR2ZmWTQwL01E?=
 =?utf-8?B?a2N2RTVzajMwdEp0VXR3Z2hNM2NRcWRQUkVuVGhkVi9GLzZ4OTArbUd0WUox?=
 =?utf-8?B?dHJUS283OSswMkx4NmxVOU8zdzdSYXlYMWZUc2pkY1BMTDhYYk5mN1Mzb0dO?=
 =?utf-8?B?RWg1Y3lVNHQvalp5QWlIRHZxWW5jRUJDb1FRd3lGRU5rOXJYb3hqMmdzbm85?=
 =?utf-8?B?VXBUUlJudEZNQ3lXWTFUcFRVLytyQWxJUFBnbzhSelJHRThRRVNoTUs3RWVa?=
 =?utf-8?B?WmFub2hlTXFkSkNLak9PQUltZGNEdDFOMXhaNDViL2tDc0gwZ1pxUzQ3Q3B0?=
 =?utf-8?B?bFV5M1VPRW95eXZTU25QWnJJQ2tBY0RTRGdiS0JaMVZsZUZ1alR4TlQwVHJX?=
 =?utf-8?B?ekMzaVpnakpGUmhRZ09JYkRCUElBV3dpQm9wU1c3MVhVQXo1RWZGRHBUUmo2?=
 =?utf-8?B?aHVsSERiZi9HcmN3TU1vUnRrSmt6SVdFVDFtb1NxdmtOeTNQTzFUNXphTWRh?=
 =?utf-8?B?YUV4OXh6eExnbTg0L2pINGRiNDJHdk1DSXRXODhQdm5qelcxVER5d3BEdFVC?=
 =?utf-8?B?TGhFTDNDOFdzVzVjZGxaV2JUUXcxMWdRRjd5RGlSWnJiUTlaZ2VHNmYwOW1k?=
 =?utf-8?B?VE5HcSt4ZE5jNVUybzVGTnkzdkNHcTJON1Q1c2NhRlZMS3MzNmdlMnRCcTJo?=
 =?utf-8?B?U3dOOGpmNHdtVTVYc0tMSVhXdU44UFRjOHI0UTk1VmkvTjJvbG14R2w3R3dB?=
 =?utf-8?B?eGV3bUVqYWFJYkd5a1BmTnZQdWJETjZLc1pSUjk0WHpTLzNMMlRPbnhzZUM0?=
 =?utf-8?B?NHJnUSs1Wk12d2dTUVZpbVhxUDQ0dTdJeDdCVEFRYVorY0JtcWhBU3hKazRP?=
 =?utf-8?B?Sm5teUpEbmdlME53YnRsNGh4Y1YrYXpheWUwWWVVUUROZW1QeWdPd3FYalhv?=
 =?utf-8?B?amRDQjVTcE1Da25yOEVvVm05N0gxUmtDdFpwTkk0T2NBVExnZExtbXpRSG9O?=
 =?utf-8?B?RVE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 82fb6c50-4881-4a84-f628-08da8ec48f01
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5488.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Sep 2022 22:26:49.2069
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: LJtX0TVwvIYqGHZ7fapmci/cFQf8NAZZCoRRA6ChTJkKSgnif7Rpr/AmMBkh8pxydy5JfDgD8X2j/BMtkKYdg+d7SfXUjW8QVGf77JUIaGA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4249
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 9/4/2022 12:29 AM, Usyskin, Alexander wrote:
>>> +static void pxp_is_ready(struct mei_cl_device *cldev)
>>> +{
>>> +	struct mei_device *bus = cldev->bus;
>>> +
>>> +	switch (bus->pxp_mode) {
>>> +	case MEI_DEV_PXP_READY:
>>> +	case MEI_DEV_PXP_DEFAULT:
>>> +		cldev->do_match = 1;
>> Can you explain why you set do_match = 1 with MEI_DEV_PXP_DEFAULT ?
>> AFAIU MEI_DEV_PXP_DEFAULT means that we haven't even started to
>> initialize PXP, so it seems weird to match in that scenario.
>>
>> Apart from this, the patch LGTM.
>>
>> Daniele
> MEI_DEV_PXP_DEFAULT is a state for the legacy PXP solution that uses the same firmware client
> and have no need in special initialization.

makes sense. Could use a comment, but anyway:

Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>

Daniele

>