Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 5 Sep 2022 08:46:39 +0800
From:   Shawn Guo <shawnguo@kernel.org>
To:     Li Yang <leoyang.li@nxp.com>
Cc:     devicetree@vger.kernel.org, robh+dt@kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        Pankaj Bansal <pankaj.bansal@nxp.com>,
        Sandeep Malik <sandeep.malik@nxp.com>,
        Priyanka Jain <priyanka.jain@nxp.com>
Subject: Re: [PATCH v3 5/5] arm64: dts: ls208x: remove NXP Erratum A008585
 from LS2088A.
Message-ID: <20220905004639.GM1728671@dragon>
References: <20220823234913.30325-1-leoyang.li@nxp.com>
 <20220823234913.30325-6-leoyang.li@nxp.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220823234913.30325-6-leoyang.li@nxp.com>
Precedence: bulk

On Tue, Aug 23, 2022 at 06:49:13PM -0500, Li Yang wrote:
> From: Pankaj Bansal <pankaj.bansal@nxp.com>
> 
> NXP Erratum A008585 affects A57 core cluster used in LS2085 rev1.
> However this problem has been fixed in A72 core cluster used in LS2088.
> Therefore remove the erratum from LS2088A. Keeping it only in LS2085.
> 
> Signed-off-by: Pankaj Bansal <pankaj.bansal@nxp.com>
> Reviewed-by: Sandeep Malik <sandeep.malik@nxp.com>
> Acked-by: Priyanka Jain <priyanka.jain@nxp.com>

Missing your SoB.

Shawn

> ---
>  arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi | 4 ++++
>  arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi | 3 +--
>  2 files changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi
> index 6f6667b70028..a2cadf757148 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi
> @@ -150,3 +150,7 @@ &pcie4 {
>  	ranges = <0x81000000 0x0 0x00000000 0x16 0x00010000 0x0 0x00010000   /* downstream I/O */
>  		  0x82000000 0x0 0x40000000 0x16 0x40000000 0x0 0x40000000>; /* non-prefetchable memory */
>  };
> +
> +&timer {
> +	fsl,erratum-a008585;
> +};
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi
> index d76f1c42f3fa..f1b9cc8714dc 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi
> @@ -239,13 +239,12 @@ map0 {
>  		};
>  	};
>  
> -	timer {
> +	timer: timer {
>  		compatible = "arm,armv8-timer";
>  		interrupts = <1 13 4>, /* Physical Secure PPI, active-low */
>  			     <1 14 4>, /* Physical Non-Secure PPI, active-low */
>  			     <1 11 4>, /* Virtual PPI, active-low */
>  			     <1 10 4>; /* Hypervisor PPI, active-low */
> -		fsl,erratum-a008585;
>  	};
>  
>  	pmu {
> -- 
> 2.37.1
>