Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 5 Sep 2022 09:06:42 +0800
From:   Shawn Guo <shawnguo@kernel.org>
To:     Li Yang <leoyang.li@nxp.com>
Cc:     devicetree@vger.kernel.org, robh+dt@kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        Zhang Ying <ying.zhang22455@nxp.com>
Subject: Re: [PATCH 08/11] arm64: dts: ls1043a: add gpio based i2c recovery
 information
Message-ID: <20220905010642.GP1728671@dragon>
References: <20220824223700.32442-1-leoyang.li@nxp.com>
 <20220824223700.32442-9-leoyang.li@nxp.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220824223700.32442-9-leoyang.li@nxp.com>
Precedence: bulk

On Wed, Aug 24, 2022 at 05:36:59PM -0500, Li Yang wrote:
> Add scl-gpios property for i2c recovery and add SoC specific compatible
> string for SoC specific fixup.
> 
> Signed-off-by: Zhang Ying <ying.zhang22455@nxp.com>
> Signed-off-by: Li Yang <leoyang.li@nxp.com>
> ---
>  arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi | 11 +++++++----
>  1 file changed, 7 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
> index b37244acf16a..20888aceb5f4 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
> @@ -538,7 +538,7 @@ dspi1: spi@2110000 {
>  		};
>  
>  		i2c0: i2c@2180000 {
> -			compatible = "fsl,vf610-i2c";
> +			compatible = "fsl,ls1043a-i2c", "fsl,vf610-i2c";
>  			#address-cells = <1>;
>  			#size-cells = <0>;
>  			reg = <0x0 0x2180000 0x0 0x10000>;
> @@ -553,7 +553,7 @@ i2c0: i2c@2180000 {
>  		};
>  
>  		i2c1: i2c@2190000 {
> -			compatible = "fsl,vf610-i2c";
> +			compatible = "fsl,ls1043a-i2c", "fsl,vf610-i2c";
>  			#address-cells = <1>;
>  			#size-cells = <0>;
>  			reg = <0x0 0x2190000 0x0 0x10000>;
> @@ -561,11 +561,12 @@ i2c1: i2c@2190000 {
>  			clock-names = "i2c";
>  			clocks = <&clockgen QORIQ_CLK_PLATFORM_PLL
>  					    QORIQ_CLK_PLL_DIV(1)>;
> +			scl-gpios = <&gpio4 2 0>;

Could you use the polarity define from include/dt-bindings/gpio/gpio.h?

Shawn

>  			status = "disabled";
>  		};
>  
>  		i2c2: i2c@21a0000 {
> -			compatible = "fsl,vf610-i2c";
> +			compatible = "fsl,ls1043a-i2c", "fsl,vf610-i2c";
>  			#address-cells = <1>;
>  			#size-cells = <0>;
>  			reg = <0x0 0x21a0000 0x0 0x10000>;
> @@ -573,11 +574,12 @@ i2c2: i2c@21a0000 {
>  			clock-names = "i2c";
>  			clocks = <&clockgen QORIQ_CLK_PLATFORM_PLL
>  					    QORIQ_CLK_PLL_DIV(1)>;
> +			scl-gpios = <&gpio4 10 0>;
>  			status = "disabled";
>  		};
>  
>  		i2c3: i2c@21b0000 {
> -			compatible = "fsl,vf610-i2c";
> +			compatible = "fsl,ls1043a-i2c", "fsl,vf610-i2c";
>  			#address-cells = <1>;
>  			#size-cells = <0>;
>  			reg = <0x0 0x21b0000 0x0 0x10000>;
> @@ -585,6 +587,7 @@ i2c3: i2c@21b0000 {
>  			clock-names = "i2c";
>  			clocks = <&clockgen QORIQ_CLK_PLATFORM_PLL
>  					    QORIQ_CLK_PLL_DIV(1)>;
> +			scl-gpios = <&gpio4 12 0>;
>  			status = "disabled";
>  		};
>  
> -- 
> 2.37.1
>