Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Bernard Zhao <bernard@vivo.com>
To:     Johannes Weiner <hannes@cmpxchg.org>,
        Suren Baghdasaryan <surenb@google.com>,
        Ingo Molnar <mingo@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Juri Lelli <juri.lelli@redhat.com>,
        Vincent Guittot <vincent.guittot@linaro.org>,
        Dietmar Eggemann <dietmar.eggemann@arm.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
        Daniel Bristot de Oliveira <bristot@redhat.com>,
        Valentin Schneider <vschneid@redhat.com>,
        linux-kernel@vger.kernel.org
Cc:     zhaojunkui2008@126.com, Bernard Zhao <bernard@vivo.com>
Subject: [PATCH] kernel/sched: fix KMSAN uninit-value error
Date:   Sun,  4 Sep 2022 19:37:14 -0700
Message-Id: <20220905023715.1920088-1-bernard@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?vSiuBfUwPtJ79lVnNmnkgK/7tELx2xaI7y097tW29RLk+1hy2jGDs+bLhcWA?=
 =?us-ascii?Q?9EH2NHP4inUZe7/r61G/P07bLsgihVHRH+oBYgOBgcgjtFftLY2GzwsWv/qN?=
 =?us-ascii?Q?PtxcG1S+qIJ6TCt96ql74k59Pemh0H0K3EX2K2rcLILHNhyV29rnBzL+9m13?=
 =?us-ascii?Q?asWk5ORZAYRlx1Z0ddvwxdP9E8MSWrnbguQ7WgffQQ1xVhk0ZTpfGP8NROJk?=
 =?us-ascii?Q?5pCuiEEH7XeM5huf+CGb/yoZ+9PFkwhu8NCXzm8NbzXSPEgo942FdIkLLXt0?=
 =?us-ascii?Q?oZ66M+Ye6436olhILHMJ4KqFqIoN1xT2Z4MOvW1vMxqFn44pX04+zT1+0jLN?=
 =?us-ascii?Q?a1GH+Z5ekFvRpqsXDv03UfsKV1w8Dzd7CFiIumTL0Bl3K5e9ZH5No52mgEI/?=
 =?us-ascii?Q?cfwhwFrZTBIgJqDibD2YX5xcb/qHQQ2HaTiaVkuF1EVSi7BbzAOuzk/9dGq6?=
 =?us-ascii?Q?Z+4cAhgYty8BQl+X8NFEZMidw0C7iI8A1EFIdyTWGHD7Vr1qcw34+tWBgOtb?=
 =?us-ascii?Q?O1nfL/9XgnDBYrSvzDl/cWlkesNOdpam+dUqEHK/A6fzzY6rUE4vknUQ2k1M?=
 =?us-ascii?Q?2AfrmnmhESLF0c5BDdIHiAizz8sEfF5lcrqoljFOgmDMXkQ6G9lU1vgV8ct8?=
 =?us-ascii?Q?y/OGhYlP5gux9c/AYAeJNqUE9y2JO/LIXqwkMAOSDM+995ozyTObfI+ocuYY?=
 =?us-ascii?Q?xtFbdgVntQ8v7pIwx8SkVudQFTAXxzilA9c6yZKPMSjQzpimA373zcLAhVxa?=
 =?us-ascii?Q?UEO5Il6hChKWs4TmT9DRqgrPsirIxlaP9BvZ+Rg7pVVwtZrRLVEhO4dPOTA1?=
 =?us-ascii?Q?5foHC0u2RlSX14NPTdYN3sMCndsvnxPKk+1LNZTZ7PHfudbN6ngTNKiI/LYV?=
 =?us-ascii?Q?QrzBeoip/q+Duh7NMCxP+VRCR7A1g1KSV6vET5iwzOoU7xXLxJL7p+zyLIji?=
 =?us-ascii?Q?ZbwQOiWPFgEt4IhrfNv0fBGqyul7gytMEDS+Ni4hVqYOfMJDnlvi/byfKsVr?=
 =?us-ascii?Q?epaUcDI/MbFY/PFwA87Bz6DcsUDXZhG5FzrO5BGs6qWc1ZxrsCaOBDQ1dFXf?=
 =?us-ascii?Q?uwxb7vWFbWkLZFkN9Z33+BPRM38aG7MZDo3tyym0+Mlc+I5lRdaUTllLQUnH?=
 =?us-ascii?Q?0aBNlR5w5WTp3KtrnGl2lgIpcEb5K4T6PPGrx/tVgsc2Tm8OWqRMEW5S8+sR?=
 =?us-ascii?Q?n7z7oVnsR1x/xQW4TGcqeEleDsqUdYCQHSSq+1dK8u+OfBT7JhYs1x8PuVL2?=
 =?us-ascii?Q?Tp/M/DsqgQdUyBfyEjL0DjKiHgSpxMLiUaVOBDSWqUD/LOFPmczmSGa3P5zv?=
 =?us-ascii?Q?NWqo9ah8jphNwfPShTlu5NTdRTwY4c2n/0xZGMpiS69ZkMU87WCmc7XkyDu7?=
 =?us-ascii?Q?9Lk6RJ5rwwpDtzu4cePYevPQNBQTQ7fnDYKnybuUn+iRvLZTMGBet7h8d1m1?=
 =?us-ascii?Q?68ZwVThM/JPVX6ugODbdeDLm/O9gi54WCW+3zuNe6++TyYYATJQrXahkbql9?=
 =?us-ascii?Q?868LyFBG8gXduEZVhaU9SNdIQz7axmOLROUWbe+OOa94YufK+10ugIRUwSxW?=
 =?us-ascii?Q?7MD5bJ1lyvntHanimXf/t9utkUcJE9Q7Es7/XNur?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5e7dac1d-4c7c-4f84-5e53-08da8ee792d2
X-MS-Exchange-CrossTenant-AuthSource: PSAPR06MB4021.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Sep 2022 02:37:28.0539
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: gTwplbsYzZc7AFs/AKf+xYSiMEYxZbpwEGIOKdPNDYnc2+pjzIRduPAHBXv9/fhq8XCLYL+yhOEcJ3gDhmgB8g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SG2PR06MB5155
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

This patch try to fix syzbot error:
=====================================================
BUG: KMSAN: uninit-value in update_triggers kernel/sched/psi.c:525 [inline]
BUG: KMSAN: uninit-value in psi_poll_work kernel/sched/psi.c:626 [inline]
BUG: KMSAN: uninit-value in psi_poll_worker+0x972/0x16a0 kernel/sched/psi.c:648
 update_triggers kernel/sched/psi.c:525 [inline]
 psi_poll_work kernel/sched/psi.c:626 [inline]
 psi_poll_worker+0x972/0x16a0 kernel/sched/psi.c:648
 kthread+0x31b/0x430 kernel/kthread.c:376
 ret_from_fork+0x1f/0x30

Uninit was stored to memory at:
 collect_percpu_times+0x193d/0x19a0 kernel/sched/psi.c:355
 psi_poll_work kernel/sched/psi.c:604 [inline]
 psi_poll_worker+0x587/0x16a0 kernel/sched/psi.c:648
 kthread+0x31b/0x430 kernel/kthread.c:376
 ret_from_fork+0x1f/0x30

Uninit was stored to memory at:
 collect_percpu_times+0x193d/0x19a0 kernel/sched/psi.c:355
 psi_poll_work kernel/sched/psi.c:604 [inline]
 psi_poll_worker+0x587/0x16a0 kernel/sched/psi.c:648
 kthread+0x31b/0x430 kernel/kthread.c:376
 ret_from_fork+0x1f/0x30

Uninit was stored to memory at:
 collect_percpu_times+0x193d/0x19a0 kernel/sched/psi.c:355
 psi_poll_work kernel/sched/psi.c:604 [inline]
 psi_poll_worker+0x587/0x16a0 kernel/sched/psi.c:648
 kthread+0x31b/0x430 kernel/kthread.c:376
 ret_from_fork+0x1f/0x30

Uninit was created at:
 slab_post_alloc_hook mm/slab.h:732 [inline]
 slab_alloc_node mm/slub.c:3258 [inline]
 slab_alloc mm/slub.c:3266 [inline]
 kmem_cache_alloc_trace+0x696/0xdf0 mm/slub.c:3297
 kmalloc include/linux/slab.h:600 [inline]
 psi_cgroup_alloc+0x83/0x250 kernel/sched/psi.c:960
 cgroup_create kernel/cgroup/cgroup.c:5430 [inline]
 cgroup_mkdir+0x10a3/0x3080 kernel/cgroup/cgroup.c:5550
 kernfs_iop_mkdir+0x2ba/0x520 fs/kernfs/dir.c:1185
 vfs_mkdir+0x62a/0x870 fs/namei.c:4013
 do_mkdirat+0x466/0x7b0 fs/namei.c:4038
 __do_sys_mkdirat fs/namei.c:4053 [inline]
 __se_sys_mkdirat fs/namei.c:4051 [inline]
 __x64_sys_mkdirat+0xc4/0x120 fs/namei.c:4051
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x63/0xcd

syzbot link:
https://syzkaller.appspot.com/bug?id=d04c5407207d11e46007775517b97764174bc45d

Signed-off-by: Bernard Zhao <bernard@vivo.com>
---
 kernel/sched/psi.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/kernel/sched/psi.c b/kernel/sched/psi.c
index ecb4b4ff4ce0..46f048121520 100644
--- a/kernel/sched/psi.c
+++ b/kernel/sched/psi.c
@@ -195,6 +195,9 @@ static void group_init(struct psi_group *group)
 	init_waitqueue_head(&group->poll_wait);
 	timer_setup(&group->poll_timer, poll_timer_fn, 0);
 	rcu_assign_pointer(group->poll_task, NULL);
+	memset(group->avg_total, 0, sizeof(group->avg_total));
+	memset(group->total, 0, sizeof(group->total));
+	memset(group->avg, 0, sizeof(group->avg));
 }
 
 void __init psi_init(void)
-- 
2.33.1