Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <64519d0b-b696-db47-52c2-303451e10c09@amd.com>
Date:   Mon, 5 Sep 2022 10:35:44 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCHv8 00/11] Linear Address Masking enabling
Content-Language: en-US
To:     "Kirill A. Shutemov" <kirill@shutemov.name>,
        ananth.narayan@amd.com,
        "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Cc:     Dave Hansen <dave.hansen@linux.intel.com>,
        Andy Lutomirski <luto@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>, x86@kernel.org,
        Kostya Serebryany <kcc@google.com>,
        Andrey Ryabinin <ryabinin.a.a@gmail.com>,
        Andrey Konovalov <andreyknvl@gmail.com>,
        Alexander Potapenko <glider@google.com>,
        Taras Madan <tarasmadan@google.com>,
        Dmitry Vyukov <dvyukov@google.com>,
        "H . J . Lu" <hjl.tools@gmail.com>,
        Andi Kleen <ak@linux.intel.com>,
        Rick Edgecombe <rick.p.edgecombe@intel.com>,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org
References: <20220830010104.1282-1-kirill.shutemov@linux.intel.com>
 <20220904010001.knlcejmw4lg2uzy3@box.shutemov.name>
From:   Bharata B Rao <bharata@amd.com>
In-Reply-To: <20220904010001.knlcejmw4lg2uzy3@box.shutemov.name>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cVUzVlA1TVNWMkg3V3RRNmxMekJXOWQycy9ZVEk5dWEyWGUyYkZRYmQ3alk3?=
 =?utf-8?B?bjkrWWZGM2NBNG1XZzF6VFZTczhpTWhVTkJmdGk4Tkp1cU1CVlJsK0VkZlFK?=
 =?utf-8?B?UzM0R0dtc0Z4QzZRcGtyR2hFcTkvZEpIRDJaUzg4ZEVQbXBZVXZseXg4VFo3?=
 =?utf-8?B?M2NEZ2UvVy9OZ3lNWkZHVHc5N3lnQXBwYVpNMHVXd01RaXBTMXNSSDB0NWds?=
 =?utf-8?B?OGZnOGdJOG9MbUVZN3YvSStSK25WOE9tbDljS3ZsRlJNRlRxa2NvM2xrNjdI?=
 =?utf-8?B?bzlXL0dDSzVCb1N2SEhXT1RUbmltdzBFQ0xqRW1vTVk5SDNBN05iOWVrZ29L?=
 =?utf-8?B?TU5iaHFaYmpSN0Y1UU1FeDhTLzJDazZ3YmNaU1dmSTV5OFR5U2t1RjZFbEYr?=
 =?utf-8?B?U2QzWjM4ejFmbnhHbDg2c3lBYm1WNWorOHJmL1VSVFRHbVhHVTZVVjVjaDFI?=
 =?utf-8?B?TFREUkJYVWdQWWhJU2RHMHIwSzZCMWV4VjNlRytaZkRTZ082bStsdmYvVUk5?=
 =?utf-8?B?d0NBVFBrNG56TlZRVVJVRk5TdGd4SkN2SldyU1Z3dU1EeEFRZXV4RTZ6WkVa?=
 =?utf-8?B?MzFiSTRJYjI4ZnJ5TFJZMUd1SnRIcHQxeStLc3V0Zk8ydWJwVFJGN044MjlG?=
 =?utf-8?B?Nk4vaFdMa203Rjlhanp3Q1BLcisxMFV4ZG5IOEhqdVNQRjFMV2FFWHRxR3Vn?=
 =?utf-8?B?QVE2bTloUUVqVTRyT0lqV0tJSThGcmZob1EzQnAzcEt6UzNmYytlK1FxWm5u?=
 =?utf-8?B?SCsybkVRTktsZFVnWW9HVEMvK2poT1dkdmtPOVBLbmMvaXQ1bjg2UTFxOHVM?=
 =?utf-8?B?SXRFczF1QXhEWGNvbFZ4YnpzMGZUUUhFNUNuWmZuVXIwQXZwUEt5Q2NIVkpn?=
 =?utf-8?B?K1YrK3NDanFmaUo3Yy9iMTJKVytZeUhEUVVCakx3a2RnVUsxMFNMd3RQQytT?=
 =?utf-8?B?V1ovNmhQYWpqRzhZekwyTlQrc1FrMXhrNVRxclVCUEh1OXFIejJnSEhZM2RL?=
 =?utf-8?B?c2NQbnkwbHpxSTlxRmNDWklxNzBvVDRpeHFRTEQrTzYxbGFDR0NMMHREak1v?=
 =?utf-8?B?MmREWW5ZeGcyNjZpZUVSR08yT3JjbzBjT3NKcVpBRm8yT21hV0Voa0pUTnNa?=
 =?utf-8?B?VjZVNVUvd0s2U0ZZZ3cvKzZibitta3huRVRMUUptNTdUQkc2VFB1OWVCZXpF?=
 =?utf-8?B?dzhYbHF6a1dRRFBnM1lWbVphbHpjQWRJeEdKRnBzNVVuYWF2RFZpblBLRjdP?=
 =?utf-8?B?dFRKcUxLdFd1QUZQQUZDSWdzcFR2WXc0WUVLUnk1djhUczE1cWFaZHhoZjRG?=
 =?utf-8?B?YW9WM2hxRDZTeXREc2IrTmQyZXN1U3djVWZNdnE5NmsxL0g1UDMzeHdrUkRk?=
 =?utf-8?B?cHo3a0E4NS9nK29hRmw5cnJKWHFUSU84YmRreDBic0kyb3ZObkpEWkppbXJr?=
 =?utf-8?B?U2J5eW9rK2FVRTdKbnE1TzF2eW1vS0ZwOFllcGp0WEFQelliNExpck16WUpa?=
 =?utf-8?B?VGpQSnF6SzR5UnN3Q1haZHBUOFhBdUxKdmxHNXUvY2VFSWV5NldPUit4VUVv?=
 =?utf-8?B?VytuNXdCVy9kSS9TU092UVFoTSt0Z3ZLVE56TVFZSzc4aERHMENubitlaXll?=
 =?utf-8?B?TndtWVRZdkZkZWhiaTEwUDlGUzJvV1JlNHhQSXdhb0lzejQxa0FPQjBqNFEz?=
 =?utf-8?B?RnBpc1Z6MkdZeVEyOGg0S0lnSjJ5Q2JrT3h6UjZWTklpUHlUS3BGQkpwcjVE?=
 =?utf-8?B?Y3c5VFJ5SkVud3NLTUFXa1dvdHBiemQ0LzVjNGhvNERrLy9zaTBaUzNRY1dh?=
 =?utf-8?B?V3lCcXg5R3ZReElUSVB3K3pRYXhzbWVpZEhWMmpBbFp1TGl0bWhvK2tGNUNz?=
 =?utf-8?B?TkVYUTljK09XREFkbEtBYUlGTmw2azUrWnBXNW1lbnZkNGZYMS9FcEM2SDNn?=
 =?utf-8?B?S3FsaDRZekFpNGdXMU4yR29nRmZUZVNsQi9kdWlzTmNPSlRyZmQ1RFlJZVRk?=
 =?utf-8?B?d3ZkQ1Zlck5YOEdRclFWNkxKNkRiajdkMG1UVUlIQklIak9KUWVobnNqZlJU?=
 =?utf-8?B?YmVuTlUrcHYzRVVjazF5ekRBN2lsbXVlclZPMVVXQ1hVc1lQb3FQNFMvLzRL?=
 =?utf-8?Q?oigydk/9PBB4N3oNwPMeI+pvS?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 99bfed81-5016-4385-291f-08da8efc5144
X-MS-Exchange-CrossTenant-AuthSource: IA1PR12MB6434.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Sep 2022 05:05:57.5326
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VW0cBvgvNKDgEejahGC820814+1mwxKyVIS4jlW7JVjJfhS2j3SLjtn0iCIj76gC338wBML3ldajSYOfQ55Zmg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB5789
X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Kirill,

On 9/4/2022 6:30 AM, Kirill A. Shutemov wrote:
> On Tue, Aug 30, 2022 at 04:00:53AM +0300, Kirill A. Shutemov wrote:
>> Linear Address Masking[1] (LAM) modifies the checking that is applied to
>> 64-bit linear addresses, allowing software to use of the untranslated
>> address bits for metadata.
>>
>> The patchset brings support for LAM for userspace addresses. Only LAM_U57 at
>> this time.
>>
>> Please review and consider applying.
>>
>> git://git.kernel.org/pub/scm/linux/kernel/git/kas/linux.git lam
> 
> +Bharata, Ananth.
> 
> Do you folks have any feedback on the patchset?
> 
> Looks like AMD version of the tagged pointers feature does not get
> traction as of now, but I want to be sure that the interface introduced
> here can be suitable for your future plans.
> 
> Do you see anything in the interface that can prevent it to be extended to
> the AMD feature?

The arch_prctl() extensions is generic enough that it should be good.

The untagged_addr() macro looks like this from one of the callers:

        start = untagged_addr(mm, start);
ffffffff814d39bb:       48 8b 8d 40 ff ff ff    mov    -0xc0(%rbp),%rcx
ffffffff814d39c2:       48 89 f2                mov    %rsi,%rdx
ffffffff814d39c5:       48 c1 fa 3f             sar    $0x3f,%rdx
ffffffff814d39c9:       48 0b 91 50 03 00 00    or     0x350(%rcx),%rdx
ffffffff814d39d0:       48 21 f2                and    %rsi,%rdx
ffffffff814d39d3:       49 89 d6                mov    %rdx,%r14

Can this overhead of a few additional instructions be removed for
platforms that don't have LAM feature? I haven't measured how much
overhead this effectively contributes to in real, but wonder if it is
worth optimizing for non-LAM platforms.

Regards,
Bharata.