Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 5 Sep 2022 11:56:14 +0530
From:   Vinod Koul <vkoul@kernel.org>
To:     Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
Cc:     michal.simek@xilinx.com, m.tretter@pengutronix.de,
        dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
        git@amd.com, Shravya Kumbham <shravya.kumbham@xilinx.com>,
        Harini Katakam <harini.katakam@xilinx.com>
Subject: Re: [PATCH] dmaengine: zynqmp_dma: Typecast with enum to fix the
 coverity warning
Message-ID: <YxWWhov7bjz2J+Ur@matsya>
References: <1653378553-28548-1-git-send-email-radhey.shyam.pandey@amd.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1653378553-28548-1-git-send-email-radhey.shyam.pandey@amd.com>
Precedence: bulk

On 24-05-22, 13:19, Radhey Shyam Pandey wrote:
> From: Shravya Kumbham <shravya.kumbham@xilinx.com>
> 
> Typecast the flags variable with (enum dma_ctrl_flags) in
> zynqmp_dma_prep_memcpy function to fix the coverity warning.

Applied, thanks

> 
> Addresses-Coverity: Event mixed_enum_type.
> Signed-off-by: Shravya Kumbham <shravya.kumbham@xilinx.com>
> Signed-off-by: Harini Katakam <harini.katakam@xilinx.com>
> Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
> ---
> NOTE- This patch was sent to dmaengine mailing list[1] and
> there was a suggestion from Michael Tretter to change the
> signature of the dmaengine_prep_dma_memcpy() engine to accept
> "enum dma_ctrl_flags flags" instead of "unsigned long flags".
> 
> All device_prep_dma_* API variants have ulong flags argument.
> So this is a wider question if we want to change these APIs?
> Also there are existing users of these public APIs.

It would be very nice to do this change but users would need to be
updated as well, patches are welcome

-- 
~Vinod