Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <501af8f5-c1bd-7b16-815e-a4b13f953eeb@amd.com>
Date:   Mon, 5 Sep 2022 13:19:00 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCHv4 1/8] x86/cpu: Add CPUID feature bit for VNMI
Content-Language: en-US
To:     Jim Mattson <jmattson@google.com>,
        Paolo Bonzini <pbonzini@redhat.com>
Cc:     Sean Christopherson <seanjc@google.com>,
        Vitaly Kuznetsov <vkuznets@redhat.com>,
        Joerg Roedel <joro@8bytes.org>,
        Tom Lendacky <thomas.lendacky@amd.com>, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org, mlevitsk@redhat.com,
        mail@maciej.szmigiero.name
References: <20220829100850.1474-1-santosh.shukla@amd.com>
 <20220829100850.1474-2-santosh.shukla@amd.com>
 <CALMp9eTrz2SkK=CjTSc9NdHvP4qsP+UWukFadbqv+BA+KdtMMg@mail.gmail.com>
 <a599f0da-3d9b-a37f-af7c-aa1310ed77e1@amd.com>
 <CALMp9eT3zHqZhDLKV=5UTnwLsvmbkpqibsh4tjqFnW4+MGR4aw@mail.gmail.com>
From:   "Shukla, Santosh" <santosh.shukla@amd.com>
In-Reply-To: <CALMp9eT3zHqZhDLKV=5UTnwLsvmbkpqibsh4tjqFnW4+MGR4aw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Rk5JQlYxZFd5VTFRemlySHI0cktBVEhwMngzN0lGTlN6cG0ycWp0WjRDSXlI?=
 =?utf-8?B?Nmx1YWNCeHAvN1ByNC9Uajl1WW8yaENUa3BBMk5hby9PZDZCZFFWWm93OWkw?=
 =?utf-8?B?SWpmSUY3K3R5cXdGZjIwSzhqL29hVDNEeWphTGpoRjcwOFhHRmRHbStSbWdy?=
 =?utf-8?B?T2lqalNXZGc2M1pGM0tyT3JqNm5rYklhS3RMcmxFbzRqcHB6V3NVTThOL2Zm?=
 =?utf-8?B?TE5qMkgzOFdyWEhWRlk3YmxjVmpBNnp4ZWtrK3NWclBoeFBYemVIaURBS1RO?=
 =?utf-8?B?UWdibmZrT1FpVGNsQ29xOS92eDU2Z0ZBTnByZ3hCUTUxUkQrMVByL0hOcDVt?=
 =?utf-8?B?UU9ZcEZnVktCUjNITWNsVFJaazZJa2VFR2V1Yi9zUzlkcFB1T1pxUzZ4YXps?=
 =?utf-8?B?MmtSVDVldkVrZTAxRTI3aEFqQkFFYjZGZ2lZVWNpWkVvSlFPbGthSm8zYXpP?=
 =?utf-8?B?NGRuOWxJVmhXdkpHSlV4eXVZMC9jZEJ6cTZEYXRHc3Q3bHlDTk5xR2pYcExV?=
 =?utf-8?B?dGNTbmtiMXF4VHVpUzdJS1h1anhuQ09QbnI2NTNHU1VNa3psRUVJeGJPOVB1?=
 =?utf-8?B?QWRiTjBOeFBneEtrMGJENTczME1vbFFmc1p6MGt6cnZ5ZElwcjJBcXUzenF6?=
 =?utf-8?B?Q3ZITGZqRFJhcjMxZnB0VE0zb2tPMjB3a3RkK2RVakV0TVozNGhKRVRrUXFy?=
 =?utf-8?B?MFhtQ3ZVVVBPNkF2LzNEQi8yUDBXSklSa016S1dtRVFqREowOGxITmprYlQy?=
 =?utf-8?B?M2g2a0lDd2t0VkpRMEswcnVQeDJkNTcxdEIrMmd1Wkd4LzV6MUV2QlcxdWpr?=
 =?utf-8?B?a2ZKMEcvcEtxOVNRSSs4TVVLeUdqbE1YWXhQNUR0OEpLdjhObHVHOVNmQ1B5?=
 =?utf-8?B?ellyYjZIdEZUTmordkNtN01EcnI2Uzc4OFBSMCs0dDZiUW5yOFoyd01sb2dz?=
 =?utf-8?B?Ui9IMUJyOEZjdk5EN1EySktWQktpMXVPSXVsQStWU2JkdlVsQkp6UDNqdGUv?=
 =?utf-8?B?TjJFMHIxN1hjUERWR0UzNXJpc1d0TlNhSnBEZjBGREJKaVI4Ulc5ekdqUmlX?=
 =?utf-8?B?ZGdKa21RYk91b1o5VzBYM3VneC9YWk5PT3JvRmdDa01tWXN5M0dnRjQwNThl?=
 =?utf-8?B?djlvY3JyQW5lQkdSMFRmQ0paSlQySjQ0MURRUzFQZFc0dERvWmUyNlgvSUZ1?=
 =?utf-8?B?QkJpQ3JoalhNckRGWlZMV2Rtc0pNUjByaE1iTCtseDFxUWRWYzZucXlva0t3?=
 =?utf-8?B?VGRCQ1Izbk9aQVQxd3Y1SnRSZUNtLzRQaGFVemk5anI0NVhaNWRZR2I5MVlZ?=
 =?utf-8?B?M1BJSSt2RDlUa1hhMXJjVGEvVmxvRWlqeXkvMDAyT1l0aERSN2V0RzNmM0FJ?=
 =?utf-8?B?Q2RjWVBnM05PRHVWd3BxbzZodEEySmpERXlLc3BtRHNVV01LeDJNeDk2OGF5?=
 =?utf-8?B?eFFSWFZYMDRlY05xclJpb3RBYkZwaHlYa0w4RUJxY0Z6MUl2cHBBakhFTXFO?=
 =?utf-8?B?by9YVzYwc1lpOVJKTy9HMTBVYjZBSDF3aU4xRWZTWjlvc0ZZNyt5eHNaMzA1?=
 =?utf-8?B?N3JYTUVVN2U1cFRGUEZRaW1QV3dVQnNYajlxSmk4ckJzVG5vTUlNbzVyK1Vr?=
 =?utf-8?B?UW1GYkNzR0lTSnlxMWVSTStxenVEOEVYY1c0WklpRkhUNDNrRHhtWUxLZ2Vo?=
 =?utf-8?B?bUd4dGIzcXF3ais5T3FyWjdyY2pJdHRZZmdaT29hWG5ybEFJdXhxNjFKTGVR?=
 =?utf-8?B?akdkcTBsbUxiUmp2ait6OHg0S01BWWtlaGQxb3lTaGZGUy9mZUF2WkhFQS9t?=
 =?utf-8?B?YnZEYnlWMlBWcjNyK0hhNlcvU2pHdWR6N1F4NzNvS2V4NVBsRW1XQTh2UGYv?=
 =?utf-8?B?aE5zM0hTRTFTN3JNSzlnQ1lXb25ndGw4S1ZaQ0x1bUM2aFFDUXk5QWRPMnBs?=
 =?utf-8?B?QmU1b0d4bFdTckk3Q2hMakdFTjk3NGFyQTR4UnlnOWVIS2Vkb1ZCdDZ3azFU?=
 =?utf-8?B?RkQ0aGEveklNVnBqQ0FIYmhqZkxLcnV4NlpzSXN6ZjZ4UWt5ZWR0TW4rQmkz?=
 =?utf-8?B?c2VjR0Z0YVJXL1ZyNHdIWDNxNTlDZGtaaDBFVWhpQ3dKNjJYS2VtemNXcFlV?=
 =?utf-8?Q?CGONh7XXyutA6qle9/WRT9S8t?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c89f8066-27bc-4231-eb6a-08da8f131fec
X-MS-Exchange-CrossTenant-AuthSource: CY5PR12MB6323.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Sep 2022 07:49:13.2554
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: DH39qIfOFeE9DXpdy1Gx5bUs3bsKLMH1fQ40A+6Cim4N03WDERHmcUFjElH/QYlemTPIi3oHU23QeDJstZfRXA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4159
X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 9/1/2022 11:13 PM, Jim Mattson wrote:
> On Thu, Sep 1, 2022 at 5:45 AM Shukla, Santosh <santosh.shukla@amd.com> wrote:
>>
>> Hi Jim,
>>
>> On 9/1/2022 5:12 AM, Jim Mattson wrote:
>>> On Mon, Aug 29, 2022 at 3:09 AM Santosh Shukla <santosh.shukla@amd.com> wrote:
>>>>
>>>> VNMI feature allows the hypervisor to inject NMI into the guest w/o
>>>> using Event injection mechanism, The benefit of using VNMI over the
>>>> event Injection that does not require tracking the Guest's NMI state and
>>>> intercepting the IRET for the NMI completion. VNMI achieves that by
>>>> exposing 3 capability bits in VMCB intr_cntrl which helps with
>>>> virtualizing NMI injection and NMI_Masking.
>>>>
>>>> The presence of this feature is indicated via the CPUID function
>>>> 0x8000000A_EDX[25].
>>>>
>>>> Reviewed-by: Maxim Levitsky <mlevitsk@redhat.com>
>>>> Signed-off-by: Santosh Shukla <santosh.shukla@amd.com>
>>>> ---
>>>>  arch/x86/include/asm/cpufeatures.h | 1 +
>>>>  1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/arch/x86/include/asm/cpufeatures.h b/arch/x86/include/asm/cpufeatures.h
>>>> index ef4775c6db01..33e3603be09e 100644
>>>> --- a/arch/x86/include/asm/cpufeatures.h
>>>> +++ b/arch/x86/include/asm/cpufeatures.h
>>>> @@ -356,6 +356,7 @@
>>>>  #define X86_FEATURE_VGIF               (15*32+16) /* Virtual GIF */
>>>>  #define X86_FEATURE_X2AVIC             (15*32+18) /* Virtual x2apic */
>>>>  #define X86_FEATURE_V_SPEC_CTRL                (15*32+20) /* Virtual SPEC_CTRL */
>>>> +#define X86_FEATURE_V_NMI              (15*32+25) /* Virtual NMI */
>>>>  #define X86_FEATURE_SVME_ADDR_CHK      (15*32+28) /* "" SVME addr check */
>>>
>>> Why is it "V_NMI," but "VGIF"?
>>>
>> I guess you are asking why I chose V_NMI and not VNMI, right?
>> if so then there are two reasons for going with V_NMI - IP bits are named in order
>> V_NMI, V_NMI_MASK, and V_NMI_ENABLE style and also Intel already using VNMI (X86_FEATURE_VNMI)
> 
> I would argue that inconsistency and arbitrary underscores
> unnecessarily increase the cognitive load. It is not immediately
> obvious to me that an extra underscore implies AMD. What's wrong with
> X86_FEATURE_AMD_VNMI? We already have over half a dozen AMD feature

AMD prefix (X86_FEATURE_AMD_VNMI) is fine with me.

> bits that are distinguished from the Intel version by an AMD prefix.

Hi Paolo,

  Is there any other suggestions/comment on v4? Should I send v5 with Prefix change or
you're ok to consider v4 with AMD prefix change?

Thanks,
Santosh