Received: by 2002:a05:6358:bb9e:b0:b9:5105:a5b4 with SMTP id df30csp2865997rwb; Mon, 5 Sep 2022 02:50:29 -0700 (PDT) X-Google-Smtp-Source: AA6agR7jfvDtz/9UlQHeFhstdjl79UpiwdhRbDZkUb03KlkOc7PNVmJ6Z3HaoE6Fw1CsUg96T2zc X-Received: by 2002:a63:4d4a:0:b0:430:87bb:f72e with SMTP id n10-20020a634d4a000000b0043087bbf72emr16033728pgl.384.1662371429487; Mon, 05 Sep 2022 02:50:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662371429; cv=none; d=google.com; s=arc-20160816; b=rpjDv9N0pzXZOs4S9PdUEqJ6Tm+3qoUzZ/0+lp83QaCvzU7aOZemuOOBCee+NAjpCT kcj/Fz0xguaPZDhHZvMsZPtdklc0Mj6nXnBaU+5hyp9feqmzMzkCrYHIWBe7vejzKvuF 3DPpRyD2IlkW/XMVHCRwvlWN7L5L2Bs1D89tiB3k9kWyVcQYeq6iJqFOsMhazqsdLjIi SxkROo+cieK2Laoa7M8tRBR72nbDD0TyuuN3o1CC0WeQLVM6O0VSD4j1nY/dvMNHjlb1 qdll0HQXahehHfSTC2FpNk+GDxr1GB15GyNPu1dN/TwjoIdsGB2pMyjVaoni6eBLpxf8 026g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:references :organization:in-reply-to:subject:cc:to:from:dkim-signature; bh=6IM5a7xW1CR4k+sRwTPKB5tdMi7ni8M7lX3MTYiMgD8=; b=vjaxl1ykgMz+w/fxATiE8KVh5DOr0agtKW/BQYd6+8tpXo+uBM4xD6d0n15UBbBrIv /mDgy3t78F6qbwtDr4soCKLeo8mHZYzze8WkXNMxAlpMbw99WNB+6HB9YOUNoM4IAHwg KOzMJBABpjtglkcQtVJ2wRNj2O0MyvMw4tQmfSmEo11eNRt85wW7NcNCD7W8nt/z+Ley lZL6TweQ28woOtwSpk4oLaE8LWhGQYZY9pqeX4AVblUGA4QeGWeI1sTZI5xY/WvidVjT 8FJIdvtY9V2qi75j9ab4TYrB8aAccLxhKBAA4oE1fYDFBl+2SmmkItdKfdCNW/vpshHj Olfg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=jbIp+lk1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e10-20020a17090301ca00b0016dcf421fe9si11193151plh.486.2022.09.05.02.50.18; Mon, 05 Sep 2022 02:50:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=jbIp+lk1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238246AbiIEItx (ORCPT + 99 others); Mon, 5 Sep 2022 04:49:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46014 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238211AbiIEItt (ORCPT ); Mon, 5 Sep 2022 04:49:49 -0400 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B4A53BC0F for ; Mon, 5 Sep 2022 01:49:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1662367787; x=1693903787; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=4D3RAQxQy6SFrkYw939qLRwPf9Fd7iF48Kn/A1uq7TQ=; b=jbIp+lk1S6psnyhybPOASQmaTmHTRXiAEobkyuPPTwb1RteE6Gko+uqw s3ZrEiZGuAVAP2JidrqHBaqudhkZSAOcdau+NgjGZwAe0YcAB3EeljCIc Q5cq2WlTYo/bIM2DFFNVwn5XPeKgvziUoPo4UXL5wgsZJHf3WpbtIuaH0 rAvHJoYPSiiwWP37QZw4Ko+pfRv5tDYZH/qbkzYcEv7ggnC4U4RH4IGhZ f8zOtP+tXZNxy0CDKN2pwCSVXyJ1Mqp7R0NpORm8/WvbykOi83AiEUyBz 1fnMWMTZtYPy9cqJmOfljJCa4i8Zvv05sBXgIl7dMR1d0hpN+O/71TREq w==; X-IronPort-AV: E=McAfee;i="6500,9779,10460"; a="382641441" X-IronPort-AV: E=Sophos;i="5.93,290,1654585200"; d="scan'208";a="382641441" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Sep 2022 01:49:47 -0700 X-IronPort-AV: E=Sophos;i="5.93,290,1654585200"; d="scan'208";a="675199754" Received: from smaciag-mobl2.ger.corp.intel.com (HELO localhost) ([10.252.57.57]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Sep 2022 01:49:44 -0700 From: Jani Nikula To: Jingyu Wang , maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@linux.ie, daniel@ffwll.ch, Joe Perches Cc: Jingyu Wang , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH] drm/print: cleanup coding style in drm_print.h In-Reply-To: <87wnaib45t.fsf@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20220904203818.16775-1-jingyuwang_vip@163.com> <87wnaib45t.fsf@intel.com> Date: Mon, 05 Sep 2022 11:49:28 +0300 Message-ID: <87sfl6b3zb.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 05 Sep 2022, Jani Nikula wrote: > On Mon, 05 Sep 2022, Jingyu Wang wrote: >> Fix everything checkpatch.pl complained about in drm_print.h [...] >> static inline void >> -drm_vprintf(struct drm_printer *p, const char *fmt, va_list *va) >> +drm_vprintf(struct drm_printer *p, const char *fmt, va_list * va) > > Checkpatch is just confused here. Look at all the other params, why > would you add an extra space here? Joe, can you help me out here please, I can't figure out why checkpatch is complaining here: include/drm/drm_print.h:106: CHECK:SPACING: spaces preferred around that '*' (ctx:WxV) #106: FILE: include/drm/drm_print.h:106: +drm_vprintf(struct drm_printer *p, const char *fmt, va_list *va) BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center