Received: by 2002:a05:6358:bb9e:b0:b9:5105:a5b4 with SMTP id df30csp2910519rwb; Mon, 5 Sep 2022 03:38:26 -0700 (PDT) X-Google-Smtp-Source: AA6agR4EYGIoa2ukA9Ju1E9KlqW/7ZjewI5jYQGKbHFZ5DyD4FjaXRp7AbPTkhO3NbECRsDZxsir X-Received: by 2002:a17:907:2bc7:b0:73d:d239:110b with SMTP id gv7-20020a1709072bc700b0073dd239110bmr35343827ejc.752.1662374305809; Mon, 05 Sep 2022 03:38:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662374305; cv=none; d=google.com; s=arc-20160816; b=W9r38/gfN4VVi2htonlKgfULFcd5VKeDKTVPPs6D7Pgd/eqtHAxQdABGvO+uTNOa3P 4PXACWiQmJ0FTLuKp9vmePhXMt0MebLTL0RLwtkTubqkIRbP728WdhZwFzMbzSCfARQB NO+rRd69Z31l9bASS3MScem7qDBINR0MCYi/kDGgt4supWcF2qRkXgtUcsUtE+0Ui7rK BxsGdS9lttiLiwkwxkm98TzNqP+76s8Cb4CU98kMNAn2G9+6lG53a9NhDgrh0NP0QeSl fdE1OS5jNBsmh0MncHgPWKAjvqMmH0M61Adj2lGMX9Rf9yrqVCqhjaSpgSm4QNw/ogdT 4cyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=okrQlGVfIjuGXQKVYqqZW0ODcOTVWluQnknLGVR87kM=; b=pyT54hTz0m++zrYgotgx5ZxdDT7iztTZ9LUpiPguGzeaqAErH4d2s0Y+lmb/8cMoYH 9HvgNKmGvZrCWzenIlVb8TyenORSjvaye+ZSi+DIAzgVm6XCOUkTQSsohRlPkSthw6C1 CqtmtmLpvOe3/y6PNzPScLsVfyPCkEvoXAq4BC6CygEOe0qz4fmwNb9lnvkyjGxmZMGd hGdwdiEY/h7YMFZOQdpbr1pzAlVE5gk+cM2EYcFNfwlvFn9JcBUAylMMyHCtTR0VVR6r 89CRT/5W42nlR8G1zWpdNDBMS/2h303xX6WFiLBf6osxZJy9MFYWde/RVjpkorSoCJ2n mhHA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id oz10-20020a1709077d8a00b0073d70b7bfb6si9074795ejc.277.2022.09.05.03.37.57; Mon, 05 Sep 2022 03:38:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236762AbiIEKWH (ORCPT + 99 others); Mon, 5 Sep 2022 06:22:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33516 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237183AbiIEKVg (ORCPT ); Mon, 5 Sep 2022 06:21:36 -0400 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B97912C664; Mon, 5 Sep 2022 03:20:24 -0700 (PDT) Received: from canpemm500002.china.huawei.com (unknown [172.30.72.53]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4MLkvk3tr0zbkbJ; Mon, 5 Sep 2022 18:16:50 +0800 (CST) Received: from huawei.com (10.175.124.27) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Mon, 5 Sep 2022 18:20:22 +0800 From: Miaohe Lin To: CC: , , Subject: [PATCH] blk-mq: remove unneeded needs_restart check Date: Mon, 5 Sep 2022 18:19:50 +0800 Message-ID: <20220905101950.4606-1-linmiaohe@huawei.com> X-Mailer: git-send-email 2.23.0 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.124.27] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If code reaches here, needs_restart must be true. Remove this unneeded needs_restart check. No functional change intended. Signed-off-by: Miaohe Lin --- block/blk-mq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/blk-mq.c b/block/blk-mq.c index b9f6989cb5bd..be7de99622a2 100644 --- a/block/blk-mq.c +++ b/block/blk-mq.c @@ -1992,7 +1992,7 @@ bool blk_mq_dispatch_rq_list(struct blk_mq_hw_ctx *hctx, struct list_head *list, if (!needs_restart || (no_tag && list_empty_careful(&hctx->dispatch_wait.entry))) blk_mq_run_hw_queue(hctx, true); - else if (needs_restart && needs_resource) + else if (needs_resource) blk_mq_delay_run_hw_queue(hctx, BLK_MQ_RESOURCE_DELAY); blk_mq_update_dispatch_busy(hctx, true); -- 2.23.0