Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220831011248.28632-1-michel@lespinasse.org> <20220831011248.28632-2-michel@lespinasse.org>
In-Reply-To: <20220831011248.28632-2-michel@lespinasse.org>
From:   Ard Biesheuvel <ardb@kernel.org>
Date:   Mon, 5 Sep 2022 12:18:16 +0200
Message-ID: <CAMj1kXG03PdCpSQQHvOFFk=_L-JVgy6DYob6ZLFd8WfDdaTnCQ@mail.gmail.com>
Subject: Re: [PATCH 1/4] Remove unused variable et in efi_get_system_table()
To:     Michel Lespinasse <michel@lespinasse.org>
Cc:     Michael Roth <michael.roth@amd.com>, linux-efi@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, 31 Aug 2022 at 03:12, Michel Lespinasse <michel@lespinasse.org> wrote:
>
> This avoids a build warning with CONFIG_EFI enabled.
>
> Fixes: 7c4146e88855 (x86/compressed/acpi: Move EFI detection to helper)

Please use " inside the ()

Also, the commit id looks wrong to me.

> Signed-off-by: Michel Lespinasse <michel@lespinasse.org>
> ---
>  arch/x86/boot/compressed/efi.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/arch/x86/boot/compressed/efi.c b/arch/x86/boot/compressed/efi.c
> index 6edd034b0b30..c42ee7874eb9 100644
> --- a/arch/x86/boot/compressed/efi.c
> +++ b/arch/x86/boot/compressed/efi.c
> @@ -59,7 +59,6 @@ unsigned long efi_get_system_table(struct boot_params *bp)
>  {
>         unsigned long sys_tbl_pa;
>         struct efi_info *ei;
> -       enum efi_type et;
>
>         /* Get systab from boot params. */
>         ei = &bp->efi_info;
> --
> 2.20.1
>