Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758691AbXFPPjS (ORCPT ); Sat, 16 Jun 2007 11:39:18 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757746AbXFPPjF (ORCPT ); Sat, 16 Jun 2007 11:39:05 -0400 Received: from mailhub.sw.ru ([195.214.233.200]:40842 "EHLO relay.sw.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757780AbXFPPjE (ORCPT ); Sat, 16 Jun 2007 11:39:04 -0400 Date: Sat, 16 Jun 2007 19:39:17 +0400 From: Dmitriy Monakhov To: Hugh Dickins Cc: linux-kernel@vger.kernel.org, npiggin@suse.de, mark.fasheh@oracle.com, linux-ext4@vger.kernel.org Subject: [PATCH] deny partial write for loop dev fd Message-ID: <20070616153917.GC14349@localhost.sw.ru> Mail-Followup-To: Hugh Dickins , linux-kernel@vger.kernel.org, npiggin@suse.de, mark.fasheh@oracle.com, linux-ext4@vger.kernel.org References: <20070613134631.GB13815@localhost.sw.ru> <20070613172939.GE13815@localhost.sw.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1255 Lines: 37 Partial write can be easily supported by LO_CRYPT_NONE mode, but it is not easy in LO_CRYPT_CRYPTOAPI case, because of its block nature. I don't know who still used cryptoapi, but theoretically it is possible. So let's leave things as they are. Loop device doesn't support partial write before Nick's "write_begin/write_end" patch set, and let's it behave the same way after. Signed-off-by: Dmitriy Monakhov --- drivers/block/loop.c | 4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/drivers/block/loop.c b/drivers/block/loop.c index 4bab9b1..de122f3 100644 --- a/drivers/block/loop.c +++ b/drivers/block/loop.c @@ -244,10 +244,8 @@ static int do_lo_send_aops(struct loop_device *lo, struct bio_vec *bvec, ret = pagecache_write_end(file, mapping, pos, size, copied, page, fsdata); - if (ret < 0) + if (ret < 0 || ret != copied) goto fail; - if (ret < copied) - copied = ret; if (unlikely(transfer_result)) goto fail; -- 1.5.2 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/