Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e55fa28e-6f9c-dcb4-3406-95dfbea8387a@gmail.com>
Date:   Mon, 5 Sep 2022 12:41:18 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.12.0
Subject: Re: [PATCH] io_uring/notif: Remove the unused function
 io_notif_complete()
Content-Language: en-US
To:     Jiapeng Chong <jiapeng.chong@linux.alibaba.com>, axboe@kernel.dk
Cc:     io-uring@vger.kernel.org, linux-kernel@vger.kernel.org,
        Abaci Robot <abaci@linux.alibaba.com>
References: <20220905020436.51894-1-jiapeng.chong@linux.alibaba.com>
From:   Pavel Begunkov <asml.silence@gmail.com>
In-Reply-To: <20220905020436.51894-1-jiapeng.chong@linux.alibaba.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 9/5/22 03:04, Jiapeng Chong wrote:
> The function io_notif_complete() is defined in the notif.c file, but not
> called elsewhere, so delete this unused function.

Yep, forgot to kill it, LGTM

Reviewed-by: Pavel Begunkov <asml.silence@gmail.com>


> io_uring/notif.c:24:20: warning: unused function 'io_notif_complete' [-Wunused-function].
> 
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2047
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
>   io_uring/notif.c | 8 --------
>   1 file changed, 8 deletions(-)
> 
> diff --git a/io_uring/notif.c b/io_uring/notif.c
> index 96f076b175e0..1a7abd7e5ca5 100644
> --- a/io_uring/notif.c
> +++ b/io_uring/notif.c
> @@ -21,14 +21,6 @@ static void __io_notif_complete_tw(struct io_kiocb *notif, bool *locked)
>   	io_req_task_complete(notif, locked);
>   }
>   
> -static inline void io_notif_complete(struct io_kiocb *notif)
> -	__must_hold(&notif->ctx->uring_lock)
> -{
> -	bool locked = true;
> -
> -	__io_notif_complete_tw(notif, &locked);
> -}
> -
>   static void io_uring_tx_zerocopy_callback(struct sk_buff *skb,
>   					  struct ubuf_info *uarg,
>   					  bool success)

-- 
Pavel Begunkov